From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: patch: vc.el annotation prev/next "in place" Date: Tue, 11 Apr 2006 16:29:22 -0400 Message-ID: <87zmir501v.fsf-monnier+emacs@gnu.org> References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1144787481 5093 80.91.229.2 (11 Apr 2006 20:31:21 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 11 Apr 2006 20:31:21 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 11 22:31:19 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FTPW9-0006f8-Ij for ged-emacs-devel@m.gmane.org; Tue, 11 Apr 2006 22:31:17 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FTPW8-0007Zf-Rk for ged-emacs-devel@m.gmane.org; Tue, 11 Apr 2006 16:31:16 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FTPVv-0007Yc-5M for emacs-devel@gnu.org; Tue, 11 Apr 2006 16:31:03 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FTPVt-0007XK-5O for emacs-devel@gnu.org; Tue, 11 Apr 2006 16:31:02 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FTPVt-0007XH-2X for emacs-devel@gnu.org; Tue, 11 Apr 2006 16:31:01 -0400 Original-Received: from [209.226.175.34] (helo=tomts13-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FTPap-0003Qr-8g for emacs-devel@gnu.org; Tue, 11 Apr 2006 16:36:07 -0400 Original-Received: from alfajor ([70.55.147.51]) by tomts13-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20060411203100.FQON29052.tomts13-srv.bellnexxia.net@alfajor>; Tue, 11 Apr 2006 16:31:00 -0400 Original-Received: by alfajor (Postfix, from userid 1000) id 7ADC42FDA3; Tue, 11 Apr 2006 16:29:22 -0400 (EDT) Original-To: Kevin Rodgers In-Reply-To: (Kevin Rodgers's message of "Wed, 05 Apr 2006 16:37:24 -0600") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:52720 Archived-At: > From its name we can assume vc-annotate-display-select is supposed to > select the annotation buffer as well as display it, but it doesn't. In > fact, it doesn't even make sure the current buffer is displayed. > Wouldn't it make more sense if this bit in vc-annotate-display-select: > (when buffer > (set-buffer buffer) > (display-buffer buffer)) > were changed to: > (pop-to-buffer (or buffer (current-buffer))) Yes, that'd make sense. Stefan