unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Chong Yidong <cyd@stupidchicken.com>
To: rms@gnu.org
Cc: David Koppelman <koppel@ece.lsu.edu>, emacs-devel@gnu.org
Subject: Re: Changes to hi-lock before release.
Date: Sat, 21 Apr 2007 13:32:52 -0400	[thread overview]
Message-ID: <87zm51ab0b.fsf@stupidchicken.com> (raw)
In-Reply-To: <E1HfGbN-0006PL-IH@fencepost.gnu.org> (Richard Stallman's message of "Sat\, 21 Apr 2007 10\:30\:13 -0400")

Richard Stallman <rms@gnu.org> writes:

> I just clarified the documentation of this feature, as well
> as fixing Texinfo usage.  But I think some change is probably
> called for in the feature.
>
>     +(defvar hi-lock-file-patterns-policy 'never
>
> Shouldn't that be a defcustom?
> It should also have a risky-local-variable property
> since its value can be a function.

Let's just keep things as they are for now.

> Also, it seems absurd for an explicit call to hi-lock-find-patterns to
> check this variable.  If the user explicitly gives the command, it
> should be obeyed.  I think that hi-lock-file-patterns-policy should be
> tested only when hi-lock-find-patterns is called in other ways (such
> as by find-file).

What you suggested is indeed the behavior of hi-lock-find-patterns.

  parent reply	other threads:[~2007-04-21 17:32 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-20 19:06 Changes to hi-lock before release David Koppelman
2007-04-20 19:29 ` Chong Yidong
2007-04-21  9:20   ` Eli Zaretskii
2007-04-21 10:12     ` Johan Bockgård
2007-04-21 18:25       ` Richard Stallman
2007-04-21 19:26         ` Chong Yidong
2007-04-22  3:13           ` Eli Zaretskii
     [not found] ` <E1HfGbN-0006PL-IH@fencepost.gnu.org>
2007-04-21 17:32   ` Chong Yidong [this message]
2007-04-22  0:46     ` Richard Stallman
2007-04-22  1:47       ` Glenn Morris
2007-04-23  3:48         ` Richard Stallman
2007-04-22  0:46     ` Richard Stallman
2007-04-22  2:45       ` Chong Yidong
2007-04-23  3:47         ` Richard Stallman
2007-04-23 14:39           ` Chong Yidong
2007-04-24 21:10 ` Alan Mackenzie
2007-04-24 21:34   ` David Koppelman
2007-04-25 11:53     ` Changes to hi-lock before release. PATCH Alan Mackenzie
2007-04-25 14:51     ` Changes to hi-lock before release Richard Stallman
2007-04-25 15:18       ` David Koppelman
2007-04-27  5:59         ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zm51ab0b.fsf@stupidchicken.com \
    --to=cyd@stupidchicken.com \
    --cc=emacs-devel@gnu.org \
    --cc=koppel@ece.lsu.edu \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).