unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Chong Yidong <cyd@stupidchicken.com>
To: emacs-devel@gnu.org
Cc: emacs-pretest-bug@gnu.org
Subject: Re: Contiguous redisplay of the menu and beeps
Date: Sun, 27 May 2007 22:32:28 -0400	[thread overview]
Message-ID: <87zm3pd6f7.fsf@stupidchicken.com> (raw)
In-Reply-To: wld50llq99.wl%mituharu@math.s.chiba-u.ac.jp

YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> writes:

> I meant the only direct call to `current_column' from
> redisplay_internal:
>
>   /* If %c is in the mode line, update it if needed.  */
>   if (!NILP (w->column_number_displayed)
>       /* This alternative quickly identifies a common case
> 	 where no change is needed.  */
>       && !(PT == XFASTINT (w->last_point)
> 	   && XFASTINT (w->last_modified) >= MODIFF
> 	   && XFASTINT (w->last_overlay_modified) >= OVERLAY_MODIFF)
>       && (XFASTINT (w->column_number_displayed)
>           != (int) current_column ()))  /* iftc */
>     w->update_mode_line = Qt;
>
> and as I said, binding Qinhibit_point_motion_hooks just around this
> part as the following patch also works for me on Mac OS X.
>
> Could someone check if this works on Windows for the original problem?

It fixes the bug as seen on GNU/Linux (i.e., with `debug-on-error' on,
I no longer see a `forward-list' error with original bug recipe; I
never observed the "other operations are blocked" part of the bug
report on this platform.)

Let's get this into the branch.

  reply	other threads:[~2007-05-28  2:32 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-27 23:21 Contiguous redisplay of the menu and beeps Richard Stallman
2007-05-28  0:56 ` YAMAMOTO Mitsuharu
2007-05-28  2:32   ` Chong Yidong [this message]
2007-05-28  3:11     ` YAMAMOTO Mitsuharu
2007-05-28  8:33       ` martin rudalics
2007-05-28  8:58         ` martin rudalics
2007-05-28  9:14           ` YAMAMOTO Mitsuharu
2007-05-28  9:42             ` martin rudalics
2007-05-28 10:09             ` martin rudalics
2007-05-28 12:49               ` Chong Yidong
2007-05-28 13:13                 ` martin rudalics
2007-05-28 14:11                   ` Chong Yidong
2007-05-29 23:38                 ` Davis Herring
2007-05-29  0:03     ` Richard Stallman
     [not found] <ulkfcxbvv.wl%miyoshi@meadowy.org>
     [not found] ` <465811AB.6080507@gmx.at>
2007-05-26 13:41   ` martin rudalics
2007-05-26 14:12     ` Stephen Berman
2007-05-26 14:22       ` Stephen Berman
2007-05-26 14:49         ` martin rudalics
2007-05-26 15:19           ` Stephen Berman
2007-05-26 16:12             ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zm3pd6f7.fsf@stupidchicken.com \
    --to=cyd@stupidchicken.com \
    --cc=emacs-devel@gnu.org \
    --cc=emacs-pretest-bug@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).