From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Hansen Newsgroups: gmane.emacs.devel Subject: Re: dbusbind.c patch, fixes possible segfault Date: Sun, 13 Apr 2008 18:58:32 +0200 Organization: disorganized Message-ID: <87zlrxk7yf.fsf@localhorst.mine.nu> References: <874pa5ltgh.fsf@localhorst.mine.nu> <871w59d7tq.fsf@gmx.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1208106519 18001 80.91.229.12 (13 Apr 2008 17:08:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 13 Apr 2008 17:08:39 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 13 19:09:07 2008 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Jl5hQ-0007Xh-U2 for ged-emacs-devel@m.gmane.org; Sun, 13 Apr 2008 19:09:05 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jl5gm-0004DS-SV for ged-emacs-devel@m.gmane.org; Sun, 13 Apr 2008 13:08:24 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jl5gi-0004BX-2h for emacs-devel@gnu.org; Sun, 13 Apr 2008 13:08:20 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jl5gh-0004Ar-F5 for emacs-devel@gnu.org; Sun, 13 Apr 2008 13:08:19 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jl5gh-0004Ah-A9 for emacs-devel@gnu.org; Sun, 13 Apr 2008 13:08:19 -0400 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Jl5gg-0007Al-Bc for emacs-devel@gnu.org; Sun, 13 Apr 2008 13:08:18 -0400 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1Jl5ge-0003Z1-0w for emacs-devel@gnu.org; Sun, 13 Apr 2008 17:08:16 +0000 Original-Received: from e178023022.adsl.alicedsl.de ([85.178.23.22]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 13 Apr 2008 17:08:16 +0000 Original-Received: from david.hansen by e178023022.adsl.alicedsl.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 13 Apr 2008 17:08:16 +0000 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 17 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: e178023022.adsl.alicedsl.de Mail-Copies-To: nobody User-Agent: Gnus/5.110009 (No Gnus v0.9) Emacs/23.0.60 (gnu/linux) Cancel-Lock: sha1:cjvMAtdYgrtSjCYqQ4eG5Kd4AeI= X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:95115 Archived-At: On Sun, 13 Apr 2008 18:43:13 +0200 Michael Albinus wrote: > David Hansen writes: > >> This one is similar to the previous dbusbind.c patch. No need to copy >> the string and if dbus_bus_get_unique_name () returns NULL strcpy will >> segfault. > > Looks OK, I've committed it. Thanks a lot! > > Btw, I'm a little bit curious how you've managed it NOT to have a unique > name? I haven't. I try to make myself familiar with the low level dbus api and the emacs code is a nice reading. David