From: Juri Linkov <juri@jurta.org>
To: martin rudalics <rudalics@gmx.at>
Cc: Chong Yidong <cyd@stupidchicken.com>, emacs-devel <emacs-devel@gnu.org>
Subject: Re: Finding the source of Change Log entries
Date: Mon, 14 Jul 2008 01:14:11 +0300 [thread overview]
Message-ID: <87zlolv3d8.fsf@jurta.org> (raw)
In-Reply-To: <4879BDF7.6060705@gmx.at> (martin rudalics's message of "Sun, 13 Jul 2008 10:33:59 +0200")
>> Please check it in, with the appropriate ChangeLog and NEWS
>> entries, plus the following fix:
>>
>> + (message "Not found `%s' in %s" tag file)
>>
>> should be something more grammatical, like
>>
>> + (message "Source location not found: `%s' in %s" tag file)
>>
>> Also, instead of binding change-log-find-tag to C-c C-t, how about using
>> C-c C-c for consistency with diff-mode? (You might also want to rename
>> change-log-find-tag to change-log-goto-source for consistency with
>> diff-goto-source, but that's your call.)
>
> Done. Please check again.
Thanks, this is great. One thing that doesn't work yet is visiting
a file that has no tag, i.e.
* filename.el: File-level changes.
Instead of visiting it, `C-c C-c' visits the previous file that has
a tag. Of course, `C-c C-f' is available to visit a file, but it is
not convenient to switch between different keys to do the same thing,
and also `C-c C-f' has a different behavior: it visits a file in the
same window unlike `C-c C-c'.
It seems the best thing to do would be searching backward for a tag and
a file name at the same. This may require joining two separate functions
that search a tag or a file name into one function.
--
Juri Linkov
http://www.jurta.org/emacs/
next prev parent reply other threads:[~2008-07-13 22:14 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-12 9:32 Finding the source of Change Log entries martin rudalics
2008-07-12 10:00 ` Lennart Borgman (gmail)
2008-07-12 10:32 ` martin rudalics
2008-07-12 14:52 ` Chong Yidong
2008-07-13 8:33 ` martin rudalics
2008-07-13 22:14 ` Juri Linkov [this message]
2008-07-14 8:40 ` martin rudalics
2008-07-14 21:57 ` Juri Linkov
2008-07-16 17:20 ` martin rudalics
2008-08-07 10:10 ` martin rudalics
2008-07-14 13:50 ` Ted Zlatanov
2008-07-14 21:54 ` Juri Linkov
2008-07-15 6:23 ` Andrew W. Nosenko
2008-07-15 9:48 ` Juri Linkov
2008-07-15 14:56 ` Ted Zlatanov
2008-07-15 20:35 ` Juri Linkov
2008-07-16 17:20 ` martin rudalics
2008-08-05 18:43 ` Ted Zlatanov
2008-08-25 15:43 ` Juri Linkov
2008-08-27 18:37 ` Ted Zlatanov
2008-08-27 20:43 ` Stefan Monnier
2008-08-27 20:57 ` Ted Zlatanov
2008-08-28 2:03 ` Stefan Monnier
2008-09-10 23:59 ` Juri Linkov
2008-09-14 11:27 ` martin rudalics
2008-07-14 14:00 ` Dan Nicolaescu
2008-07-16 17:18 ` martin rudalics
2008-07-27 21:47 ` Dan Nicolaescu
2008-07-28 18:50 ` martin rudalics
2008-07-28 21:53 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zlolv3d8.fsf@jurta.org \
--to=juri@jurta.org \
--cc=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).