unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Manoj Srivastava <srivasta@ieee.org>
To: emacs-devel@gnu.org
Subject: Re: Recent CVS Emacs breaks color-themes
Date: Fri, 03 Oct 2008 23:58:55 -0500	[thread overview]
Message-ID: <87zlllyn00.fsf@anzu.internal.golden-gryphon.com> (raw)
In-Reply-To: E1Klx8g-0006dS-Iv@etlken.m17n.org

On Fri, Oct 03 2008, Kenichi Handa wrote:

> In article <48E64E88.4040305@gmx.at>, martin rudalics <rudalics@gmx.at> writes:
>
>> (font_matching_entity): Reflect ATTRS in font selection.
>> (font_find_for_lface) [HAVE_NS]: Don't ignore case.
>
>> There's something strange with that change.  The lines
>
>>      ASET (spec, FONT_TYPE_INDEX, ftype);
>>      ASET (spec, FONT_SIZE_INDEX, size);
>
>> before line 2802
>
>>    font_add_log ("match", work, entity);
>
>> disappeared.  I don't have the slightest idea whether that's of
>> any importance.  Moreover, "spec" should probably become "work"
>> here.  Handa-san?
>
> That disappearance is because of Adrian's change just a few
> font_matching_entity now uses "work" and don't modify
> "spec", the above two lines are not necessary.
>
> And, the code I checked in had a problem of not setting font
> size of "work", but that is already fixed by Adrian too.
>
> By the way, Adrian, please add ChangeLog entry for them:
> (Just saying "Fix previous change" is ok).
>
> So, I don't know what is wrong with the current code, and I
> can't reproduce your problem even with this setting of
> yours:
> *FontBackend: xft,x
> Emacs.FontBackend:    xft,x
> emacs.font: DejaVu Sans Mono-9

        I have those settings in my X resources file for emacs wrt
 fonts.  I start emacs on Debian with
 %  emacs -Q
 I have 
   /usr/local/share/emacs/site-lisp/emacs-snapshot/emacs-goodies-el/color-theme.elc
 The key strokes to see the issue are:
--8<---------------cut here---------------start------------->8---
C-x b <return> <escape> x l o a d - l i b r a r y <return>
c o l o r - t h e m e <return> <escape> x c o l o r
- t h e m e - d e e p - b l u e <return> <help-echo>
<escape> x v i e w - l o s s a g e <return>
--8<---------------cut here---------------end--------------->8---

        The first C-x b <return> puts me in the *scratch*
 buffer. Everything in the buffer is readable at that point. I load the
 color-theme package, and load the deep blue color theme, and now every
 character in the buffer is replaced by an square box.

        This happens every single time here. I can provide the
 color-theme.elc file (also found in the Debian package emacs-goodies)
 to help in debugging.   I tried attaching the color-theme.el file, but
 the mail bounced (I suspect due to size)/

        Please send me mail off-list if you want me to send you a copy
 of color-theme.el.

        manoj
-- 
Death tugs at my ear and says: "Live, I am coming." Oliver Wendell
Holmes, Sr.
Manoj Srivastava <srivasta@acm.org> <http://www.golden-gryphon.com/>  
1024D/BF24424C print 4966 F272 D093 B493 410B  924B 21BA DABB BF24 424C





  reply	other threads:[~2008-10-04  4:58 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-03  5:44 Recent CVS Emacs breaks color-themes Manoj Srivastava
2008-10-03 12:51 ` Stefan Monnier
2008-10-03 13:46 ` martin rudalics
2008-10-03 15:36   ` Manoj Srivastava
2008-10-03 16:55     ` martin rudalics
2008-10-04  2:45       ` Kenichi Handa
2008-10-04  4:58         ` Manoj Srivastava [this message]
2008-10-06  2:22           ` Kenichi Handa
2008-10-06  3:13             ` Manoj Srivastava
2008-10-06  4:01               ` Kenichi Handa
2008-10-06  5:23                 ` Manoj Srivastava
2008-10-08 12:22                   ` Kenichi Handa
2008-10-08 16:31                     ` Miles Bader
2008-10-09  4:31                     ` Manoj Srivastava
2008-10-09  5:16                       ` Kenichi Handa
2008-10-09 12:22                         ` Kenichi Handa
2008-10-10  8:43                           ` Manoj Srivastava
2008-10-06  7:01                 ` Manoj Srivastava
2008-10-06  7:28             ` Manoj Srivastava

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zlllyn00.fsf@anzu.internal.golden-gryphon.com \
    --to=srivasta@ieee.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).