emacs fails to build -- XRenderQueryExtension undefined

emacs fails to build -- XRenderQueryExtension undefined

[Miles Bader]

I worked around it with the following patch, though it's probably not
exactly the right fix...

-Miles

diff --git a/configure.in b/configure.in
index c36c6b2..0b53c77 100644
--- a/configure.in
+++ b/configure.in
@@ -1990,6 +1990,7 @@ if test "${HAVE_X11}" = "yes"; then
 	OLD_LIBS="$LIBS"
 	CPPFLAGS="$CPPFLAGS $XFT_CFLAGS"
 	CFLAGS="$CFLAGS $XFT_CFLAGS"
+	XFT_LIBS="$XFT_LIBS -lXrender"
 	LIBS="$XFT_LIBS $LIBS"
 	AC_CHECK_HEADER(X11/Xft/Xft.h,
 	  AC_CHECK_LIB(Xft, XftFontOpen, HAVE_XFT=yes, , $XFT_LIBS))


-- 
Consult, v.i. To seek another's disapproval of a course already decided on.

Re: emacs fails to build -- XRenderQueryExtension undefined

[Jan Djärv]

Miles Bader skrev:
> I worked around it with the following patch, though it's probably not
> exactly the right fix...

What system are you on?  How did you configure Emacs?
If Xft requires Xrender at link time it should say so in the pkg-config 
output.  Normally on GNU/Linux, -Xrender is a private dependency, meaning it 
is needed to compile Xft, but linking is done implicitly by the rune time 
linker (do ldd /usr/lib/libXft.so and you can see that there is a dependecy 
there already).

	Jan D.

> 
> -Miles
> 
> diff --git a/configure.in b/configure.in
> index c36c6b2..0b53c77 100644
> --- a/configure.in
> +++ b/configure.in
> @@ -1990,6 +1990,7 @@ if test "${HAVE_X11}" = "yes"; then
>  	OLD_LIBS="$LIBS"
>  	CPPFLAGS="$CPPFLAGS $XFT_CFLAGS"
>  	CFLAGS="$CFLAGS $XFT_CFLAGS"
> +	XFT_LIBS="$XFT_LIBS -lXrender"
>  	LIBS="$XFT_LIBS $LIBS"
>  	AC_CHECK_HEADER(X11/Xft/Xft.h,
>  	  AC_CHECK_LIB(Xft, XftFontOpen, HAVE_XFT=yes, , $XFT_LIBS))
> 
> 

Re: emacs fails to build -- XRenderQueryExtension undefined

[Miles Bader]

Jan Djärv <jan.h.d@swipnet.se> writes:
>> I worked around it with the following patch, though it's probably not
>> exactly the right fix...
>
> What system are you on?  How did you configure Emacs?
> If Xft requires Xrender at link time it should say so in the pkg-config
> output.  Normally on GNU/Linux, -Xrender is a private dependency,

It only says so in the pkg-config output if you specify --static
(otherwise, I think that since it's a "private" dependency of libxft.so,
it uses libxft.so's dependencies to load the library at runtime, but the
linker won't see it):

   $ pkg-config --libs xft
   -lXft  
   $ pkg-config --libs --static xft
   -lXft -lXrender -lfontconfig -lexpat -lfreetype -lz -lX11 -lpthread -lxcb -lXau -lXdmcp  

The problem, as far as I can tell, seems to be that there's an explicit
reference to XRenderQueryExtension in src/xftfont.c (src/xftfont.c:365),
so Emacs itself needs to link against -lXrender, it can't rely on the
the fact that libxft uses it.

I dunno if there's some system change that exposed this issue recently;
the relevant Emacs change seems to be a bit old -- vc annotate says:

f602b732 src/xftfont.c (YAMAMOTO Mitsuharu 2009-05-11 09:29:49 +0000 365)     XRenderQueryExtension (display, &event_base, &error_base);

[Note, I don't know the details of how this stuff works really, but I
think the above is roughly correct.]

-Miles

-- 
Monday, n. In Christian countries, the day after the baseball game.

Re: emacs fails to build -- XRenderQueryExtension undefined

[Miles Bader]

p.s. system is debian (unstable), no special flags to configure
(though I use a separate build-dir).

-Miles

-- 
Do not taunt Happy Fun Ball.

Re: emacs fails to build -- XRenderQueryExtension undefined

[Jan Djärv]

Miles Bader skrev:
> Jan Djärv <jan.h.d@swipnet.se> writes:
>>> I worked around it with the following patch, though it's probably not
>>> exactly the right fix...
>> What system are you on?  How did you configure Emacs?
>> If Xft requires Xrender at link time it should say so in the pkg-config
>> output.  Normally on GNU/Linux, -Xrender is a private dependency,
> 
> It only says so in the pkg-config output if you specify --static
> (otherwise, I think that since it's a "private" dependency of libxft.so,
> it uses libxft.so's dependencies to load the library at runtime, but the
> linker won't see it):
> 
>    $ pkg-config --libs xft
>    -lXft  
>    $ pkg-config --libs --static xft
>    -lXft -lXrender -lfontconfig -lexpat -lfreetype -lz -lX11 -lpthread -lxcb -lXau -lXdmcp  
> 
> The problem, as far as I can tell, seems to be that there's an explicit
> reference to XRenderQueryExtension in src/xftfont.c (src/xftfont.c:365),
> so Emacs itself needs to link against -lXrender, it can't rely on the
> the fact that libxft uses it.

Ah, I didn't see that.

> 
> I dunno if there's some system change that exposed this issue recently;
> the relevant Emacs change seems to be a bit old -- vc annotate says:
> 
> f602b732 src/xftfont.c (YAMAMOTO Mitsuharu 2009-05-11 09:29:49 +0000 365)     XRenderQueryExtension (display, &event_base, &error_base);
> 
> [Note, I don't know the details of how this stuff works really, but I
> think the above is roughly correct.]
> 

Strange that it worked earlier then.  It can't hurt to add -lXrender.  To be 
on the safe side, AC_CHECK_LIB for Xrender should be made before adding 
-lXrender to libs.

	Jan D.

Re: emacs fails to build -- XRenderQueryExtension undefined

[YAMAMOTO Mitsuharu]

>>>>> On Tue, 12 Jan 2010 16:54:21 +0900, Miles Bader <miles@gnu.org> said:

>> What system are you on?  How did you configure Emacs?
>> If Xft requires Xrender at link time it should say so in the pkg-config
>> output.  Normally on GNU/Linux, -Xrender is a private dependency,

> It only says so in the pkg-config output if you specify --static
> (otherwise, I think that since it's a "private" dependency of libxft.so,
> it uses libxft.so's dependencies to load the library at runtime, but the
> linker won't see it):

>    $ pkg-config --libs xft
>    -lXft  
>    $ pkg-config --libs --static xft
>    -lXft -lXrender -lfontconfig -lexpat -lfreetype -lz -lX11 -lpthread -lxcb -lXau -lXdmcp  

The results on Ubuntu 9.10 are similar, and there is no -lXrender in
src/Makefile in my build dir.  But the linker does not complain, and
ldd shows libXrender.so.1 for me.

$ ldd /usr/lib/libXft.so
	linux-gate.so.1 =>  (0x00320000)
	libfontconfig.so.1 => /usr/lib/libfontconfig.so.1 (0x0076b000)
	libfreetype.so.6 => /usr/lib/libfreetype.so.6 (0x00d5c000)
	libz.so.1 => /lib/libz.so.1 (0x00cc9000)
	libXrender.so.1 => /usr/lib/libXrender.so.1 (0x00a82000)
	libX11.so.6 => /usr/lib/libX11.so.6 (0x00124000)
	libc.so.6 => /lib/tls/i686/cmov/libc.so.6 (0x008aa000)
	libexpat.so.1 => /lib/libexpat.so.1 (0x0033f000)
	libxcb.so.1 => /usr/lib/libxcb.so.1 (0x00253000)
	libdl.so.2 => /lib/tls/i686/cmov/libdl.so.2 (0x00fc2000)
	/lib/ld-linux.so.2 (0x00ee7000)
	libpthread.so.0 => /lib/tls/i686/cmov/libpthread.so.0 (0x003da000)
	libXau.so.6 => /usr/lib/libXau.so.6 (0x00ead000)
	libXdmcp.so.6 => /usr/lib/libXdmcp.so.6 (0x00af5000)

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

Re: emacs fails to build -- XRenderQueryExtension undefined

[Miles Bader]

YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> writes:
> The results on Ubuntu 9.10 are similar, and there is no -lXrender in
> src/Makefile in my build dir.  But the linker does not complain, and

It may be that I have a newer version of some tool or something --
e.g. it occurs to me that I'm currently using binutils' new "gold"
linker.

Anyway, it seems pretty clear that the right thing to do is for Emacs to
explicitly link against libraries which it explicitly uses.

-Miles

-- 
Somebody has to do something, and it's just incredibly pathetic that it
has to be us.  -- Jerry Garcia

Re: emacs fails to build -- XRenderQueryExtension undefined

[Sven Joachim]

On 2010-01-12 10:44 +0100, Miles Bader wrote:

> YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> writes:
>> The results on Ubuntu 9.10 are similar, and there is no -lXrender in
>> src/Makefile in my build dir.  But the linker does not complain, and
>
> It may be that I have a newer version of some tool or something --
> e.g. it occurs to me that I'm currently using binutils' new "gold"
> linker.

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=554324

Sven

Re: emacs fails to build -- XRenderQueryExtension undefined

[Chong Yidong]

Jan Djärv <jan.h.d@swipnet.se> writes:

>> I dunno if there's some system change that exposed this issue recently;
>> the relevant Emacs change seems to be a bit old -- vc annotate says:
>>
>> f602b732 src/xftfont.c (YAMAMOTO Mitsuharu 2009-05-11 09:29:49 +0000 365)     XRenderQueryExtension (display, &event_base, &error_base);
>>
>> [Note, I don't know the details of how this stuff works really, but I
>> think the above is roughly correct.]
>>
>
> Strange that it worked earlier then.  It can't hurt to add -lXrender.
> To be on the safe side, AC_CHECK_LIB for Xrender should be made before
> adding -lXrender to libs.

I've checked such a fix into the repository.