From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Claudio Bley Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 2/5] w32: add support for recent PNG library version >= 1.5 Date: Wed, 30 Oct 2013 13:50:57 +0100 Message-ID: <87zjpqylam.wl%claudio.bley@gmail.com> References: <87y55he51l.wl%claudio.bley@gmail.com> <83hac2fzkl.fsf@gnu.org> <87iowgv54e.wl%claudio.bley@gmail.com> <83wqkwdnrn.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Trace: ger.gmane.org 1383137473 19959 80.91.229.3 (30 Oct 2013 12:51:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 30 Oct 2013 12:51:13 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 30 13:51:18 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VbVEz-0001qD-Sh for ged-emacs-devel@m.gmane.org; Wed, 30 Oct 2013 13:51:17 +0100 Original-Received: from localhost ([::1]:52235 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbVEz-0002Su-Gt for ged-emacs-devel@m.gmane.org; Wed, 30 Oct 2013 08:51:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59827) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbVEs-0002Sl-7M for emacs-devel@gnu.org; Wed, 30 Oct 2013 08:51:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VbVEn-0006Am-Fn for emacs-devel@gnu.org; Wed, 30 Oct 2013 08:51:10 -0400 Original-Received: from mail-ee0-x233.google.com ([2a00:1450:4013:c00::233]:63728) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbVEi-00069v-6L; Wed, 30 Oct 2013 08:51:00 -0400 Original-Received: by mail-ee0-f51.google.com with SMTP id d41so620769eek.10 for ; Wed, 30 Oct 2013 05:50:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=date:message-id:from:to:cc:subject:in-reply-to:references :user-agent:mime-version:content-type; bh=zAyLj8LZF5NjdCg83vqVtkydmdWLXEmxF9rFQUskqgU=; b=ftLf2rw1LvPsdxPVhTWWoZ99/5gPBymZDO97ghtO8vK6vXJSMsMJNrN+K37O+z9S97 zAfWYsKLszn5zXHdbMhwQ3H0cdffTYcJwonulLyxTSuYlrRVhCdkYDT579rH0Ih/jl9A lHFHSU7nLJmaecooRIbshcxmlG3z9DSi4dt7VFCfgH/91OE7z1SqSmhPkzJW8Jo6vpPv QzWny/j9rKP4oCEEooCCrLWJR0zO5YnVFvSj0XZ5TfgyuN0AGsXCjYlCdpxfkXfOyx8l gLnXfBwtV/yiPHv4aLOLUTGmilD8k4TA1p8EPv8x04DgxKg220BzjLMkRS4efIvwFpq4 2vQg== X-Received: by 10.15.61.137 with SMTP id i9mr4968746eex.50.1383137458850; Wed, 30 Oct 2013 05:50:58 -0700 (PDT) Original-Received: from CLAUDIO-PC.localdomain.de (178-24-125-95-dynip.superkabel.de. [178.24.125.95]) by mx.google.com with ESMTPSA id a1sm83179771eem.1.2013.10.30.05.50.57 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Oct 2013 05:50:58 -0700 (PDT) In-Reply-To: <83wqkwdnrn.fsf@gnu.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3.50 (i686-pc-mingw32) MULE/6.0 (HANACHIRUSATO) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c00::233 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:164699 Archived-At: At Tue, 29 Oct 2013 18:50:52 +0200, Eli Zaretskii wrote: > > > Date: Tue, 29 Oct 2013 09:44:01 +0100 > > From: Claudio Bley > > Cc: emacs-devel@gnu.org > > > > At Sun, 27 Oct 2013 18:28:26 +0200, > > Eli Zaretskii wrote: > > > > > > Here, too, latest libpng versions are incompatible with 1.4.x, so we > > > do need to make such a change. > > > > > > However, when one builds libpng-X.Y.Z on Windows, the DLL that is > > > installed is called libpngXY-XY.dll, not just libpngXY.dll, as your > > > patch assumes. > > > > I'm building with CMake and that's what the CMake builds produce. > > Worth writing to the maintainers about, IMO, since CMake is not the > standard build method (AFAIK). On w32 it is probably more standard than building with autotools, IMO. It also begs the question what the most reasonable name would be, ie. what's the point of duplicating the version after a dash? Seems it's only because of libtool, which is probably not really relevant on w32 anyway. > > If you download the release tarball (lpng166.7z) for win32, the DLL > > produced is also called libpng16.dll. > > If you build with CMake or if you build with the usual "configure && make"? Neither, they support building with different compilers by copying a Makefile from the "scripts" subdir to the project root dir. The w32 "tarballs" don't even have a configure script.