From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Vitalie Spinu Newsgroups: gmane.emacs.devel Subject: Re: [Patch] hard-widen-limits [was Re: Syntax tables for multiple modes [was: bug#22983: syntax-ppss returns wrong result.]] Date: Sun, 24 Apr 2016 18:41:11 +0200 Message-ID: <87zisjc63c.fsf@gmail.com> References: <20160311151512.GD2888@acm.fritz.box> <87lh5bd4ib.fsf@gmail.com> <87egb3ryjc.fsf@gmail.com> <877fgusum3.fsf@gmail.com> <8737risu8d.fsf@gmail.com> <87mvpqqxy7.fsf@gmail.com> <877fguqp8x.fsf@gmail.com> <87bn65pgk2.fsf@gmail.com> <87y499nz79.fsf@gmail.com> <87zithez9b.fsf@gmail.com> <940ff677-80dc-848b-5626-23c7ac1591df@yandex.ru> <87k2jneaio.fsf@gmail.com> <87mvoj4gai.fsf@Rainer.invalid> <87a8kjdyvx.fsf@gmail.com> <87lh43dty8.fsf@linux-m68k.org> <874mardm1u.fsf@gmail.com> <87h9erdlnt.fsf@linux-m68k.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1461516110 23666 80.91.229.3 (24 Apr 2016 16:41:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 24 Apr 2016 16:41:50 +0000 (UTC) Cc: Achim Gratz , emacs-devel@gnu.org To: Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 24 18:41:45 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1auN6O-00073s-E2 for ged-emacs-devel@m.gmane.org; Sun, 24 Apr 2016 18:41:44 +0200 Original-Received: from localhost ([::1]:55939 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auN6N-0002ZD-RA for ged-emacs-devel@m.gmane.org; Sun, 24 Apr 2016 12:41:43 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36659) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auN68-0002WY-PW for emacs-devel@gnu.org; Sun, 24 Apr 2016 12:41:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1auN65-0007xd-JO for emacs-devel@gnu.org; Sun, 24 Apr 2016 12:41:28 -0400 Original-Received: from mail-wm0-x22b.google.com ([2a00:1450:400c:c09::22b]:35906) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auN65-0007xX-BV for emacs-devel@gnu.org; Sun, 24 Apr 2016 12:41:25 -0400 Original-Received: by mail-wm0-x22b.google.com with SMTP id v188so72661118wme.1 for ; Sun, 24 Apr 2016 09:41:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=BXNvBKKmb9VBcughF51wYXRNTOv6xqn7C0oCCujVkS4=; b=D6Z7xTDK17oFmX5ayMeYN3PhKQVWQ/cz0bOsiv1Rl/0SiIShFGbJwA4ecOepyFNKuo paEI2UIG5ZR+hbAJfUD50C5XCwGmRw1VIT1kTVnp/hn1jqdWz/ll/NaT+vfsuf7b5cEI SpSjJ1KUXmz8/XTBv2cIW3ch7FivXno/mG8j0kFCC3opi1tPN+ed9VvKNGoO/PS4BKwv 2ZRotKNXZYJ7FTgh584TrE+kyfT8L35fxBAohvq0RDxDn8en5J3Zlr6I9EB0b3rOPnSx eVTkg5pTnQckZ4O9KRmhDK5NmA3ZfelfH8dJN/6z1k+9UbV+YZpvwRhuvTaaKvNbUUh7 MWHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=BXNvBKKmb9VBcughF51wYXRNTOv6xqn7C0oCCujVkS4=; b=kk0oFhqCCP3j1moRQz/LmNzgyA5SHxFnQA/82fhCDCWhWvPhn4wS6/CPsGLmlMJAQm FnmNPEFphf81bsgrzOQxjPs2BeogWwoEbzm8UAaiNwdqu2H4uls+LHjNytGiZbhETKq5 pmwZSH16pLXsXPR8rq1Hce8TX8vBpleropl7gwEKPGxthsT5A319/ktWePVOzBY8nvQc vfRMVsMit1cUuRdP+ZGVenivdRyXM2v4ZTaevI9o/4P7oAKFZIa8mcwJWspQ7YspYmEm 1MHFKVklYLavKyxdCyFiksY2IorY+0ahAbor4AzxtrSRzyZgWCWhyJfN9aN8Y0GtqrQM o4ug== X-Gm-Message-State: AOPr4FUF/KvJG9PlQ6cjgbpKdPU+atAm0UnPwnG1ykvpNyOb/NGnaJA9eueLjd7m94q0Qg== X-Received: by 10.194.3.105 with SMTP id b9mr32158607wjb.140.1461516084484; Sun, 24 Apr 2016 09:41:24 -0700 (PDT) Original-Received: from localhost ([143.176.214.220]) by smtp.gmail.com with ESMTPSA id v64sm14467277wmv.1.2016.04.24.09.41.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 24 Apr 2016 09:41:23 -0700 (PDT) In-Reply-To: <87h9erdlnt.fsf@linux-m68k.org> (Andreas Schwab's message of "Sun, 24 Apr 2016 18:19:34 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.92 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::22b X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:203264 Archived-At: >> On Sun, Apr 24 2016 18:19, Andreas Schwab wrote: > Vitalie Spinu writes: >>>> On Sun, Apr 24 2016 15:20, Andreas Schwab wrote: >> >>> Vitalie Spinu writes: >> >>>> @@ -1692,7 +1692,7 @@ exec_byte_code (Lisp_Object bytestr, Lisp_Object vector, Lisp_Object maxdepth, >>>> >>>> CASE (Bwiden): >>>> BEFORE_POTENTIAL_GC (); >>>> - PUSH (Fwiden ()); >>>> + TOP = Fwiden (TOP); >> >>> You are clobbering the stack here. Instead of pushing a new value you >>> are overwriting an unrelated value on the stack. >> >> I don't think so. I pick an argument form the stack and put the return value in >> it. This is what all one-arg functions do in bytecode.c. > But nobody is pushing that argument. I am not pushing anything. I am just overriding. PUSH in above diff is a deleted line. Vitalie