From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.devel Subject: Re: replacing ldefs-boot.el Date: Sat, 26 Nov 2016 12:19:05 +0000 Message-ID: <87zikmbfie.fsf@russet.org.uk> References: <87bmxa6o37.fsf@russet.org.uk> <83y40e7y65.fsf@gnu.org> <87twb16dta.fsf@russet.org.uk> <83vavh8qci.fsf@gnu.org> <87a8csij8c.fsf@russet.org.uk> <87eg1zmdd7.fsf@russet.org.uk> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1480281615 2216 195.159.176.226 (27 Nov 2016 21:20:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 27 Nov 2016 21:20:15 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cc: Eli Zaretskii , Emacs developers To: Noam Postavsky Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 27 22:20:02 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB6rh-00076x-KK for ged-emacs-devel@m.gmane.org; Sun, 27 Nov 2016 22:20:01 +0100 Original-Received: from localhost ([::1]:55647 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cB6rl-0000NE-82 for ged-emacs-devel@m.gmane.org; Sun, 27 Nov 2016 16:20:05 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44265) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cB6qv-0000My-HP for emacs-devel@gnu.org; Sun, 27 Nov 2016 16:19:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cB6qs-00010L-CJ for emacs-devel@gnu.org; Sun, 27 Nov 2016 16:19:13 -0500 Original-Received: from [185.116.214.109] (port=56997 helo=mailgw.mycpanelcloud.co.uk) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cB6qr-00010A-W1 for emacs-devel@gnu.org; Sun, 27 Nov 2016 16:19:10 -0500 Original-Received: from mailgw.mycpanelcloud.co.uk (localhost [127.0.0.1]) by mailgw.mycpanelcloud.co.uk (Postfix) with ESMTP id 36C29FEBDB; Sun, 27 Nov 2016 21:11:34 +0000 (GMT) X-Virus-Scanned: by SpamTitan at mycpanelcloud.co.uk Original-Received: from mailgw.mycpanelcloud.co.uk (localhost [127.0.0.1]) by mailgw.mycpanelcloud.co.uk (Postfix) with ESMTP id F0ADEFEC83; Sun, 27 Nov 2016 21:11:29 +0000 (GMT) Original-Received: from cloud103.planethippo.com (cloud103.planethippo.com [31.216.48.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mailgw.mycpanelcloud.co.uk (Postfix) with ESMTPS id DCA2FFEC7A; Sun, 27 Nov 2016 21:11:29 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=russet.org.uk; s=default; h=Content-Type:MIME-Version:References:Message-ID :Date:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=g6QRFAq3RxqdJbPH9GvJx8GpcFLq/4n75+W/T+Dhzhc=; b=HeiaZMYqBB/oYmT3VVtOCUTtX jDezgTDWv+ufQsC9HNAMeCYp0mwECG4/sk2Z4Hf8ltzg6OgvmqlpREHBO0EFugFOjTa7A3T/3xzoS vB/6PCsB/qeAaDOKnVH8Vpr6v7LnqwKYMp0hyIM/0bixNw317VKtqG1qEYEbCTsRx0xKZDyih+3LY LeIRVkf4NrsEfqgSu+xPXyIntbtWgJwGaZwTdt4eZB1tsYKehcUpc15ki1XpDt3sMyYUoDMjEhdCt tUQ4sgK1WtiJAMhd+T0OFdfqLuLOLnLSCejglJtYpcQ9WMWh7hyUaGq+HDnom8Y0kpJMsN9vr0Dgn +ikPquxhg==; Original-Received: from cpc2-benw10-2-0-cust42.gate.cable.virginm.net ([77.103.60.43]:35186 helo=russet.org.uk) by cloud103.planethippo.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.87) (envelope-from ) id 1cB6jR-000bmG-FI; Sun, 27 Nov 2016 21:11:29 +0000 In-Reply-To: (Noam Postavsky's message of "Sat, 26 Nov 2016 00:34:34 -0500") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud103.planethippo.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - russet.org.uk X-Get-Message-Sender-Via: cloud103.planethippo.com: authenticated_id: phillip.lord@russet.org.uk X-Authenticated-Sender: cloud103.planethippo.com: phillip.lord@russet.org.uk X-detected-operating-system: by eggs.gnu.org: FreeBSD 8.x [fuzzy] X-Received-From: 185.116.214.109 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:209638 Archived-At: Noam Postavsky writes: >> I have no idea what percentage of those commits are actually necessary >> -- the unfortunate reality is that you can only test this with a full >> bootstrap build which is something that most developers do rarely. > > My guess is that with the smaller ldefs-boot-auto it will be necessary > more often. But maybe not enough to matter, hard to say. Actually, it should be *necessary* exactly as often as now. We need a certain number of autoloads to bootstrap. Both ldefs-boot-auto and ldefs-boot provide these. But ldefs-boot provides many more as well. The differnce is that when regenerating ldefs-boot-auto.el, we (should) only get changes that really are necessary. >>> I notice several almost duplicated lines in ldefs-boot-auto.el, like >>> >>> (autoload 'byte-compile "bytecomp" nil nil nil) >>> (autoload 'byte-compile "bytecomp" nil nil t) >>> >>> byte-compile isn't a macro; I think you should put your addition to >>> Fautoload_do_load after the "if (EQ (macro_only, Qmacro))" check to >>> avoid falsely identifying macros. >> >> Yeah, that's a screw up, thanks for picking this up. >> >> I don't understand the semantics of the macro_only parameter, at all, >> nor what that if statement is doing, but I'll try this fix. > > I think the value of FUNDEF tells you whether it's a macro, the > macro_only parameter just says to do nothing for non-macros. I changed my condition to this: Lisp_Object kind = Fnth (make_number (4), fundef); if (! (EQ (kind, Qt) || EQ (kind, Qmacro))) { fprintf(stderr, "nil"); } else { fprintf(stderr, "t"); } which seems to work. >> >>> And doesn't this change in Makefile.in break parallel 'make bootstrap' >>> invocations? >>> >>> -bootstrap: bootstrap-clean >>> +bootstrap: bootstrap-clean bootstrap-build >>> + >>> +bootstrap-build: >> >> Does it? bootstrap-clean and bootstrap-build cannot be run in parallel >> anyway. > > Right. And I think the definitions you put would let make run them in > parallel, thus breaking things. bootstrap: | bootstrap-clean bootstrap-build ? Phil