From: Andrew Cohen <cohen@bu.edu>
To: emacs-devel@gnu.org
Cc: ding@gnus.org
Subject: Re: [RFC] Gnus generalized search, part II
Date: Wed, 26 Apr 2017 16:18:04 +0800 [thread overview]
Message-ID: <87zif3fupv.fsf@hanan> (raw)
In-Reply-To: 87shkx5z17.fsf@ericabrahamsen.net
I found a few minutes to try the generalized search but couldn't get the
file to load :( I suspect just some simple typos, but I haven't had the
time to track them down (and they all seem to be in search backends that
aren't functional anyway).
I made some a (random) guess about what changes to make and got things
to load, but I haven't tried running any functions yet:)
Eric, did I make the right changes?
--- nnir_search.el~ 2017-04-22 17:03:10.509173535 +0800
+++ nnir_search.el 2017-04-26 16:13:25.806384881 +0800
@@ -1064,7 +1064,7 @@
(eieio-oset-default 'gnus-search-swish-e 'prefix
nnir-swish-e-remove-prefix)
-(eieio-oset-default 'gnus-search-swish-e 'config-file
+(eieio-oset-default 'gnus-search-swish-e 'index-files
nnir-swish-e-index-files)
(eieio-oset-default 'gnus-search-swish-e 'switches
@@ -1499,7 +1499,7 @@
-(cl-defmethod nnir-search-transform-expression ((engine gnus-engine-swish++)
+(cl-defmethod nnir-search-transform-expression ((engine gnus-search-swish++)
(expr (head near)))
(format "%s near %s"
(nnir-search-transform-expression engine (nth 1 expr))
@@ -1946,20 +1946,20 @@
(forward-line 1)))
(apply #'vector (nreverse (delete-dups artlist)))))
-(cl-defmethod nnir-search-transform-expression ((_e gnus-engine-gmane)
+(cl-defmethod nnir-search-transform-expression ((_e gnus-search-gmane)
(_expr (head near)))
nil)
;; Can Gmane handle OR or NOT keywords?
-(cl-defmethod nnir-search-transform-expression ((_e gnus-engine-gmane)
+(cl-defmethod nnir-search-transform-expression ((_e gnus-search-gmane)
(_expr (head or)))
nil)
-(cl-defmethod nnir-search-transform-expression ((_e gnus-engine-gmane)
+(cl-defmethod nnir-search-transform-expression ((_e gnus-search-gmane)
(_expr (head not)))
nil)
-(cl-defmethod nnir-search-transform-expression ((_e gnus-engine-gmane)
+(cl-defmethod nnir-search-transform-expression ((_e gnus-search-gmane)
(expr list))
"The only keyword value gmane can handle is author, ie from."
(when (memq (car expr) '(from sender author))
next prev parent reply other threads:[~2017-04-26 8:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 21:35 [RFC] Gnus generalized search, part II Eric Abrahamsen
2017-04-22 0:16 ` Andrew Cohen
2017-04-22 5:27 ` Eric Abrahamsen
2017-04-22 8:08 ` Eli Zaretskii
2017-04-22 15:08 ` Eric Abrahamsen
2017-04-22 15:17 ` Eli Zaretskii
2017-04-22 15:25 ` Eli Zaretskii
2017-04-22 19:25 ` Eric Abrahamsen
2017-04-22 20:06 ` Eli Zaretskii
2017-04-22 22:50 ` Eric Abrahamsen
2017-04-30 17:46 ` Eric Abrahamsen
2017-04-24 17:17 ` Stephen Leake
2017-04-26 9:42 ` Eli Zaretskii
2017-04-22 16:00 ` Noam Postavsky
2017-04-22 7:50 ` Eli Zaretskii
2017-04-22 8:00 ` Andrew Cohen
2017-04-22 19:53 ` Lars Ingebrigtsen
2017-04-22 20:26 ` Eric Abrahamsen
2017-04-24 20:30 ` Eric Abrahamsen
2017-04-26 4:41 ` Andrew Cohen
2017-04-26 9:21 ` Joakim Jalap
2017-04-26 8:18 ` Andrew Cohen [this message]
2017-04-26 8:22 ` Andrew Cohen
2017-04-23 13:48 ` Dan Christensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zif3fupv.fsf@hanan \
--to=cohen@bu.edu \
--cc=ding@gnus.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).