From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?utf-8?Q?Johan_Bockg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: Trimming strings, /emacs/lisp/emacs-lisp/subr-x.el modification Date: Sun, 07 May 2017 18:23:56 +0200 Message-ID: <87zieo4ov7.fsf@gnu.org> References: <87vapij1l7.fsf@holos> <6870A2B6-F685-4955-9C0A-256601DB47BC@gmail.com> <51D5E92C-F125-4ADE-8C55-E3513C00ECDC@gmail.com> <8F6958D6-3E13-4C31-B1F8-AF10A8FC8FC6@gmail.com> <838tmafigi.fsf@gnu.org> <7C79DA34-96F2-4D9F-9E9C-01574AE00F12@gmail.com> <8360hefepp.fsf@gnu.org> <0E129E02-FA64-4664-825B-8854A66CA9C6@gmail.com> <3D0BA0E6-02E2-4E90-8A59-121065547E1C@gmail.com> <87ziepho0q.fsf@gnu.org> <83vapderm3.fsf@gnu.org> <87vapdhi9j.fsf@gnu.org> <83tw4xeorf.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1494174260 28515 195.159.176.226 (7 May 2017 16:24:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 7 May 2017 16:24:20 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) Cc: mvoteiza@udel.edu, jean.christophe.helary@gmail.com, tino.calancha@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun May 07 18:24:15 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d7Oyk-0007CP-QZ for ged-emacs-devel@m.gmane.org; Sun, 07 May 2017 18:24:15 +0200 Original-Received: from localhost ([::1]:56134 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d7Oyl-00032r-N6 for ged-emacs-devel@m.gmane.org; Sun, 07 May 2017 12:24:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38191) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d7Oyb-00032m-9X for emacs-devel@gnu.org; Sun, 07 May 2017 12:24:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d7Oya-0004gk-C4 for emacs-devel@gnu.org; Sun, 07 May 2017 12:24:05 -0400 Original-Received: from manu26.manufrog.com ([98.142.98.2]:47000) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d7OyV-0004fo-UN; Sun, 07 May 2017 12:24:00 -0400 Original-Received: from c-f000e555.04-211-6c6b701.cust.bredbandsbolaget.se ([85.229.0.240]:34120 helo=muon.localdomain) by manu26.manufrog.com with esmtpa (Exim 4.88) (envelope-from ) id 1d7OyU-004FSH-6c; Sun, 07 May 2017 18:23:58 +0200 Original-Received: by muon.localdomain (Postfix, from userid 1000) id 33E68484205; Sun, 7 May 2017 18:23:56 +0200 (CEST) In-Reply-To: <83tw4xeorf.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 06 May 2017 23:03:48 +0300") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - manu26.manufrog.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - gnu.org X-Get-Message-Sender-Via: manu26.manufrog.com: authenticated_id: noreply@tryserumgardar.se X-Authenticated-Sender: manu26.manufrog.com: noreply@tryserumgardar.se X-Source: X-Source-Args: X-Source-Dir: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 98.142.98.2 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214675 Archived-At: Eli Zaretskii writes: >> From: Johan Bockg=C3=A5rd >> Cc: mvoteiza@udel.edu, jean.christophe.helary@gmail.com, >> tino.calancha@gmail.com, emacs-devel@gnu.org >> Date: Sat, 06 May 2017 21:55:52 +0200 >>=20 >> Eli Zaretskii writes: >>=20 >> >> From: Johan Bockg=C3=A5rd >> >> Cc: Eli Zaretskii , mvoteiza@udel.edu, >> >> emacs-devel@gnu.org, tino.calancha@gmail.com >> >> Date: Sat, 06 May 2017 19:51:33 +0200 >> >>=20 >> >> > + (if (string-match (concat "\\`" (or regexp "[ \t\n\r]+")) strin= g) >> >>=20 >> >> I think regexp should be surrounded by a grouping construct, like: >> >>=20 >> >> (concat "\\`\\(?:" (or regexp "[ \t\n\r]+") "\\)") >> >>=20 >> >> And similarly for string-trim-right. >> > >> > Rationale? >>=20 >> regexp can contain \| > > Shouldn't such a regexp be surrounded by "\\(..\\)"? This code performs string concatenation on a perfectly valid regexp provided by the caller. IMO, it is this code's responsibility that the result is sensible after the concatenation. Are you saying this should be the caller's duty?