From: "Johan Bockgård" <bojohan@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: mvoteiza@udel.edu, jean.christophe.helary@gmail.com,
tino.calancha@gmail.com, emacs-devel@gnu.org
Subject: Re: Trimming strings, /emacs/lisp/emacs-lisp/subr-x.el modification
Date: Sun, 07 May 2017 18:23:56 +0200 [thread overview]
Message-ID: <87zieo4ov7.fsf@gnu.org> (raw)
In-Reply-To: <83tw4xeorf.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 06 May 2017 23:03:48 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Johan Bockgård <bojohan@gnu.org>
>> Cc: mvoteiza@udel.edu, jean.christophe.helary@gmail.com,
>> tino.calancha@gmail.com, emacs-devel@gnu.org
>> Date: Sat, 06 May 2017 21:55:52 +0200
>>
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>> >> From: Johan Bockgård <bojohan@gnu.org>
>> >> Cc: Eli Zaretskii <eliz@gnu.org>, mvoteiza@udel.edu,
>> >> emacs-devel@gnu.org, tino.calancha@gmail.com
>> >> Date: Sat, 06 May 2017 19:51:33 +0200
>> >>
>> >> > + (if (string-match (concat "\\`" (or regexp "[ \t\n\r]+")) string)
>> >>
>> >> I think regexp should be surrounded by a grouping construct, like:
>> >>
>> >> (concat "\\`\\(?:" (or regexp "[ \t\n\r]+") "\\)")
>> >>
>> >> And similarly for string-trim-right.
>> >
>> > Rationale?
>>
>> regexp can contain \|
>
> Shouldn't such a regexp be surrounded by "\\(..\\)"?
This code performs string concatenation on a perfectly valid regexp
provided by the caller. IMO, it is this code's responsibility that the
result is sensible after the concatenation.
Are you saying this should be the caller's duty?
next prev parent reply other threads:[~2017-05-07 16:23 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-02 9:34 Trimming strings, /emacs/lisp/emacs-lisp/subr-x.el modification Jean-Christophe Helary
2017-05-02 15:41 ` Clément Pit-Claudel
2017-05-02 22:35 ` Jean-Christophe Helary
2017-05-02 17:16 ` Eli Zaretskii
2017-05-02 22:48 ` Jean-Christophe Helary
2017-05-02 23:11 ` Mark Oteiza
2017-05-03 1:13 ` Jean-Christophe Helary
2017-05-06 2:41 ` Jean-Christophe Helary
2017-05-06 4:29 ` Tino Calancha
2017-05-06 9:02 ` Jean-Christophe Helary
2017-05-06 9:22 ` Eli Zaretskii
2017-05-06 10:33 ` Jean-Christophe Helary
2017-05-06 10:43 ` Eli Zaretskii
2017-05-06 11:02 ` Jean-Christophe Helary
2017-05-06 13:05 ` Jean-Christophe Helary
2017-05-06 13:51 ` Tino Calancha
2017-05-06 14:24 ` Eli Zaretskii
2017-05-07 2:25 ` Tino Calancha
2017-05-07 2:43 ` Eli Zaretskii
2017-05-07 10:40 ` Tino Calancha
2017-05-06 17:51 ` Johan Bockgård
2017-05-06 19:02 ` Eli Zaretskii
2017-05-06 19:55 ` Johan Bockgård
2017-05-06 20:03 ` Eli Zaretskii
2017-05-07 16:23 ` Johan Bockgård [this message]
2017-05-07 16:53 ` Eli Zaretskii
2017-05-10 9:21 ` Yuri Khan
2017-05-10 11:15 ` Jean-Christophe Helary
2017-05-10 11:56 ` Stefan Monnier
2017-05-10 12:21 ` Jean-Christophe Helary
2017-05-08 2:40 ` Jean-Christophe Helary
2017-05-08 14:28 ` Eli Zaretskii
2017-05-08 21:33 ` Jean-Christophe Helary
2017-05-08 22:45 ` Johan Bockgård
2017-05-08 23:15 ` Jean-Christophe Helary
2017-05-09 12:05 ` Michael Heerdegen
2017-05-09 13:09 ` Jean-Christophe Helary
2017-05-09 14:05 ` Michael Heerdegen
2017-05-10 9:30 ` Michael Heerdegen
2017-05-10 11:11 ` Jean-Christophe Helary
2017-05-09 15:23 ` Eli Zaretskii
2017-05-09 15:33 ` Jean-Christophe Helary
2017-05-09 16:21 ` Eli Zaretskii
2017-05-09 23:03 ` Jean-Christophe Helary
2017-05-10 0:45 ` Stefan Monnier
2017-05-10 2:44 ` Eli Zaretskii
2017-05-10 3:09 ` Stefan Monnier
2017-05-10 3:49 ` Jean-Christophe Helary
2017-05-10 11:55 ` Stefan Monnier
2017-05-09 16:37 ` Andreas Schwab
2017-05-10 2:29 ` Eli Zaretskii
2017-05-10 7:45 ` Andreas Schwab
2017-05-10 11:07 ` Jean-Christophe Helary
2017-05-07 4:39 ` Jean-Christophe Helary
2017-05-07 14:49 ` Eli Zaretskii
2017-05-07 13:48 ` Stefan Monnier
2017-05-10 14:26 ` Jean-Christophe Helary
[not found] ` <95032941-C381-47C3-9554-3E13DE6A5013@gmail.com>
2017-05-16 22:21 ` bug#26908: Fwd: " Jean-Christophe Helary
2017-05-17 2:26 ` Eli Zaretskii
2017-05-17 3:41 ` Jean-Christophe Helary
2017-05-06 11:06 ` Jean-Christophe Helary
2017-05-06 16:30 ` Drew Adams
2017-05-06 17:44 ` Stefan Monnier
2017-05-06 18:07 ` subr-x.el code and defsubst [was: Trimming strings, /.../subr-x.el modification] Drew Adams
2017-05-14 22:45 ` Tianxiang Xiong
2017-05-15 1:11 ` Drew Adams
2017-05-06 9:12 ` Trimming strings, /emacs/lisp/emacs-lisp/subr-x.el modification Andreas Schwab
2017-05-06 10:31 ` Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zieo4ov7.fsf@gnu.org \
--to=bojohan@gnu.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=jean.christophe.helary@gmail.com \
--cc=mvoteiza@udel.edu \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).