From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: libnettle/libhogweed WIP Date: Tue, 27 Jun 2017 18:58:30 -0400 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <87zictm415.fsf@lifelogs.com> References: <83tw5pg1q3.fsf@gnu.org> <87zifhulc2.fsf@lifelogs.com> <83h91og80k.fsf@gnu.org> <87pogbuhoe.fsf@lifelogs.com> <834lxndmd9.fsf@gnu.org> <87efwrug6z.fsf@lifelogs.com> <87r30qu5av.fsf@lifelogs.com> <874lxmtxyy.fsf@lifelogs.com> <87r30prvwt.fsf@lifelogs.com> <8337d4csez.fsf@gnu.org> <87r30nq9el.fsf@lifelogs.com> <83inlyc1k2.fsf@gnu.org> <87inlyrfni.fsf@lifelogs.com> <837f2eb845.fsf@gnu.org> <87ziedpyy1.fsf@lifelogs.com> <83d1b75u8a.fsf@gnu.org> <87r2znntaq.fsf@lifelogs.com> <87o9u8q4a5.fsf@lifelogs.com> <83tw3xbklg.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1498604361 28958 195.159.176.226 (27 Jun 2017 22:59:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 27 Jun 2017 22:59:21 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 28 00:59:18 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dPzS2-0007JT-0n for ged-emacs-devel@m.gmane.org; Wed, 28 Jun 2017 00:59:18 +0200 Original-Received: from localhost ([::1]:58512 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dPzS7-0007D6-6K for ged-emacs-devel@m.gmane.org; Tue, 27 Jun 2017 18:59:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34120) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dPzRU-0007Cg-VD for emacs-devel@gnu.org; Tue, 27 Jun 2017 18:58:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dPzRR-0004RH-UT for emacs-devel@gnu.org; Tue, 27 Jun 2017 18:58:45 -0400 Original-Received: from [195.159.176.226] (port=36984 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dPzRR-0004R0-O8 for emacs-devel@gnu.org; Tue, 27 Jun 2017 18:58:41 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1dPzRI-00052U-2L for emacs-devel@gnu.org; Wed, 28 Jun 2017 00:58:32 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 67 Original-X-Complaints-To: usenet@blaine.gmane.org X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Cancel-Lock: sha1:jPjuUVTcecevbFL02PVkRWG19W4= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216029 Archived-At: On Sat, 03 Jun 2017 10:23:39 +0300 Eli Zaretskii wrote: EZ> There are a few TODOs in the documentation and in the code. The one EZ> in the docs should be either removed or moved to a comment so that it EZ> doesn't appear in the manual. Those in the code should be reviewed, EZ> and in each case please decide whether the TODO will be handled any EZ> time soon, or maybe should be simply deleted. I hope we can resume work on this. I've set aside time for it. Sorry for the repeated delays. There is only one major TODO I can't resolve: I asked for help before, and still can't make the autoconf code detect the GnuTLS functions individually. So there are TODOs in the code and docs about it. I can't merge without that--it would be a pretty bad situation for portability and future compatibility to pin on just the GnuTLS version. The other TODO below maybe can be answered here? Should I remove it or leave it? // TODO: switch this to use a resize_string_data() function when // that's provided in the C core, to avoid the extra copy. I think I've fixed the doc issues you noted. Thank you for the thorough reading. I couldn't explain IV and other cryptographic terms in detail in the Lisp reference manual so I pointed to the GnuTLS home page. EZ> I think we still prefer the /* .. */ style of comments. I changed all but the TODOs to that style. EZ> You don't need a 'return' after calling 'error' (here and elsewhere), EZ> as the latter doesn't return. I got warnings for it in a few places so I added those returns consistently. I also think it's cleaner to do it that way. Is this important enough to change these instances? EZ> Some of the lines in doc strings you wrote are too long, please make EZ> sure they are no longer than 76 characters, and in any case fit on a EZ> single 80-column line. I tried. Several are really hard to condense further and I'm right around 80. EZ> No need for braces when there's only 1 line in the block. I removed them, but it's not my favorite thing to omit the braces, especially in the if a b else if c d else e situation. Do you think I should reintroduce them in those places? On Sat, 03 Jun 2017 11:00:16 +0200 Andreas Schwab wrote: AS> Wouldn't it be even simpler to just pass each argument separately? I want the format to be flexible to accomodate future expansion, and passing arguments explicitly would defeat that purpose. Ted