From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: "Neal H. Walfield" Newsgroups: gmane.emacs.devel Subject: Re: epg.el: epg--status-GET_LINE not working? Date: Thu, 06 Jul 2017 21:42:14 +0200 Message-ID: <87zichuzc9.wl-neal@walfield.org> References: <87fuenqlp8.fsf@mithlond.arda> <874lur5uia.fsf@mithlond.arda> <87d19ec0li.fsf-ueno@gnu.org> <87fueapuyl.fsf@mithlond.arda> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Trace: blaine.gmane.org 1499373657 3962 195.159.176.226 (6 Jul 2017 20:40:57 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 6 Jul 2017 20:40:57 +0000 (UTC) User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/24.5 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Cc: Daiki Ueno , "Neal H. Walfield" , emacs-devel@gnu.org To: Teemu Likonen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 06 22:40:53 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dTDa0-0000oA-D8 for ged-emacs-devel@m.gmane.org; Thu, 06 Jul 2017 22:40:52 +0200 Original-Received: from localhost ([::1]:53197 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dTDa5-0002xL-Re for ged-emacs-devel@m.gmane.org; Thu, 06 Jul 2017 16:40:57 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54948) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dTCfM-0001ez-VC for emacs-devel@gnu.org; Thu, 06 Jul 2017 15:42:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dTCfM-0000Uq-4m for emacs-devel@gnu.org; Thu, 06 Jul 2017 15:42:21 -0400 Original-Received: from mail.dasr.de ([217.69.77.164]:48791) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dTCfI-0000Pi-7Z; Thu, 06 Jul 2017 15:42:16 -0400 Original-Received: from p508132ab.dip0.t-ipconnect.de ([80.129.50.171] helo=grit.huenfield.org.walfield.org) by mail.dasr.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.86_2) (envelope-from ) id 1dTCfH-0003eL-0f; Thu, 06 Jul 2017 19:42:15 +0000 In-Reply-To: <87fueapuyl.fsf@mithlond.arda> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 217.69.77.164 X-Mailman-Approved-At: Thu, 06 Jul 2017 16:39:14 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216245 Archived-At: At Wed, 05 Jul 2017 22:03:30 +0300, Teemu Likonen wrote: > Daiki Ueno [2017-07-05 18:25:29+02] wrote: > > Teemu Likonen writes: > > Anyway, I would rather ignore "tofu.conflict" like the attached patch > > (not tested), until it becomes really useful. > > I agree but with a small addition. That skips the "GET_LINE > tofu.conflict" case (which I think is good) but user is left without any > information about what happened. Function epg-signature-to-string will > return a string like this: > > Good signature from [keyid] [user id] created at > 2017-07-05T21:25:57+0300 using RSA > > The signature is good but the usual "(trust ...)" is missing so there is > no information about key's validity. I suggest adding just the tofu > conflict info. With a patch like below the mentioned function would > return: > > Good signature from [keyid] [user id] (trust: tofu-conflict) created > at 2017-07-05T21:25:57+0300 using RSA Why not implement TOFU support properly by showing the conflict and allowing the user to resolve it instead of what appears to me to be a workaround?