Re: Heads-up: Emacs 26.1 RC1

[Eric Abrahamsen <eric@ericabrahamsen.net>]

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> From: Eric Abrahamsen <eric@ericabrahamsen.net>
>>> Cc: pierre.techoueyres@free.fr,  johnw@gnu.org,  emacs-devel@gnu.org
>>> Date: Wed, 21 Mar 2018 07:22:48 +0800
>>>
>>> > Which code/packages outside of CEDET use the affected functions?
>>>
>>> Pcache is a big one, as several other packages depend on it -- though I
>>> haven't been able to figure out exactly how many from the Melpa repo. It
>>> currently errors loudly. The Gnus repository is another, and it is
>>> silently corrupted. Those are the main two, and the code changes (though
>>> they look large) are specifically targeted at those two packages. A more
>>> general solution is in the works for 27, but this was the smallest diff
>>> I could manage that fixes the problem.
>>
>> Then please explain in more detail why the 2nd branch of the 'cond'
>> you introduced is needed (the 1st just repeats the original code, so
>> it doesn't need any explanation).
>>
>> Thanks.
>
> Backing up just a bit, I've made two changes to eieio-persistent over
> the past few months, both of them already on 26. Both changes introduced
> errors that need to be fixed. They are:
>
> c59ddb2120 * Fix slot typecheck in eieio-persistent
> e1cc2037a9 * Handle hash tables and vectors when reading/writing EIEIO objects
>
> The first contained a dumb error in that valid types could be returned
> as a list, but the code that consumed the return value didn't handle a
> list. That mistake is fixed in this (very small) commit on the
> fix/eieio-persistent branch:
>
> 1ea9947ca3 * Handle possible classtype values in eieio-persistent-read
>
> This fix is necessary to get pcache working again.
>
> The second commit was also necessary for pcache, as it stores eieio
> objects inside hash tables. This wasn't an issue in Emacs 25, because
> the hash tables were serialized with `prin1', including their values,
> and objects written with `prin1' could be read with `read'. It *is* an
> issue in Emacs 26, however, because those objects can no longer be read
> with `read'. Commit e1cc2037a9

bf4f34ac7d, sorry...