From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] open bookmark in other frame Date: Thu, 11 Oct 2018 02:19:33 -0500 Message-ID: <87zhvl0x2y.fsf@red-bean.com> References: <9d4a9ab3-d802-447e-3c74-81373b7e6101@luyten.fr> Reply-To: Karl Fogel NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1539242263 27492 195.159.176.226 (11 Oct 2018 07:17:43 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 11 Oct 2018 07:17:43 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) Cc: Pierre-Yves Luyten , emacs-devel@gnu.org To: Drew Adams Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 11 09:17:39 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gAVE2-00071r-Di for ged-emacs-devel@m.gmane.org; Thu, 11 Oct 2018 09:17:38 +0200 Original-Received: from localhost ([::1]:60897 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gAVG8-0005xn-Tp for ged-emacs-devel@m.gmane.org; Thu, 11 Oct 2018 03:19:48 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:57269) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gAVFx-0005xc-6i for emacs-devel@gnu.org; Thu, 11 Oct 2018 03:19:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gAVFw-0002Fb-Cm for emacs-devel@gnu.org; Thu, 11 Oct 2018 03:19:37 -0400 Original-Received: from mail-oi1-x242.google.com ([2607:f8b0:4864:20::242]:35515) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gAVFw-0002FC-6F for emacs-devel@gnu.org; Thu, 11 Oct 2018 03:19:36 -0400 Original-Received: by mail-oi1-x242.google.com with SMTP id 22-v6so6228498oiz.2 for ; Thu, 11 Oct 2018 00:19:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:reply-to:date:in-reply-to :message-id:user-agent:mime-version; bh=LU5AgeCPvm5eC2I4pmINrJ3ZoFWVljsxg72PsVyBwic=; b=bc+Ey6ozkqpP+zY3Bze1p1L5JDgE5lHTOfdOsD6ekrqH4inKNKoQsMJuj6jbYhKFJO D6utPWcOKWGb0ZdxT7EFsO/mCAFx1J6XeWKXv3Qx35g6NVmtYJLxGdE8L+W5qO0ioUEo 8CDuN8ZBUB7lF93l42aol3K3u3/UIJHAlxgEZ60B/WrpKqHv7yxMuLLTcAqpI5Ttc7uq iD8EMbcVz+m1is9CZ2kaEipr8I9UnTcPCKclDIaR2Nauc0gXy+/HWkgY5DanKqnNM0oX SxtYEyjn6GHW+9Tf+43uk0EqdpwxVoFiQWW0te7QnBDwsjzURL6TvHsX3ZrvhcMpw2FR OIXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:reply-to :date:in-reply-to:message-id:user-agent:mime-version; bh=LU5AgeCPvm5eC2I4pmINrJ3ZoFWVljsxg72PsVyBwic=; b=TlnfPTiq49OG06Fojef2AtiMIKwPUAQmXn5TeeCSkcf2Z+YB4QXWAqtpu3CsPqs1+i TDbjO6FYf4vxoRZi3BIUxNBoT9GTYtMiMttJosc1Z/gOupcxQMyeJCcusTkyBxHY8w5u CY5izRMBV1bhbD823RKXM5DboRPEq7BY0lWeBbjNAT07op7er3n1pPYXtoNg9MD15a1G V3X46twyqYUZIevFtZ74Focj9E00zaTnIDufUEEQVredJAiOyj6VXwneLFWiZQlmSGIA QxNpnBLao48+yfitTX8V0kNXDZ1jByeZXQiayseZjdaeNc7qFz1Awf/eEBEXakaXeSOV moIg== X-Gm-Message-State: ABuFfoiE2kkGi9ph4NsMm+6vQxvZGsfZCdv4bCgy97otvUyspA/zfUTL wwhGWDZVMAVeUPbdkv1GlrVu/OUk X-Google-Smtp-Source: ACcGV62mMjDa/05S4HpHrhngOUXNqeq+aXPbQ43k0FnzQYaRDyrLbsSNhFZrA0tte8WKKFAhKwSCvA== X-Received: by 2002:aca:54cb:: with SMTP id i194-v6mr240754oib.340.1539242375096; Thu, 11 Oct 2018 00:19:35 -0700 (PDT) Original-Received: from floss ([2602:306:3707:da30:1939:bfd0:e80b:3f1b]) by smtp.gmail.com with ESMTPSA id z9sm251606ota.44.2018.10.11.00.19.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 11 Oct 2018 00:19:34 -0700 (PDT) In-Reply-To: (Drew Adams's message of "Wed, 10 Oct 2018 22:06:24 +0000 (UTC)") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::242 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230333 Archived-At: Drew Adams writes: >My suggestions in this regard, FWIW: > >1. Don't use `view-buffer-other-frame'. > Select the buffer, and not just read-only. Jumping to a bookmark > typically puts you at its location (hence select), and the buffer is > typically not put in a read-only mode. IOW, do the equivalent of > this, or similar: > > (let ((pop-up-frames t)) (bookmark-jump-other-window bookmark) Agreed -- there's no reason it should be read-only. Jumping to a bookmark doesn't normally cause the destination to be read-only, so there's no reason that should happen just because we're in a new frame. (I haven't studied `pop-up-frames' enough to know whether Drew's back-of-the-envelope solution above is the best way, but presumably a little more research would lead to the best way.) >2. Don't use `F' as the key binding in the bookmark-list buffer. > `F' is more often used for files than for frames. Maybe use `5'. > > (I use `J 5' in Bookmark+. `J' is a prefix for the jump commands > in the bookmark-list buffer. The `5' is from `C-x 5' bindings for > other-frame. I bind the command to `C-x 5 B' and `C-x j 5' globally. > `C-x j' is a global prefix key for bookmark jump commands.) I don't have a strong opinion here, but my fingers also lean slightly toward "5" because of `C-x 5 b', for what it's worth. Thanks for noticing that `view-buffer-other-frame' leads to read-onlyness, Drew, and for the "5" idea. Best regards, -Karl