From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alex Gramiak Newsgroups: gmane.emacs.devel Subject: Re: scratch/x_emacs d2df826 5/5: fixup! Revert x_frame_parameter -> frame_parameter_pos change Date: Tue, 16 Apr 2019 11:18:21 -0600 Message-ID: <87zhopc1ia.fsf@gmail.com> References: <20190416165204.7024.23185@vcs0.savannah.gnu.org> <20190416165207.442F52068F@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="172078"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 16 19:19:17 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hGRjo-000iYA-MD for ged-emacs-devel@m.gmane.org; Tue, 16 Apr 2019 19:19:16 +0200 Original-Received: from localhost ([127.0.0.1]:39936 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGRjn-0001Wx-1t for ged-emacs-devel@m.gmane.org; Tue, 16 Apr 2019 13:19:15 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35431) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGRiy-0001Wr-I7 for emacs-devel@gnu.org; Tue, 16 Apr 2019 13:18:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hGRix-0002Nq-Mr for emacs-devel@gnu.org; Tue, 16 Apr 2019 13:18:24 -0400 Original-Received: from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436]:44219) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hGRix-0002N4-C3 for emacs-devel@gnu.org; Tue, 16 Apr 2019 13:18:23 -0400 Original-Received: by mail-pf1-x436.google.com with SMTP id y13so10707665pfm.11 for ; Tue, 16 Apr 2019 10:18:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=RG3QNX238QGRjn55l/LPcy5ZagH4E+xhnJXRqdNNXyo=; b=CEMsEoGDfYMJb9yYsd+G4NVjqgl7GKXHoHwaFne4HZV9ZOu3l+XJW9im+18nwBrkaZ z7+R35IGMDk3fdhQXeYSC8zU/y3u14J750/WjkBoGSEOmYml66/aH7/ODtr7G8L3tvyT aJlISGpMAHOSyxpzQTOTyzUxHLQOG0hQ/De0IFIl7ACAH6A+ft+pJiu7wMiJVmwyG6dv 9Sb4041yn1Z/N21LDQ+rQB7ogQkGq4f2iVK/etWDfFEHRVbYWj970x6whMDTRVRZsTkx pHNaW3iwddWC29WPxtcPBmytJmj9KSab4GHFr38sFDLxpvAdypeyhZBSOaAJQcYTRMpG /qpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=RG3QNX238QGRjn55l/LPcy5ZagH4E+xhnJXRqdNNXyo=; b=Akbw8ygRqTIiNtSRreQyqfVqGxkCDMskAA/1esWWgLgytUn/EXPXDaRLPiF72W9lYe LmG+94cgGh71M252KOmb38la2T449qd+hNqQ4KAzFvQHwTJzGFkuBx8+9sBsPiwm8jCz WXyVbixtFbBVBpKEK5pPIi6bTl9J2cP6Way+IYsJ2KH4TRoOVNUNY1qlB6jTtmFw8AbE kvq5h4u72r/5kX68RMmkEfXP4tFsXbUzsI405F+8Lq8BW8+WZMXDuOpsiItCB4cWJZte i+ez+C7Tk2FWN9g4c0PgjdXJVXq+50gPJRRfM2v+6CnrtUFDvq5V6dNJkiunp5bShfnl rmhw== X-Gm-Message-State: APjAAAVQEb8KQWiM4+10hfQQX+4Jp+S0IWpvTNaAQwNlTUSkcZGMDQOl EFp6BVUNOx6GAAI+ttUdY29YXwzs X-Google-Smtp-Source: APXvYqya/exVLO7VCXsbwW2cVd5bm/DG+HhOatAGVuApWNcpaxXnibmoQJhmwApAbVILZvlPNfA7BQ== X-Received: by 2002:a63:8848:: with SMTP id l69mr73407326pgd.137.1555435101870; Tue, 16 Apr 2019 10:18:21 -0700 (PDT) Original-Received: from lylat ([2604:3d09:e37f:1500:1a72:4878:e793:7302]) by smtp.gmail.com with ESMTPSA id e126sm130541897pfh.35.2019.04.16.10.18.20 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 Apr 2019 10:18:21 -0700 (PDT) In-Reply-To: (Robert Pluim's message of "Tue, 16 Apr 2019 19:05:21 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::436 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235539 Archived-At: Robert Pluim writes: > CC xdisp.o > xdisp.c:29300:37: error: no member named 'x_highlight_frame' in > 'struct ns_display_info'; did you mean 'ns_highlight_frame'? > || f != FRAME_DISPLAY_INFO (f)->x_highlight_frame) > ^~~~~~~~~~~~~~~~~ > ns_highlight_frame > ./nsterm.h:884:17: note: 'ns_highlight_frame' declared here > struct frame *ns_highlight_frame; > ^ > 1 error generated. > > (on macOS) Ah, I originally renamed the x_highlight_frame on W32/NS to {w32,ns}_*, but decided against it since xdisp.c used the attribute directly (a hook or union interface could be added later). Perhaps it should be renamed native_highlight_frame until then, though. I pushed the fix, do you get any other errors/warnings on macOS? Thanks for testing.