From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Improve Gravatar support Date: Mon, 22 Jul 2019 22:44:53 +0100 Message-ID: <87zhl54ucq.fsf@tcd.ie> References: <87muh6w6c6.fsf@tcd.ie> <8736iy2o2i.fsf@mouse.gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="6363"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Julien Danjou , emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 22 23:47:59 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hpgA2-0001Ut-DI for ged-emacs-devel@m.gmane.org; Mon, 22 Jul 2019 23:47:58 +0200 Original-Received: from localhost ([::1]:37960 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpgA1-00053R-Eg for ged-emacs-devel@m.gmane.org; Mon, 22 Jul 2019 17:47:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59893) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpg9t-000537-DN for emacs-devel@gnu.org; Mon, 22 Jul 2019 17:47:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hpg9g-0007of-LM for emacs-devel@gnu.org; Mon, 22 Jul 2019 17:47:40 -0400 Original-Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:45605) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hpg9T-0005pu-Sf for emacs-devel@gnu.org; Mon, 22 Jul 2019 17:47:28 -0400 Original-Received: by mail-wr1-x443.google.com with SMTP id f9so40886352wre.12 for ; Mon, 22 Jul 2019 14:44:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=v0yegarCDH8A8bYDafCvZFzx+DUE4TBfs4d8+YxLJpU=; b=k8U/FokqFi10tWJScLTn4g9tIx6oT8qWXu2/qt2MkJUvtz0Fwl9t9ky42vfibq3rwh 5v/dPkQMxG9ojXr8meFbb8bmX4hdK0d9Dfdg5LYovtSZkXOcHPKp3HpzojgMjfvVmb36 8D81fVODl9RUg7rn0k9mUyMMcO+A1/wxkyAPcR9zO1NfTIAm6sfQdrbWDamKghvk0SvZ A5lSBKSD/48zxsiHr8t0dwSqak44prBJEx8TI10FLoxxlqqw51+gVr81i/EfeXDTUcA8 kjOnVxJBJMWP1UL5Awh1cOVAoUj2IJdqxgK9MKocYRpfl9VEY27zAs9koG2jvc/a27H3 JCVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=v0yegarCDH8A8bYDafCvZFzx+DUE4TBfs4d8+YxLJpU=; b=d0fyqaINSOiboKV71Dd2WEqB9Kj6Xe9CrJiv6s3fSK6vQxNjOV13tNQBl2e8ZgOIpq bo7IggYyG8E9+5r0JiX/xWuM367bJ/UeKuELJ2aa2mn19WA3FPbhZfVpwU1wJBDjJYSK s5OKgXwj0iyOmL0GIkci4Xo5SlPPwWhsP6s4QGe3VL2X2aItHAoCy92OOBHWWWC2sC5X Zr+BAej5S6rx1l539JqN+yQXIJ5+YIPi/48OJEs2xaHD4bpeEM7XMUmibBYsHzwMmjwH tjn8mLXnPAadnR/pF8NxtdpPr939ECUr4m6iuqpPedm52HuozZmOo0tAUOig/gnCnhA0 bStw== X-Gm-Message-State: APjAAAWXV7FCv8VC0zB6dvfvi61Z9hZkM87DrEyneaAUsfDmCTaEzKCz dABJStJhLifVOSmPfUZ42j0/rA== X-Google-Smtp-Source: APXvYqxVemLxpLH/Bapk9F1I+cQxdtO1FgicM8XdZAUyTYXdyQ9AYL1+eFBQTJ9T6e4FNxRe5g8UcQ== X-Received: by 2002:adf:fc52:: with SMTP id e18mr73441892wrs.14.1563831896567; Mon, 22 Jul 2019 14:44:56 -0700 (PDT) Original-Received: from localhost ([86.47.56.169]) by smtp.gmail.com with ESMTPSA id o7sm35162457wmc.36.2019.07.22.14.44.55 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 22 Jul 2019 14:44:55 -0700 (PDT) In-Reply-To: <8736iy2o2i.fsf@mouse.gnus.org> (Lars Ingebrigtsen's message of "Mon, 22 Jul 2019 15:31:17 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::443 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238809 Archived-At: Lars Ingebrigtsen writes: > After skimming (on holiday), looks good to me. Thanks, enjoy your holiday! There's no rush on my part. > Extremely minor comments below: > > "Basil L. Contovounesios" writes: > >> (defcustom gnus-gravatar-too-ugly gnus-article-x-face-too-ugly >> - "Regexp matching posters whose avatar shouldn't be shown automatically." >> - :type '(choice regexp (const nil)) >> + "Regexp matching posters whose avatar shouldn't be shown automatically. >> +Nil means show all avatars." > > We don't capitalise nil in documentation, do we? "git grep '\'" returns only a few hits, so I guess you're right. Will change. >> - ;; The buffer can be gone at this time >> - (when (buffer-live-p (current-buffer)) >> + ;; The buffer can be gone at this time. >> + (when (buffer-name) > > I think buffer-live-p is clearer than just saying buffer-name. Agreed. >> - (interactive (list t)) ;; When type `W D g' >> + (interactive "p") ;; When type `W D g' > > Perhaps grammer fix? I'd rather remove these comments altogether, if that's okay with you. The default key bindings are not important here, and it's tautological to say that the interactive spec takes effect when the function is called as the result of a key binding. These changes are now included in the split patch set in my other message. Thanks, -- Basil