From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Really prevent quitting in sensitive contexts Date: Tue, 14 Apr 2020 10:40:57 +0200 Message-ID: <87zhbezch2.fsf@gmx.de> References: <20200312020554.194607-1-dancol@dancol.org> <7eced910-43dd-5e62-a864-beded660a07e@dancol.org> <87tv2tga3i.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="116053"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Stefan Monnier , emacs-devel@gnu.org To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 14 10:46:22 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jOHD4-000U6C-EK for ged-emacs-devel@m.gmane-mx.org; Tue, 14 Apr 2020 10:46:22 +0200 Original-Received: from localhost ([::1]:54414 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOHD3-0002lL-3C for ged-emacs-devel@m.gmane-mx.org; Tue, 14 Apr 2020 04:46:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53403) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOH82-0001oW-A1 for emacs-devel@gnu.org; Tue, 14 Apr 2020 04:41:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jOH81-0008FM-Au for emacs-devel@gnu.org; Tue, 14 Apr 2020 04:41:10 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:44055) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jOH81-0008F0-2r for emacs-devel@gnu.org; Tue, 14 Apr 2020 04:41:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1586853659; bh=yum7jJW80gpSTvRKjn9gyaQcL/KIatOF79srSiqnhzQ=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=XHxOLWz65AJ6GN9hEmiYsPghywGGiuYcOp/mCZ+PhxA1mnxsoYwUizb2gmB2fmB7X lqTM9w6TVC33pwUn3svQDDi03TOPwNnOD2ymcgg5Q2ejoCftK/kIrNMfEsY9hEiyr5 tuqqRiuMwdnecOHid1OSyOi65sLqryM+KZTvI5CU= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from detlef.gmx.de ([213.220.151.7]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MgNh1-1imAse1ElD-00hvXx; Tue, 14 Apr 2020 10:40:59 +0200 In-Reply-To: (Daniel Colascione's message of "Mon, 13 Apr 2020 23:56:14 -0700") X-Provags-ID: V03:K1:C6q6ZWRZpO6EVU2Lk+HSP3ZB1gkmYmNv67w5Y0dIsy0/sZdQnQu /OW+vjMuNZ0c+U0Z3bwAU5HhQCpyN3w1lHhR4PAUcTHbBDXNdIJdH8e12H5JCJ0mkKmvaX1 pRevQ9hF9H00tcuX3l+tcMD01Jx63L+4Udr2qDYEMlv8ScbgEYux39hjPQiYD+IkzOR8F6P ojbSTvX+qbXCDvDYLz60g== X-UI-Out-Filterresults: notjunk:1;V03:K0:A2ut4um0GCQ=:q/5V1OzlpKGI+3fZDSFch0 gN52UM94USXDIoxQtW6rnDs6Pc0zrfnSNyRe/p1yR2ho4XN3s9IWZVUFz3Agt64ef1CYMtj8L q1Eh+RZ2qkC8Du3ZEYNzbZW9HlR1LU7iZRyt5unJTv4QkemNVBZAbNln+VnCLt3t2eRpQsIdT iaQL+85oRkGrDxrOqhuDMXcKlSH8gNBy3MIhMzjfu/PytKNDlqUJAPa8OlXuWzpe46eENd4dR R4V5j1YReu94FkZC7aGyOAnN+2juQSgwZIjmVLNSdbHqSrbIh+6vC1KUxyUrD+6meWNmQWLh+ ZqXDM/tB8C6U3a/ZbU1bDe2fMvK5e6eQXeUoZMbN5FyriZz4LQu0f/3qXuykadr070n9uNsMd zY3NVrHXhtNAoCxOMgCOkpV+NKRunpca1ldOlCI0f6s6ShLKUWxNhpmONMSS8XliRQcGU9BF4 Ico1AJ8FbRadUdm5NZCklx39bGKJaVa/+G65MVYaBenhgaOS+R2jz7pTANHBM03xV2yb2sQuF 7jrbs3EZNFaLYEZAT+5EifQD5w6JYmpoqD1l5TNx/gbGyyUq0LdC1J3tf5pRZ19uWl86D6P70 QLj1+N3GP+s6QmDk2p2za75jhIhJlZrCAXJ4f/HJ4Q6ngrijVyTACl8n/x2/wI9VGhglsGEQZ rrJHZlw7garHG9ZVECznABq/sxqZdptu9lxKIkrmANqWWuwQmJoXbXows1+WYfmmH10DWMKr2 7PP6FaZFnbFCcMNdHNjFuwqRDNVzKCXVVHiMIwUgvd5eSLYEbcsHEGfyAQLTd4mPnF7LeRm2 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.17.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:246929 Archived-At: Daniel Colascione writes: Hi Daniel, > No, it shouldn't. This use of with-local-quit can *never* be correct > because a stray C-g can *always* interfere with a filter. Don't do > long-running operations in process filters. Period. The fix isn't to > make quitting these operations possible in some defined manner. The > fix is not to do them in the first place. How do you want to prevent use of such a basic operation like `file-truename' in a process filter? And yes, in the remote case this could be a "long-running operation". Best regards, Michael.