From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Amin Bandali Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-27 38f7538 1/2: New function erc-switch-to-buffer-other-window Date: Tue, 14 Apr 2020 11:12:34 -0400 Organization: GNU Message-ID: <87zhbe6qzh.fsf@gnu.org> References: <83lfmyiqkb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="115888"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.90 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 14 18:23:16 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jOOLD-000TrL-Aa for ged-emacs-devel@m.gmane-mx.org; Tue, 14 Apr 2020 18:23:15 +0200 Original-Received: from localhost ([::1]:33794 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOOLC-0002Q2-BW for ged-emacs-devel@m.gmane-mx.org; Tue, 14 Apr 2020 12:23:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50541) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOOIz-0008HC-KK for emacs-devel@gnu.org; Tue, 14 Apr 2020 12:21:03 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41940) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jONEq-0005pD-NN for emacs-devel@gnu.org; Tue, 14 Apr 2020 11:12:36 -0400 Original-Received: from [2607:fea8:3fe0:17d:f40c:88a4:d22:b12e] (port=45432 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jONEp-0008KW-8d; Tue, 14 Apr 2020 11:12:35 -0400 Mail-Followup-To: Eli Zaretskii , emacs-devel@gnu.org In-Reply-To: <83lfmyiqkb.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:246944 Archived-At: --=-=-= Content-Type: text/plain Hi Eli, Eli Zaretskii writes: > Amin, why was this pushed to the emacs-27 branch? Is this a bug fix, > and if so, is it safe and/or urgent enough to be put on the release > branch? > > Thanks. > Indeed, the two changes address an annoyance/shortcoming myself and some other ERC users had noticed, but I don't think they were reported on bugs.gnu.org. The changes are rather simple and I believe safe enough for the release branch: they both simply refactor out the implementation into similarly named internal functions, and provide a new variant that uses `switch-to-buffer-other-window' rather than `switch-to-buffer'. I think the changes are simple yet useful enough to be in emacs-27; though in hindsight, the master branch may have been a better place for them. That said, if you or others spot any issues with them, I'd be more than happy to try and address them, or even revert them if needed. As a side note, I will be looking into making ERC available on GNU ELPA so that addition of new features and/or bug fixes wouldn't require having to run the latest Emacs release or trunk. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJEBAEBCAAuFiEEObM8jZRIDS3cwqSYi0Sgzce5VvIFAl6V0uIQHGJhbmRhbGlA Z251Lm9yZwAKCRCLRKDNx7lW8nwjD/9Apog0wt/fBgrt07meWS2OfiAkKlGi1k2R grMF6kELp02z2vYtCIoXemB3HnTc554/rscP5SoIqE1siuh6YrLyN8pX+Zue4ljO tt/+TaolDnZhzazTFUHptO14un3v/XKlEzMKukZILkuAtFSQIjKqMUD0HzMJEjA+ M71EpUV/L+jRmn0aEtGZo5jdD7jEL9aX5AYFqDzh1SfZ/Zj3fXY/l82xcuQIL+AB yi5gYfnz/dWAj3oE19hpQpnrG0GMRAliQEBs3neksU791vz1i8xG4h1SnYQEoW9e 4mmjfyhxarzXW/HAR05T/rFzZpOPisUk64Pk1hahfONpEFUbHlKo3yCO8Quwo9zX 9ByAc3VT/RmXMn3GTQ/hHNHyFr2CfHQ36RuoWmInQ515tx3PJXZaceBlJglX4x+h msapKRxGwSMrFd3peqGfYJRY1W45/6XtKXEZiQOwiN8Mpec7Vi3/JzN37n+FR2bx yZ4J9QgjzlF+Lf0cI6J7P5aKOtFjSit6CqJXsMfaPrJ2/D+durGJj4mqnrCFgM2w OZknD6Bqor6jE8299VJeaLgsKyE49u/w2JAp8RAsYQC7zA0qgzBtjBCjVwsGhCFW QaIAa9n2W8FBx7yHqgdytKBJI5RlkujLWIh1PeTJ/TAoOLsw0Uy8PqE1dWhIU4yT T7z7zNxs7g== =11dP -----END PGP SIGNATURE----- --=-=-=--