unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Amin Bandali <bandali@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] emacs-27 38f7538 1/2: New function erc-switch-to-buffer-other-window
Date: Tue, 14 Apr 2020 11:12:34 -0400	[thread overview]
Message-ID: <87zhbe6qzh.fsf@gnu.org> (raw)
In-Reply-To: <83lfmyiqkb.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1112 bytes --]

Hi Eli,

Eli Zaretskii <eliz@gnu.org> writes:

> Amin, why was this pushed to the emacs-27 branch?  Is this a bug fix,
> and if so, is it safe and/or urgent enough to be put on the release
> branch?
>
> Thanks.
>

Indeed, the two changes address an annoyance/shortcoming myself and some
other ERC users had noticed, but I don't think they were reported on
bugs.gnu.org.  The changes are rather simple and I believe safe enough
for the release branch: they both simply refactor out the implementation
into similarly named internal functions, and provide a new variant that
uses `switch-to-buffer-other-window' rather than `switch-to-buffer'.

I think the changes are simple yet useful enough to be in emacs-27;
though in hindsight, the master branch may have been a better place for
them.  That said, if you or others spot any issues with them, I'd be
more than happy to try and address them, or even revert them if needed.

As a side note, I will be looking into making ERC available on GNU ELPA
so that addition of new features and/or bug fixes wouldn't require
having to run the latest Emacs release or trunk.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]

  reply	other threads:[~2020-04-14 15:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-14  5:28 [Emacs-diffs] emacs-27 38f7538 1/2: New function erc-switch-to-buffer-other-window Eli Zaretskii
2020-04-14 15:12 ` Amin Bandali [this message]
2020-04-14 15:48   ` Eli Zaretskii
2020-04-14 15:59     ` Amin Bandali

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zhbe6qzh.fsf@gnu.org \
    --to=bandali@gnu.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).