From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Redisplay slower in Emacs 28 than Emacs 27 Date: Mon, 07 Dec 2020 23:11:06 +0100 Message-ID: <87zh2p5ksl.fsf@gnus.org> References: <877dptiro7.fsf@gnus.org> <87pn3lhcdd.fsf@gnus.org> <878sa9hbe2.fsf@gnus.org> <877dptfvae.fsf@gnus.org> <83czzl8qwu.fsf@gnu.org> <87sg8h78s8.fsf@gnus.org> <87h7ox71xc.fsf@gnus.org> <874kkx6zwj.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10213"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Gregory Heytings Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Dec 07 23:12:50 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kmOkT-0002Y3-CR for ged-emacs-devel@m.gmane-mx.org; Mon, 07 Dec 2020 23:12:49 +0100 Original-Received: from localhost ([::1]:57860 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmOkS-000341-CC for ged-emacs-devel@m.gmane-mx.org; Mon, 07 Dec 2020 17:12:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34288) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmOj2-0002bH-Sb for emacs-devel@gnu.org; Mon, 07 Dec 2020 17:11:20 -0500 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:60732) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmOix-0002A9-2S; Mon, 07 Dec 2020 17:11:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DftcPafd9mxObdWmMe9wYsM1WaSpF3a6yAc5i/NQoqc=; b=poi9agzist90LtlaH4LhDwAgoz 6VLaTDMlS221Z6tkqR27IXmmQWNFFBWL/NguJNy6NnRDBazI9nJhK8PQO1V/1izQj75h672Axj/Ap s+/ndc6wjUsp1hMB3AvLwtlgXRF8lHq+h43zry+/r8ajIpKX38AUIUQftbmtFTiCNIYw=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kmOip-0002NU-Qx; Mon, 07 Dec 2020 23:11:11 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEUnOIxpZGiik0cu QkGRcTBfWCuQipn////0LwWVAAAAAWJLR0QHFmGI6wAAAAd0SU1FB+QMBxYJEM34UmMAAAGmSURB VDjL3ZLbkSMhDEVxBsPYzb+pngCmZAUwXgigjRQAP+Qfwl7xsD1VG8Gq3W24B0kI5Nz/bf7f8meM 7kz0Lp38hztBT45gftrHyX/+HD7GuA9Ap66fvZcvEegxdaBavqFjUOS49/UGuCjs8EjGWGNAUlan GbIIvsP3MRySkyyZIbMB4hTvXd8dj0BetECf27v0HHO8A8i1j4OBMqs4cyG+X18eqtOdhG77tb6D Wrv7Xm4JIPjqZQLva/ObGhjej155aDXU1rZcHmmGVdEOWvMA6Y/qNXgLgKqxXQOwzQqaoUTVZRl6 O/8C4lIKT5DzBGoeCrEGy5GeHgiL7Q6HsCHwKvaSo9O+qxaaRT78u8fMgSktgJt5hrJz/F5dsefi pCzdP1mNmVaOLkMlvKFZs7HWYJmPjUwct4M7c/eIerCLUnqH0aFkh0PWV9ZAJg9UyM7GTte6iabZ SBcoeHjoN+hsnVbs2E1lthya0F7aO5NHUwMofheB+FVsogPwiLuNvz51I+XSzMpMPhbM6cuc7b6P Uv/K+jpe4M3yCKWMxUxFmZaK9y/k9ctSdr/JEgAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMC0xMi0w N1QyMjowOToxNiswMDowMDLrzLgAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjAtMTItMDdUMjI6MDk6 MTYrMDA6MDBDtnQEAAAAAElFTkSuQmCC X-Now-Playing: Shopping's _All Or Nothing_: "For Your Pleasure" In-Reply-To: <874kkx6zwj.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 07 Dec 2020 22:59:24 +0100") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:260529 Archived-At: Lars Ingebrigtsen writes: > And this is the culprit -- i.e., this is what's busting the cache, as > far as I can tell: With this change, the toolbar should no longer bust the image cache. Gregory, can you benchmark with this change (on an otherwise unchanged trunk, i.e., with equal_lists, not !equal_lists)? diff --git a/lisp/tool-bar.el b/lisp/tool-bar.el index 8456216430..c3d0841d0c 100644 --- a/lisp/tool-bar.el +++ b/lisp/tool-bar.el @@ -154,12 +154,12 @@ tool-bar--image-expression (concat icon ".pbm")) colors)) (xbm-spec (append (list :type 'xbm :file (concat icon ".xbm")) colors))) - `(find-image (cond ((not (display-color-p)) - ',(list pbm-spec xbm-spec xpm-lo-spec xpm-spec)) - ((< (display-color-cells) 256) - ',(list xpm-lo-spec xpm-spec pbm-spec xbm-spec)) - (t - ',(list xpm-spec pbm-spec xbm-spec)))))) + `(cond ((not (display-color-p)) + ',(find-image (list pbm-spec xbm-spec xpm-lo-spec xpm-spec))) + ((< (display-color-cells) 256) + ',(find-image (list xpm-lo-spec xpm-spec pbm-spec xbm-spec))) + (t + ',(find-image (list xpm-spec pbm-spec xbm-spec)))))) ;;;###autoload (defun tool-bar-local-item (icon def key map &rest props) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no