From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: master 6458e16: New mode outline-cycle-minor-mode with Orgmode-like TAB cycling on headings Date: Wed, 03 Mar 2021 22:38:22 +0200 Organization: LINKOV.NET Message-ID: <87zgzkug5d.fsf@mail.linkov.net> References: <20210303191236.24697.93201@vcs0.savannah.gnu.org> <20210303191237.2B2D720E1B@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12645"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 03 21:48:04 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHYPc-0003Aj-0a for ged-emacs-devel@m.gmane-mx.org; Wed, 03 Mar 2021 21:48:04 +0100 Original-Received: from localhost ([::1]:35200 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHYPb-0005EG-1u for ged-emacs-devel@m.gmane-mx.org; Wed, 03 Mar 2021 15:48:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33092) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHYOR-0004LF-Ti for emacs-devel@gnu.org; Wed, 03 Mar 2021 15:46:51 -0500 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]:45931) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHYOP-0001ip-HQ for emacs-devel@gnu.org; Wed, 03 Mar 2021 15:46:51 -0500 X-Originating-IP: 91.129.96.116 Original-Received: from mail.gandi.net (m91-129-96-116.cust.tele2.ee [91.129.96.116]) (Authenticated sender: juri@linkov.net) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 8E4E760007; Wed, 3 Mar 2021 20:46:44 +0000 (UTC) In-Reply-To: (Stefan Monnier's message of "Wed, 03 Mar 2021 15:13:41 -0500") Received-SPF: pass client-ip=217.70.183.195; envelope-from=juri@linkov.net; helo=relay3-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265914 Archived-At: > This is very welcome functionality (and the highlighting as well). > I wonder if we really need the new minor modes, tho, instead of just > sticking to the new `outline-minor-mode-cycle` and > `outline-minor-mode-highlight` variables (which we could make into > `defcustom`s). One example (mostly for demonstration purposes) currently is in etc/compilation.txt. whose Local Variables contains just: ;;; eval: (outline-cycle-highlight-minor-mode) Initially I implemented this only with variables and without modes like you suggested: ;;; outline-minor-mode-cycle: t ;;; outline-minor-mode-highlight: t ;;; eval: (outline-minor-mode 1) But then thought that maybe with a mode would be more concise and convenient. I'm fine with removing these modes after analyzing more use cases. > IOW, I wonder if there are many use cases where users will want to have > some `outline-minor-mode` buffers with cycling and others without. Here's is a list of use cases where I tried to use outline-minor-mode with cycling, and somewhere also with highlighting. 1. (add-hook 'Man-cooked-hook 'outline-cycle-highlight-minor-mode) where manual page sections could be highlighted with outline faces. 2. (add-hook 'diff-mode-hook 'outline-cycle-minor-mode) 3. (add-hook 'emacs-lisp-mode-hook 'outline-cycle-minor-mode) without outline highlighting to not overwrite major mode faces 4. (advice-add 'xref--insert-xrefs :after (lambda (&rest _args) (setq-local outline-regexp "/") (outline-cycle-minor-mode +1))) using file names as headings where S-TAB could provide an overview of all found files But none of them require to disable cycling. I don't know where outline-minor-mode without cycling would be needed. Maybe in external packages that implement own cycling in outline-minor-mode like in https://debbugs.gnu.org/41198#99