From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: master 6458e16: New mode outline-cycle-minor-mode with Orgmode-like TAB cycling on headings Date: Thu, 04 Mar 2021 20:17:28 +0200 Organization: LINKOV.NET Message-ID: <87zgzi69zr.fsf@mail.linkov.net> References: <20210303191236.24697.93201@vcs0.savannah.gnu.org> <20210303191237.2B2D720E1B@vcs0.savannah.gnu.org> <87zgzkug5d.fsf@mail.linkov.net> <9d5801ee-7b73-9312-063e-5cefe227123e@grinta.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33824"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Daniele Nicolodi Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 04 19:49:57 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHt2q-0008hi-Tt for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Mar 2021 19:49:56 +0100 Original-Received: from localhost ([::1]:60218 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHt2q-0006fT-03 for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Mar 2021 13:49:56 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37834) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHsxk-0002i2-Sa for emacs-devel@gnu.org; Thu, 04 Mar 2021 13:44:40 -0500 Original-Received: from relay10.mail.gandi.net ([217.70.178.230]:47619) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHsxi-0007Zk-7l for emacs-devel@gnu.org; Thu, 04 Mar 2021 13:44:40 -0500 Original-Received: from mail.gandi.net (m91-129-96-116.cust.tele2.ee [91.129.96.116]) (Authenticated sender: juri@linkov.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 05255240005; Thu, 4 Mar 2021 18:44:35 +0000 (UTC) In-Reply-To: <9d5801ee-7b73-9312-063e-5cefe227123e@grinta.net> (Daniele Nicolodi's message of "Thu, 4 Mar 2021 18:03:56 +0100") Received-SPF: pass client-ip=217.70.178.230; envelope-from=juri@linkov.net; helo=relay10.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265979 Archived-At: >>> One example (mostly for demonstration purposes) currently is >>> in etc/compilation.txt. whose Local Variables contains just: >>> >>> ;;; eval: (outline-cycle-highlight-minor-mode) >>> >>> Initially I implemented this only with variables and without modes >>> like you suggested: >>> >>> ;;; outline-minor-mode-cycle: t >>> ;;; outline-minor-mode-highlight: t >>> ;;; eval: (outline-minor-mode 1) >>> >>> But then thought that maybe with a mode would be more concise and convenient. > > Can't you add setting the variables to the minor-mode hooks? It's easier to set them using minor-mode like (add-hook 'emacs-lisp-mode-hook 'outline-cycle-highlight-minor-mode) than using lambda (add-hook 'emacs-lisp-mode-hook (lambda () (setq-local outline-minor-mode-cycle t) (setq-local outline-minor-mode-highlight t) (outline-minor-mode 1))) > I haven't tried your code, but there are occasions in which > outline-minor-mode is used to section the buffer on syntactic elements > that are already fontified (on function declarations, for example). What > does happen then when outline-minor-mode-highlight is t? I think these > would be cases in which outline-minor-mode-highlight nil would be better. outline-minor-mode-highlight already works surprisingly well, and doesn't override faces added by major mode.