From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] A Setup package Date: Sun, 14 Mar 2021 17:21:12 +0100 Message-ID: <87zgz5hfk7.fsf@posteo.net> References: <874kis6ots.fsf@posteo.net> <87pn186c5s.fsf@posteo.net> <87blbpk6l8.fsf@posteo.net> <87mtv6j0tf.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19098"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Mar 14 17:22:16 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lLTVQ-0004q2-6K for ged-emacs-devel@m.gmane-mx.org; Sun, 14 Mar 2021 17:22:16 +0100 Original-Received: from localhost ([::1]:48810 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lLTVP-0001t5-5P for ged-emacs-devel@m.gmane-mx.org; Sun, 14 Mar 2021 12:22:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34032) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lLTUU-0001D9-7L for emacs-devel@gnu.org; Sun, 14 Mar 2021 12:21:18 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:53089) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lLTUS-0000wa-3k for emacs-devel@gnu.org; Sun, 14 Mar 2021 12:21:17 -0400 Original-Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 827402400FD for ; Sun, 14 Mar 2021 17:21:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1615738873; bh=nzSM9ihF6oGgCIHUbANprKE+l/FrjW9xlb94p/fUbRE=; h=From:To:Cc:Subject:Date:From; b=CYsUxSBsAT0GsVRmA6aF4WHZ48EGYiLjzqFnYsnJ3LoGD8+l4Uq6g/XperSSnqI9T 6joH6BMr8pu8oK/u+Dy5o0LnVD8g53rF3zCsZcRlYIPVKx35UJyw4OjZCXznDaPw/+ DTiU6iWi9w2KMYcddfqugVCpm5ZPXZIGPz8RpWy2TN7+IB+T6sL4UqqRgfS4v1Bd2x 9hV/VOvFLkt+tD/WLO7sTLYJa8DdV+C/EtuK6unc8GEOmz+tzvggKMyujv44iO2oJr bnaDgrQJBK2rxgBm40opq1Rj0BWLsdAZhUb6P59Gz5G46XjZoG9JOc8lky++ectFHM C3MgLyxguK6Hg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Dz4YN5vZ5z6tmX; Sun, 14 Mar 2021 17:21:12 +0100 (CET) In-Reply-To: (Stefan Monnier's message of "Sun, 14 Mar 2021 11:07:04 -0400") Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266458 Archived-At: Stefan Monnier writes: > OK, we now have: > > http://elpa.gnu.org/devel/setup.html Thank you! > We don't yet have http://elpa.gnu.org/packages/setup.html OTOH because > the 0.1.0 version of the code is missing the copyright changes (the > release is made from the commit in which you bump the version number). > So if you want to make a release based on this code, you'll want to bump > up the version number. What exactly is missing? My understanding was that I had to update the header and the COPYING file. > Here's some other suggestions. I like most of the suggestions, would you mind me committing them with you as the author? > Obviously the use of `help--make-usage` is problematic since the `--` > indicates it's not supposed to be used by "outsiders", so we should > change help.el or help-fns.el to provide a proper function for that > (pcase uses `help-fns--signature` instead, which suffers from the same > problem). Why use help--make-usage at all? Something along the same lines could be simplified (eg. without default values and unused variables) and directly implemented in setup. > (let (specs) > (dolist (name (mapcar #'car setup-macros)) > (let ((body (cond ((eq (get name 'setup-debug) 'none) nil) > ((get name 'setup-debug) nil) > ('(sexp))))) > - (push (if (get name 'setup-repeatable) > + (push (if (plist-get opts :repeatable) This doesn't work! The specification is regenerated for every setup-define call, and if the implicit rest uses opts, all macros will be treated the same way. It might be better to save the specification in a separate variable and modify this destructively for every setup-define call, so as to avoid the overhead of redefining the entire specification all the time. -- Philip K.