From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp defcustoms (Bug#47063) Date: Fri, 26 Mar 2021 15:36:24 +0000 Message-ID: <87zgyq9bbb.fsf@tcd.ie> References: <20210313133546.6042.78482@vcs0.savannah.gnu.org> <20210313133547.AA06C20B2E@vcs0.savannah.gnu.org> <877dma1yfv.fsf@tcd.ie> <87sg4ygmd9.fsf@gmx.de> <87zgz5uc0k.fsf@tcd.ie> <87tup0kxeg.fsf@tcd.ie> <878s6ba96u.fsf@gnus.org> <87k0pu887d.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17061"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , Michael Albinus , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 26 16:37:26 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lPoWc-0004Jc-JR for ged-emacs-devel@m.gmane-mx.org; Fri, 26 Mar 2021 16:37:26 +0100 Original-Received: from localhost ([::1]:35364 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPoWb-0006k1-L2 for ged-emacs-devel@m.gmane-mx.org; Fri, 26 Mar 2021 11:37:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46136) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPoVm-0006Ig-P9 for emacs-devel@gnu.org; Fri, 26 Mar 2021 11:36:34 -0400 Original-Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]:46641) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lPoVh-00029J-Hx for emacs-devel@gnu.org; Fri, 26 Mar 2021 11:36:34 -0400 Original-Received: by mail-wm1-x32e.google.com with SMTP id z6-20020a1c4c060000b029010f13694ba2so3207032wmf.5 for ; Fri, 26 Mar 2021 08:36:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=cv4yxggXH1yAVLsh7N90knfM7nbuLN8pcmnrlKkvPDE=; b=T11T4Z64Rj+Uxi6YHTDiVMd2kDKpZW3F8TWPh2eHUAZjLIuKaR/R5/hEgtFFyp62Z1 N4aT7kujnQVhaGtTnL9vcWOcKgqghdo3fBno4+jcRnDkoFRvFuzJedkghcgWXqDSZ/9u gw6jAT8UvSqObnIw6mm+lNieC3dMSpemU53ONrL5Rslfv6+m/ejqznIM6vssMSu+vPGx ynkUiluuL815vDtWtA56Zv1OaijzSHbCBR23W/O9RGo+9+Rewlt9Z0rr2VUxfBdqVJIg rXiL7sw8CbxAFAZSRGuGEDZlcRCTe1BeQVtdZBuor9Q1330NYULvc3hlY2Z4a329NOTL eJpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=cv4yxggXH1yAVLsh7N90knfM7nbuLN8pcmnrlKkvPDE=; b=hcVieAQahkCEy4Pk3kb6m1RMSqkHDg2S2hFVskdvHqrBINqH4MPMOzLhoHNMwhwrk4 6+H/p0eJc7YDVNlLamFcZSo/MB6dsnXUamD6bMqc9AeA4qTkYj6ate2HaTetWCV1VF+Q //YOgp1YZqjpsE6g/v3ZxHjJW0Bi8h1MDdNNtRoeRUr4ppfMivN+iSa9WJbXBwX+0HmD MJ0uaFKeePxkZwt+WtGPmQdzxPKdKbfaGjNw4ENop51jJTVg92Yugk31CF7+arwmbFZw M6ekaejYpO4Ptn1FQCjlILbN/SqHdwzMaNJpk+v3R/2XMfftzLva5+PzbFeGYUHru6mu iq6w== X-Gm-Message-State: AOAM531idtT5ZtzrIgcjYGz8B6C6aux2ngxW5q30j/DuruCwqprJpRdS qN3voRgEftwuUUv9Z5mk++rYZg== X-Google-Smtp-Source: ABdhPJxryt2o4YYuaLwBb9Mw2q2+3r4QoSjPQMM3qULqtlbVhEsinFllmuS8kUaFh4/sQnCBw5GIpQ== X-Received: by 2002:a1c:68c5:: with SMTP id d188mr13203941wmc.119.1616772986155; Fri, 26 Mar 2021 08:36:26 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:f410:82e8:3a21:eedf]) by smtp.gmail.com with ESMTPSA id 7sm11313235wmk.8.2021.03.26.08.36.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 08:36:25 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Fri, 26 Mar 2021 09:39:54 -0400") Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=contovob@tcd.ie; helo=mail-wm1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267077 Archived-At: Stefan Monnier writes: >> Yup; if it's hoisted out of the loop, there'd be no performance impact, >> but it would make it less useful, though -- as with erroring out, you'd >> get no completion. > > It'd make more sense to just keep the current (not-filtered) completion > list, so you still get completion to work. If we stick with the original patch, then that would mean returning non-nil rather than nil if completion-predicate fails, right? -- Basil