From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp defcustoms (Bug#47063) Date: Fri, 26 Mar 2021 18:18:52 +0000 Message-ID: <87zgyp3hir.fsf@tcd.ie> References: <20210313133546.6042.78482@vcs0.savannah.gnu.org> <20210313133547.AA06C20B2E@vcs0.savannah.gnu.org> <877dma1yfv.fsf@tcd.ie> <87sg4ygmd9.fsf@gmx.de> <87zgz5uc0k.fsf@tcd.ie> <87tup0kxeg.fsf@tcd.ie> <878s6ba96u.fsf@gnus.org> <87k0pu887d.fsf@gnus.org> <87zgyq9bbb.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14820"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , Michael Albinus , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 26 19:22:35 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lPr6Q-0003jN-UG for ged-emacs-devel@m.gmane-mx.org; Fri, 26 Mar 2021 19:22:34 +0100 Original-Received: from localhost ([::1]:52376 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPr6P-0004H8-TG for ged-emacs-devel@m.gmane-mx.org; Fri, 26 Mar 2021 14:22:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58608) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPr2z-00030p-IC for emacs-devel@gnu.org; Fri, 26 Mar 2021 14:19:06 -0400 Original-Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]:36759) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lPr2t-0004lB-RN for emacs-devel@gnu.org; Fri, 26 Mar 2021 14:19:01 -0400 Original-Received: by mail-wr1-x42c.google.com with SMTP id k8so6540534wrc.3 for ; Fri, 26 Mar 2021 11:18:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=F4nuAOn7N9E+cv9a5X72QfCy8ZeDWf+tblCh+OM9cnc=; b=eWRAqpmBdzbAHbiXxN1yaRwl5smK0MIOHiSvAf6oG29nRrNpGElg8l5lekCDCC89kE cSHwvi7Cdf+DfAcURaLgP3F5kwFrSnvYjVcDrSvLkgHFyXgeggFv2OTYsQs0KYoPM+Kv cSvMa/UyR8YBf45RQt/Y1zf1ACaekSCp4Uk/b8cd1uOEX8l+WxBMIjhFN5bJwctiH461 YQeZxin4x0NxKda1AiXq/uPLwKMp0+zR7ijnbaziPZ2puciQ+YgQsr1paueYcS4gaWnh 2yqjjsf7mIlRQw17fqTs4N9tK+9/G1z02ydCzKJRCaKR6YbdCWzXbnFRhuCxyho+2FTS HJJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=F4nuAOn7N9E+cv9a5X72QfCy8ZeDWf+tblCh+OM9cnc=; b=UK+8A5PzVmsB//D2oiG/8rAes2eQvhODDb5/BrlvSSyd/8BebJY2cKMbHFRnzMJTCZ 6/hsTfWMquO/bj22PLUs9NDUC+ql8Tx+rgwt4R7n7N0+L+KST2jlpGAIB0pJo00+QiyK DWpnWAo1XGiqo0cU7Q1HU2Bch9SxP18WLGapxDQVRZLmIfO0ZC0D9M18FKc+CCbuUVlW QhtwWebh5ULsJwG9p1F4piO76vKLg9gl7sqJQG5ApHAlbncOzCd33Aa4xb24OyQMSqcA hiyLzVMvWs8qRl9yRcgtJ46oXt3awVRLBqduvId27oAdBXfbpCZK0xQFTNDagn8a6i2N zmrA== X-Gm-Message-State: AOAM5320U1VAGANLyVRFIZoSE+P6YZ8SYCr8Hwra1Wq/AUnxtsCHTD7p 06ZnKAFmiYpGvGwufeFa7t553w== X-Google-Smtp-Source: ABdhPJyG7RaS1bm95+agqtpS8PI4CZGAbZPOusEFRF9XdHrjXKkpp0sVlwtDwqT82xY2oZdugyXJjA== X-Received: by 2002:adf:e481:: with SMTP id i1mr16391114wrm.63.1616782734275; Fri, 26 Mar 2021 11:18:54 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id y8sm12209152wmi.46.2021.03.26.11.18.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 11:18:53 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Fri, 26 Mar 2021 12:37:59 -0400") Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=contovob@tcd.ie; helo=mail-wr1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267081 Archived-At: Stefan Monnier writes: >>>> Yup; if it's hoisted out of the loop, there'd be no performance impact, >>>> but it would make it less useful, though -- as with erroring out, you'd >>>> get no completion. >>> >>> It'd make more sense to just keep the current (not-filtered) completion >>> list, so you still get completion to work. >> >> If we stick with the original patch, then that would mean returning >> non-nil rather than nil if completion-predicate fails, right? > > I don't think whether we include the command for which the predicate > burped is important: either way is fine. I think including it is slightly better: say 5x5 has a completion-predicate that burps. If this excludes it from completions, then typing M-x 5x5 RET will actually invoke 5x5-crack, which I think is undesirable. > OTOH, it would be preferable if a burping predicate wouldn't prevent > the inclusion of other commands in the completion list. It's probably > tolerable to just prevent completion altogether in case of an error, > but not to prevent `M-x` altogether. I therefore propose we put the safety net around the call to read-extended-command-predicate, with burps having the same effect as if read-extended-command-predicate were nil. This allows both M-x and M-x completion to continue to work, has no discernible performance cost AFAICT, and does not invoke unintended commands. The only downside I can see is that the error message becomes visible in the echo area only after the user has entered some text which matches the burping command (otherwise the error message just gets printed to *Messages*). But that's fine AFAIC. WDYT? -- Basil