From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Simple isearch concerns Date: Wed, 07 Apr 2021 19:24:59 +0300 Organization: LINKOV.NET Message-ID: <87zgya2t7k.fsf@mail.linkov.net> References: <20210403001539.x4rb55dvh46rmhb3.ref@Ergus> <20210403001539.x4rb55dvh46rmhb3@Ergus> <2599ffef-4f70-025c-5f9c-61b9ac94faf8@inventati.org> <87czv7z48f.fsf@mail.linkov.net> <3ec7e2e58ab39455c2c6@heytings.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14396"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Manuel Uberti , emacs-devel@gnu.org, Stefan Monnier , Zhiwei Chen , Daniel =?iso-8859-1?Q?Ma?= =?iso-8859-1?Q?rt=EDn?= To: Gregory Heytings Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Apr 07 18:46:36 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lUBK8-0003dA-Ao for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Apr 2021 18:46:36 +0200 Original-Received: from localhost ([::1]:41050 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUBK7-0006iu-CS for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Apr 2021 12:46:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55920) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUBBr-0008TF-Nt for emacs-devel@gnu.org; Wed, 07 Apr 2021 12:38:03 -0400 Original-Received: from relay12.mail.gandi.net ([217.70.178.232]:44499) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUBBn-0000sg-HL for emacs-devel@gnu.org; Wed, 07 Apr 2021 12:38:03 -0400 Original-Received: from mail.gandi.net (m91-129-107-223.cust.tele2.ee [91.129.107.223]) (Authenticated sender: juri@linkov.net) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 5FE93200003; Wed, 7 Apr 2021 16:37:54 +0000 (UTC) In-Reply-To: <3ec7e2e58ab39455c2c6@heytings.org> (Gregory Heytings's message of "Wed, 07 Apr 2021 10:22:26 +0000") Received-SPF: pass client-ip=217.70.178.232; envelope-from=juri@linkov.net; helo=relay12.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267538 Archived-At: > Okay, I looked a bit closer at multi-isearch, and it seems that the > attached patch works with mutli-isearch, too. > > + ;; Terminate the search if point has moved to another buffer. > + (unless (eq isearch--current-buffer (current-buffer)) > + (with-current-buffer isearch--current-buffer (isearch-exit))) When in your original test case '(pop-to-buffer "*Occur*")' is replaced with '(kill-current-buffer)': (define-key isearch-mode-map (kbd "M-s o") #'(lambda () (interactive) (call-interactively 'isearch-occur) (kill-current-buffer))) then it fails with: Error in post-command-hook (isearch-post-command-hook): (error "Selecting deleted buffer") All other uses of 'isearch--current-buffer' have a check for a live buffer, e.g. (unless (eq (current-buffer) isearch--current-buffer) (when (buffer-live-p isearch--current-buffer) (with-current-buffer isearch--current-buffer