From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] When deleting in bookmark menu, prompt for confirmation. Date: Wed, 05 May 2021 16:43:51 -0500 Message-ID: <87zgx8svoo.fsf@red-bean.com> References: <87a6pcqy7s.fsf@red-bean.com> <83czu86o46.fsf@gnu.org> <835z006jpl.fsf@gnu.org> <87im3z3f8f.fsf@red-bean.com> <83zgxb67g2.fsf@gnu.org> <87mtt9sqh4.fsf@red-bean.com> <83wnsd2y37.fsf@gnu.org> Reply-To: Karl Fogel Mime-Version: 1.0 Content-Type: text/plain; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40175"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 05 23:45:53 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lePL6-000AIZ-UD for ged-emacs-devel@m.gmane-mx.org; Wed, 05 May 2021 23:45:52 +0200 Original-Received: from localhost ([::1]:57576 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lePL5-00081p-W4 for ged-emacs-devel@m.gmane-mx.org; Wed, 05 May 2021 17:45:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47066) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lePJE-0006fG-8P for emacs-devel@gnu.org; Wed, 05 May 2021 17:43:56 -0400 Original-Received: from sanpietro.red-bean.com ([45.79.25.59]:37252) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lePJB-00065q-OF; Wed, 05 May 2021 17:43:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=red-bean.com; s=202005newsp; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:Reply-To:References:Subject:Cc:To:From:Sender: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3M9KxIN/hGiBapp4GSZdD6XDu5EZlx0gbEUUWFUR5t0=; t=1620251032; x=1621460632; b=OGeYefxY+jLenr+BgrX3qH76HwLS1c30TD1WhTkgzzR4WXQfLLMMGpCEYFTLHlOKBwDFkkxvKF zm3QmUAdtCIcsGc3gvJqGXPHu9+kvJtsf9hZZZ7muXVflc7yDxCIjJxnrA3kidwysWK54yGTIQAil 6C371Xze6HVyQBVDOM9vajJ1GbZnxln+wgX9mX85I4TfwSubi3FsAwzClg31V/EdQRXnJJtjYmt8E sd11bxynYzTdFgjw+y0uIpHNA0/aNtLxOLS/TI3k+3FWtQ452TK0kOYSE0Bp0+gIYBKpJYPO3dFau i69bgH+FsXoUSlr0eJ4j71G9TFPxzOaosGalA==; Original-Received: from [12.106.183.66] (port=10420 helo=kwork) by sanpietro.red-bean.com with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lePJA-0007eo-6F; Wed, 05 May 2021 21:43:52 +0000 In-Reply-To: <83wnsd2y37.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 05 May 2021 14:56:28 +0300") Received-SPF: pass client-ip=45.79.25.59; envelope-from=kfogel@red-bean.com; helo=sanpietro.red-bean.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268938 Archived-At: On 05 May 2021, Eli Zaretskii wrote: >> From: Karl Fogel >> Date: Wed, 05 May 2021 00:24:07 -0500 >> >> Revised patch attached, with the option now defaulting to nil >> (i.e., to the old behavior) as per discussion. Review/comments >> welcome. > >Thanks, LGTM, modulo Lars's comments (with which I agree) about >the >doc string. Committed (b8bdf6437712), with doc string fixed as per Lars. Best regards, -Karl