From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [WIP PATCH] Controlling Isearch from the minibuffer Date: Sun, 09 May 2021 22:09:20 +0300 Organization: LINKOV.NET Message-ID: <87zgx3n2qn.fsf@mail.linkov.net> References: <87zgx5cz33.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17205"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Augusto Stoffel , emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 09 21:18:32 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lfowi-0004Mk-8I for ged-emacs-devel@m.gmane-mx.org; Sun, 09 May 2021 21:18:32 +0200 Original-Received: from localhost ([::1]:38398 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lfowh-0002qG-7M for ged-emacs-devel@m.gmane-mx.org; Sun, 09 May 2021 15:18:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52058) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfov9-0000ny-Ij for emacs-devel@gnu.org; Sun, 09 May 2021 15:16:55 -0400 Original-Received: from relay10.mail.gandi.net ([217.70.178.230]:40223) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfov7-0001a9-It for emacs-devel@gnu.org; Sun, 09 May 2021 15:16:55 -0400 Original-Received: from mail.gandi.net (m91-129-102-166.cust.tele2.ee [91.129.102.166]) (Authenticated sender: juri@linkov.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 85611240003; Sun, 9 May 2021 19:16:48 +0000 (UTC) In-Reply-To: (Alan Mackenzie's message of "Sun, 9 May 2021 13:36:56 +0000") Received-SPF: pass client-ip=217.70.178.230; envelope-from=juri@linkov.net; helo=relay10.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269095 Archived-At: >> What do you think? > > The patch is ~500 lines long. This makes me worried. I'm afraid I can > only react negatively and defensively at the moment. This is what worried me too. But hopefully the patch could be reduced to just ~10 lines when using the same approach how you implemented isearch-allow-scroll when isearch-pre-command-hook allows to scroll, then isearch-post-command-hook checks the post-conditions. So I recommended Augusto the same solution.