From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations Date: Mon, 24 May 2021 02:37:02 +0300 Organization: LINKOV.NET Message-ID: <87zgwlnhsx.fsf@mail.linkov.net> References: <87zgwlb4xc.fsf@gmail.com> <617d06ca-27bf-2ae8-26eb-1042123499d3@daniel-mendler.de> <87pmxhb1rs.fsf@gmail.com> <23510125-37b9-e87e-3590-5322f44772ce@daniel-mendler.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14001"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: =?iso-8859-1?Q?Jo=E3o_T=E1vora?= , monnier@iro.umontreal.ca, "emacs-devel@gnu.org" To: Daniel Mendler Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 24 01:49:35 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lkxqh-0003Xg-0W for ged-emacs-devel@m.gmane-mx.org; Mon, 24 May 2021 01:49:35 +0200 Original-Received: from localhost ([::1]:43166 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lkxqg-0004n7-2q for ged-emacs-devel@m.gmane-mx.org; Sun, 23 May 2021 19:49:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51364) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lkxpl-0003Rc-SU for emacs-devel@gnu.org; Sun, 23 May 2021 19:48:37 -0400 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]:54487) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lkxph-0006R6-Bk for emacs-devel@gnu.org; Sun, 23 May 2021 19:48:37 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 2BE5BE0003; Sun, 23 May 2021 23:48:28 +0000 (UTC) In-Reply-To: <23510125-37b9-e87e-3590-5322f44772ce@daniel-mendler.de> (Daniel Mendler's message of "Sun, 23 May 2021 23:31:54 +0200") Received-SPF: pass client-ip=217.70.183.196; envelope-from=juri@linkov.net; helo=relay4-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269722 Archived-At: >>> I would also be happy with an extension to the `annotation-function`, >>> where the returned annotation string is the suffix and can be >>> propertized with an additional string for the prefix. >> >> Either that, or it could return a list instead of a string, and then the >> list would be interpreted as "affixation function" results. > > A list return value is not a good idea since that does not allow to > write forward and backward compatible code. This is actually an > advantage of the `affixation-function`. It is a non-intrusive addition. > The same holds for the recently added `group-function`, which I proposed. I agree. > If it is decided to change this, I think it would be best to use text > properties for this. The `annotation-function` should continue to return > suffix strings and additionally, each suffix has an `annotation-prefix` > text property attached. That would be a more minimal API change than the > addition of the `affixation-function`, while still being fully compatible. Such ad-hoc thing as attaching an `annotation-prefix` text property on each suffix doesn't look like a real alternative to the clean API interface provided by `affixation-function`.