From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sergey Organov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Re: Should (buffer-list) ever return killed buffers? Date: Mon, 24 May 2021 17:25:22 +0300 Message-ID: <87zgwkyzsd.fsf@osv.gnss.ru> References: <87wnrpujo0.fsf@osv.gnss.ru> <871r9w5jws.fsf_-_@osv.gnss.ru> <87eedwdy7v.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24029"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Tassilo Horn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 24 16:27:34 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llBYL-00063q-Vk for ged-emacs-devel@m.gmane-mx.org; Mon, 24 May 2021 16:27:33 +0200 Original-Received: from localhost ([::1]:40376 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llBYK-0004u8-V6 for ged-emacs-devel@m.gmane-mx.org; Mon, 24 May 2021 10:27:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41690) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llBWJ-0007zH-IU for emacs-devel@gnu.org; Mon, 24 May 2021 10:25:27 -0400 Original-Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]:45613) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1llBWH-00012A-O5; Mon, 24 May 2021 10:25:27 -0400 Original-Received: by mail-lf1-x136.google.com with SMTP id j10so40893094lfb.12; Mon, 24 May 2021 07:25:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=h0D7ZoCLVKlnIWRPt5hoIk9i80naQwHqci1tfiDDCsU=; b=J9WlhjIFfXb2oWLQm0eRi7vDSmavKHom+ZT2iSOE0TWFrEMrxJgz7rRMOQFxkiaFdP 3gbDxgSdH5aOEKrPzCVcBr7mpeIqlgvV0XVD3awVEEs64JQ9uDXANX5GTmYtmIVX2/Av z2AxmVkXUPfvnZig3u9vtMeoxdaOf1Dzd/c38Hy4blRsmE/edoePdbAa9a6JU/8h54Hw Xv9CqDyJXG5tdlS+c+/JDJlTFUFOQG550jyt5ob2mndcoV8MqR4T82h5ZNktCNhMoCtW /jaQxZYOJnjkr/5QEmf5M5DKcACD+O+DCn/KtSBgFKLNznWVYuCxrifKZirlCSqlxLu5 Ipvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=h0D7ZoCLVKlnIWRPt5hoIk9i80naQwHqci1tfiDDCsU=; b=r9gToec1vPZcg6H67+mvBFQLibFhg36QvsuGAVEKDK/zE0Zju4EI4cRhmVk+N3aLzQ ITdJP87DdzmY1JBYNbCgUI2MMQLHA6D/4/RaHsV3i4EQ4aOGymFjDvB0Wt/SfRJ5M+Kk nQhMFveWMOGStOZq7X5+P3dME+aLzRFYwkIyd/hQIFMwFXOoLdhfC4fDLCp4mWvyfatp 0AQ+Xcc3YWDebwvJkLnYBkQ5HZLQVh/Hetmu051efwUshoJoGTxBT4uCAjbgNkqtJvMh rTkQ8ujeQ38yMVzsptZrmjtzAdr1nBUuDzFSn3B5YZ+e9kwE5cdag4EaFtpp9WOksPlB SdiQ== X-Gm-Message-State: AOAM530DzZH/dq33F/SN72AstPnPXYNrR2B0YLpTMB1eCwn5x80bFJRL F3LANswgn0OIcE95VYdY3muhqpOHHs0= X-Google-Smtp-Source: ABdhPJytqnxtK3Y4lzklbXfo1St6tykPhAaD8Ljl+gSA0cvst6gVW0qVW5539Dxn9NW8vsbz5YCnwA== X-Received: by 2002:ac2:410e:: with SMTP id b14mr10666694lfi.56.1621866323206; Mon, 24 May 2021 07:25:23 -0700 (PDT) Original-Received: from osv.localdomain ([89.175.180.246]) by smtp.gmail.com with ESMTPSA id o20sm1436632lfu.283.2021.05.24.07.25.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 May 2021 07:25:22 -0700 (PDT) In-Reply-To: <87eedwdy7v.fsf@gnu.org> (Tassilo Horn's message of "Mon, 24 May 2021 16:04:04 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::136; envelope-from=sorganov@gmail.com; helo=mail-lf1-x136.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269758 Archived-At: Tassilo Horn writes: > Sergey Organov writes: > >> OK, here is a patch that fixes the issue: >> >> lisp/desktop.el: check for killed buffers in desktop-clear >> >> diff --git a/lisp/desktop.el b/lisp/desktop.el >> index fb7c6c79a1..20d9e0f268 100644 >> --- a/lisp/desktop.el >> +++ b/lisp/desktop.el >> @@ -706,7 +706,8 @@ if different)." >> "\\)\\'"))) >> (dolist (buffer (buffer-list)) >> (let ((bufname (buffer-name buffer))) >> - (unless (or (eq (aref bufname 0) ?\s) ;; Don't kill internal buffers >> + (unless (or (nill bufname) > ^^^^ > > That should most probably be `null'. Yep, sorry for messing it while re-typing from working code! Thanks, -- Sergey