From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: scratch/ns/refactor 06d9e72 5/6: Move NS port toolbar handling to the window Date: Thu, 24 Jun 2021 15:58:40 +0200 Message-ID: <87zgvfqs8f.fsf@gmail.com> References: <20210620155625.12886.44156@vcs0.savannah.gnu.org> <20210620155629.258B620B76@vcs0.savannah.gnu.org> <87h7hosqob.fsf@gmail.com> <874kdosk69.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35320"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Alan Third Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 24 15:59:30 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lwPtC-0008wl-5Z for ged-emacs-devel@m.gmane-mx.org; Thu, 24 Jun 2021 15:59:30 +0200 Original-Received: from localhost ([::1]:44880 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lwPtB-0008Sr-5c for ged-emacs-devel@m.gmane-mx.org; Thu, 24 Jun 2021 09:59:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50518) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lwPsV-0007e4-6E for emacs-devel@gnu.org; Thu, 24 Jun 2021 09:58:47 -0400 Original-Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]:47038) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lwPsT-0006wm-Kj for emacs-devel@gnu.org; Thu, 24 Jun 2021 09:58:46 -0400 Original-Received: by mail-wr1-x429.google.com with SMTP id a11so6761522wrt.13 for ; Thu, 24 Jun 2021 06:58:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:gmane-reply-to-list:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=jGU3yyh2mFEeX/nyyVIAzqXU1LZ6e95EONgfPeim7BU=; b=Nv4wSNA381FfFVSAdoR8qZq+YA87NBM+pIfkoYk6YimQq8+LEK9bPVJuQDqO4PdaVC eER6sVQ2GXdxPMHxZS1s+0DhzFz0iR8bRde2hUPdAfHgCpnLVGF1z4XQITH5cqi0gmFU v6s9Yh4oZHj3A3ttAVA1Qc2+lrBVkVXUjJuYhcFDBSVqvuLJm6zqzNev79iPT0rKyce0 sgG3c+bbfosdanKxmz+qk6LUaMjlpMB3NDHoSs++JS9v0q62WxNqoAMs+9+3bJZv6B7d ZI5VO0WawTNFa7CVCP7qM64h3Yp990TLZ95Re3tqTIqN0ep/TCP4oLpSfQbesI+yaufe 1slQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=jGU3yyh2mFEeX/nyyVIAzqXU1LZ6e95EONgfPeim7BU=; b=B264TDW0Yh73NhUCm+h2kpkm0Kh7Dt9ooLyIacTB+KNMSbxyPYzLsskCF5bS5SXtG0 EEvjU/1DUvCUNZArwbrPNHMTdtzoYNV/h1hMhUNYImKC3C/us0wTgVMc9Dvd7bFKlN03 BSn+5mKC/Ef0z8mlvlyloKY3/BWu2wdLDbxHV6Ma2HjyQ/EwfPP3wOUhodCvoHhtepXk ezxncM1obqympwW1KK+dVclohC5tvQkRPjJfr75FijM6CJUUe4J0iOjjMthv7ysDzOYF VoPl58ILyBSll/dP2bJsvXVs59eAE1NbaZO7CkbtCvA9n0zw6aXVraB/VQYdJ9Ak8bZM 89Uw== X-Gm-Message-State: AOAM530wCZzLPnysPUM5/bI64Yp8ERPVKzmaeF2/ZsypT+mtE1Y/6wnC +TpJWpu6jY2p2RjvlFS5LsBNOZB7gdo= X-Google-Smtp-Source: ABdhPJx5MUnMy/KNLGY1NiAtxK8Q63KkfrGmkC9vRbAzaHyZBKJ5+NHL1Ga/xIDfDktU4NfieFcyMw== X-Received: by 2002:a5d:50ce:: with SMTP id f14mr4590662wrt.259.1624543123736; Thu, 24 Jun 2021 06:58:43 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id e17sm3911178wre.79.2021.06.24.06.58.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Jun 2021 06:58:41 -0700 (PDT) Gmane-Reply-To-List: yes In-Reply-To: (Alan Third's message of "Wed, 23 Jun 2021 17:06:12 +0100") Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=rpluim@gmail.com; helo=mail-wr1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270997 Archived-At: >>>>> On Wed, 23 Jun 2021 17:06:12 +0100, Alan Third said: Alan> On Wed, Jun 23, 2021 at 04:57:34PM +0200, Robert Pluim wrote: >> >>>>> On Wed, 23 Jun 2021 15:27:42 +0100, Alan Third said: >> >> The second frame has the tool-bar disabled, but unlike master the >> >> frame height is greater than the initial frame, and the frame tit= le is >> >> bigger as well, as if its height had not been adjusted after remo= ving >> >> the tool-bar. >>=20 Alan> What's happening is that the toolbar is set to be visible, but it= has Alan> nothing in it, so it shrinks to the toolbar's minimum height. >>=20 Alan> Can you please try the following, I think it should sort it: >>=20 >> You=CA=BCre on a roll here Alan. That fixes it. Alan> I've pushed a fix if you want to give it a go. Alan> Plus another couple of patches which probably break something els= e. I guess that using the menus being dodgy when displaying a tramp-visited buffer is normal? Emacs appears to be busy-looping, I can provide backtrace if you want. I never use the menus, so it=CA=BCs not a big deal to me. Robert --=20