unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: Alan Third <alan@idiocy.org>
Cc: emacs-devel@gnu.org
Subject: Re: scratch/ns/refactor 06d9e72 5/6: Move NS port toolbar handling to the window
Date: Thu, 24 Jun 2021 15:58:40 +0200	[thread overview]
Message-ID: <87zgvfqs8f.fsf@gmail.com> (raw)
In-Reply-To: <YNNb9H/b+2VKSsnU@idiocy.org> (Alan Third's message of "Wed, 23 Jun 2021 17:06:12 +0100")

>>>>> On Wed, 23 Jun 2021 17:06:12 +0100, Alan Third <alan@idiocy.org> said:

    Alan> On Wed, Jun 23, 2021 at 04:57:34PM +0200, Robert Pluim wrote:
    >> >>>>> On Wed, 23 Jun 2021 15:27:42 +0100, Alan Third <alan@idiocy.org> said:
    >> >> The second frame has the tool-bar disabled, but unlike master the
    >> >> frame height is greater than the initial frame, and the frame title is
    >> >> bigger as well, as if its height had not been adjusted after removing
    >> >> the tool-bar.
    >> 
    Alan> What's happening is that the toolbar is set to be visible, but it has
    Alan> nothing in it, so it shrinks to the toolbar's minimum height.
    >> 
    Alan> Can you please try the following, I think it should sort it:
    >> 
    >> Youʼre on a roll here Alan. That fixes it.

    Alan> I've pushed a fix if you want to give it a go.

    Alan> Plus another couple of patches which probably break something else.

I guess that using the menus being dodgy when displaying a
tramp-visited buffer is normal? Emacs appears to be busy-looping, I
can provide backtrace if you want.

I never use the menus, so itʼs not a big deal to me.

Robert
-- 



  reply	other threads:[~2021-06-24 13:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210620155625.12886.44156@vcs0.savannah.gnu.org>
     [not found] ` <20210620155629.258B620B76@vcs0.savannah.gnu.org>
2021-06-23 12:37   ` scratch/ns/refactor 06d9e72 5/6: Move NS port toolbar handling to the window Robert Pluim
2021-06-23 14:27     ` Alan Third
2021-06-23 14:57       ` Robert Pluim
2021-06-23 16:06         ` Alan Third
2021-06-24 13:58           ` Robert Pluim [this message]
2021-06-24 14:05             ` Alan Third
2021-06-24 14:07               ` Alan Third
2021-06-24 14:15                 ` Robert Pluim
2021-06-24 14:16                   ` Alan Third
2021-06-24 14:32                   ` Alan Third
2021-06-24 14:59                     ` Robert Pluim
2021-06-24 14:11               ` Robert Pluim
     [not found] ` <20210620155628.D095320B76@vcs0.savannah.gnu.org>
2021-06-23 13:33   ` scratch/ns/refactor cc9dbaf 4/6: Fix macOS live resize drawing Robert Pluim
2021-06-23 14:05     ` Alan Third
2021-06-23 14:32       ` Robert Pluim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zgvfqs8f.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=alan@idiocy.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).