From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: PR: dired-do-create-files now checks for trailing slashes in the target Date: Wed, 29 Sep 2021 15:23:39 +0200 Message-ID: <87zgrv33mf.fsf@gnu.org> References: <831r58k0cx.fsf@gnu.org> <87tui4qyni.fsf@gnu.org> <83tui4iift.fsf@gnu.org> <874ka43rp1.fsf@gnu.org> <83ee97il43.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31789"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.7.0; emacs 28.0.50 Cc: rudiwillalwaysloveyou@gmail.com, stefankangas@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 29 15:39:45 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mVZoG-000858-Or for ged-emacs-devel@m.gmane-mx.org; Wed, 29 Sep 2021 15:39:44 +0200 Original-Received: from localhost ([::1]:53016 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVZoF-0001SE-N8 for ged-emacs-devel@m.gmane-mx.org; Wed, 29 Sep 2021 09:39:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46942) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVZlM-0004j6-Us for emacs-devel@gnu.org; Wed, 29 Sep 2021 09:36:47 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56916) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVZlM-00018s-NO; Wed, 29 Sep 2021 09:36:44 -0400 Original-Received: from auth2-smtp.messagingengine.com ([66.111.4.228]:33743) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVZlL-0005aQ-Od; Wed, 29 Sep 2021 09:36:43 -0400 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailauth.nyi.internal (Postfix) with ESMTP id 6B82C27C0060; Wed, 29 Sep 2021 09:36:43 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 29 Sep 2021 09:36:43 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudekvddgieegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvufffjgfkgggtsehttdertddtredtnecuhfhrohhmpefvrghsshhi lhhoucfjohhrnhcuoehtshguhhesghhnuhdrohhrgheqnecuggftrfgrthhtvghrnhepve evieekteekveeigfefffeivdetgeduvdffueeuudevgedttdehvdfhueevfffhnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhrnhdomh gvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqkeeijeefkeejkeegqdeifeehvdel kedqthhsughhpeepghhnuhdrohhrghesfhgrshhtmhgrihhlrdhfmh X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 29 Sep 2021 09:36:42 -0400 (EDT) In-reply-to: <83ee97il43.fsf@gnu.org> X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275791 Archived-At: Eli Zaretskii writes: Hi Eli, >> > because if the user types >> > >> > R /new_ TAB >> > >> > Emacs will complete it to "/new_name/", including the trailing slash. >> >> But only if it exists, and then the patch makes no difference in >> behavior. > > Isn't that exactly the problem? If both old_name and new_name exist, > how do I rename old_name into new_name so that it overwrites new_name > instead of becoming its subdirectory? I must carefully type new_name > RET so as to avoid having a slash at its end. That's already the case without this patch and emacs 27.2 started with "emacs -Q". I have both foo and bar directories in my dired buffer, then hit R on foo and complete bar/. It will move foo inside of bar. The very same happens if I just complete to bar without trailing /. IMHO, that makes sense because you usually don't want to rename a directory so that it gets a name which already exists. And its also consistent with "mv" from GNU coreutils 9.0 where "mv foo bar" also moves foo into bar if both exist and at least bar is a directory. That makes the proposed patch a very natural extension of what we already have, i.e., it just ensures `dired-create-destination-dirs' is obeyed. > I would support such a change only if it had an explicit defcustom to > control it. (It could be a new value of > dired-create-destination-dirs, if that makes sense.) I disagree based on above observations. Is the behavior different on Windows? Bye, Tassilo