From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Aleksandr Vityazev Newsgroups: gmane.emacs.devel Subject: [ELPA/oauth2] Sometimes oauth2-refresh-access does not work correctly Date: Wed, 17 Nov 2021 14:36:13 +0000 Message-ID: <87zgq26e8y.fsf@posteo.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7409"; mail-complaints-to="usenet@ciao.gmane.io" To: emacs-devel@gnu.org, julien@danjou.info Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 17 16:00:32 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mnMQI-0001dG-Vy for ged-emacs-devel@m.gmane-mx.org; Wed, 17 Nov 2021 16:00:31 +0100 Original-Received: from localhost ([::1]:50398 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mnMQH-0000wK-QW for ged-emacs-devel@m.gmane-mx.org; Wed, 17 Nov 2021 10:00:29 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54550) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnM2j-0004Sq-8b for emacs-devel@gnu.org; Wed, 17 Nov 2021 09:36:09 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]:57709) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnM2d-0007Pu-GW for emacs-devel@gnu.org; Wed, 17 Nov 2021 09:36:07 -0500 Original-Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id C2BD0240106 for ; Wed, 17 Nov 2021 15:35:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.org; s=2017; t=1637159758; bh=YjosxbBVM2law4a5LI+rMi8ImV0LEwDvUkBTdgz04as=; h=From:To:Subject:Date:From; b=ap8Oy6dMCbfbLoCommcJf3yLKIorrJZvysHylbpcaXnY/vqOL1OLJ3HgaNFlBckPs DxaWoF9CsV3Il/1g5bWsN1srHQhpyrZNSvfvX4pGEL/Xgn+VhlSH+a6GfH0Rybcpak uUXMfHp6iX76qwM2uHpnEh9xwPVwtQxfWd6nkA5yeF9BmcgjyjHl0z8kgbPd4/Xw/W ctEG72ckYxZT6CyHWGacLp6YgdQMIQdCSbNk5fABxvN4znqbG2n1/UvKH63XdBgdns iHcB5f/DJvkZmiopvX/6IpLhBOBI1sXmeCcHCfnCYd5fo2qogjsFn4tQuW8n4IMIGE 9sUCzEBwASDEQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4HvQTT0wGtz9rxM; Wed, 17 Nov 2021 15:35:56 +0100 (CET) Received-SPF: pass client-ip=185.67.36.66; envelope-from=avityazev@posteo.org; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 17 Nov 2021 09:58:42 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:279635 Archived-At: Hello, thank you for maintaining such a wonderful package! While working on my own package, I found that oauth2 cannot properly handle the situation where the refresh_token changes every time I refresh the access. If I use plsore to store the token, I can only update the token once, and after that I have to delete plstore to get new access. Can you add a refresh_token change check to the 'oauth2-refresh-access' function? And if there are changes, then update the refresh-token and access-response fields as well as the access-token. -- Best regards, Aleksandr Vityazev