From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: "Can't find Hunspell dictionary" error (was Re: Emacs pretest 28.0.91 is out) Date: Thu, 13 Jan 2022 11:20:05 +0100 Message-ID: <87zgo02azu.fsf@gmail.com> References: <5c74e0fb4c651733c0d8072f7cd40d06@webmail.orcon.net.nz> <878rvk3tw8.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28387"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Stefan Kangas , emacs-devel@gnu.org To: Phil Sainty Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jan 13 11:22:26 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n7xFS-0007F0-8f for ged-emacs-devel@m.gmane-mx.org; Thu, 13 Jan 2022 11:22:26 +0100 Original-Received: from localhost ([::1]:51164 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n7xFP-0001ec-MH for ged-emacs-devel@m.gmane-mx.org; Thu, 13 Jan 2022 05:22:24 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:44590) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7xDK-0000Um-AC for emacs-devel@gnu.org; Thu, 13 Jan 2022 05:20:14 -0500 Original-Received: from [2a00:1450:4864:20::332] (port=33668 helo=mail-wm1-x332.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n7xDI-00075q-Nb; Thu, 13 Jan 2022 05:20:13 -0500 Original-Received: by mail-wm1-x332.google.com with SMTP id o7-20020a05600c510700b00347e10f66d1so2398734wms.0; Thu, 13 Jan 2022 02:20:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:gmane-reply-to-list:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=KM0xDSa5P3kMbNi4sZjyyGk1NOp/QvipvUUb02FLf5w=; b=W7g5x/r0B0M/cjLMXp0qJkowPzOM3BDoY/gJT4hzPt2HeD8ADFDa6AqFnr5QTn0IGC a05hH6Eypv4/cG5Pd+LIH8De2+eHCIVPwZoUvnaxXnigpgOkGBWI7wX/D0CRj6donel7 JDyklAgvrIoPXgKPr9HQQsS5CL+4m7EpJjahY5fWLSvLU4XYLrPdMKycwqsVvUblEZf2 iCKImpaNjDXje52r2PicQZAalipsEc/4c/x1tqGuMQdl1Qz2DOolaFEN9UldW7udKYw3 +EC5pfUZnapa2BScTRS3D6JonvWMBXp0OGhDVTn7yaWygWlpckNprdSycXODw7qsAXpu b8Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=KM0xDSa5P3kMbNi4sZjyyGk1NOp/QvipvUUb02FLf5w=; b=CP8EpwySU9pa4TPzjo2Xc28i5fi0vyR489svXhbpLmEiwrnK6BKnBIQXBe5Ygmp71w WtJ7BDUk2MfqL0hq+BkdRb5IBeeojugxG+02V15/gw9UeM0cab9bkIepy2mUu9jRlSQ1 /U2ELTQ25qVJ4WBVM6hg6ttwbFfyx0AuPeGkr44pl/Q3AOM3/BJ+2fYlIGRA7yYsX8HN LwS4jGh8u5d5rk4aeIyX3UW6GMVoV8v5e92tjuYZ+aqAgOrZmmj7GkyryuXJQ2vWYrWt muDHc2vwhj4bow49+E1nI9aQOAVE5eGSGGN9e3veNOWayzJuZP2X+l2mzGoDdxBabyPR SnwA== X-Gm-Message-State: AOAM532GSwfmyWR0Ca0eTata+ZabGlo07v9BVzPCcDv+IYM0S9/Ul+wV 7EegVBnuZLCaHBWyWGPTfcGBXvrTK8E= X-Google-Smtp-Source: ABdhPJwuxyK/3foJGTIvh3Dyc2nIiJdRmj+LeZk7rEsLT5ARhNXHHMD0YYIsE84J8HDhcI5zYttnpQ== X-Received: by 2002:a05:600c:a10:: with SMTP id z16mr3145599wmp.120.1642069206927; Thu, 13 Jan 2022 02:20:06 -0800 (PST) Original-Received: from rltb ([2a01:e0a:3f3:fb50:da2c:6e12:f0db:3a30]) by smtp.gmail.com with ESMTPSA id r7sm9159245wmq.18.2022.01.13.02.20.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jan 2022 02:20:06 -0800 (PST) Gmane-Reply-To-List: yes In-Reply-To: <878rvk3tw8.fsf@gmail.com> (Robert Pluim's message of "Thu, 13 Jan 2022 09:46:31 +0100") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::332 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=rpluim@gmail.com; helo=mail-wm1-x332.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284696 Archived-At: >>>>> On Thu, 13 Jan 2022 09:46:31 +0100, Robert Pluim s= aid: >>>>> On Thu, 13 Jan 2022 20:51:50 +1300, Phil Sainty said: Phil> Eli Zaretskii wrote: >>> > From: Robert Pluim >>> > Debugger entered--Lisp error: (error "Can't find Hunspell diction= ary with a >>> > .aff affix f...") >>> > signal(error ("Can't find Hunspell dictionary with a .aff affix= f...")) >>> > error("Can't find Hunspell dictionary with a .aff affix f...") >>> > ispell-find-hunspell-dictionaries() >>> > ispell-set-spellchecker-params() >>> > ispell-valid-dictionary-list() >>> > >>> > This is because I have no hunspell dictionaries at all >>> So you want to fix this? I don't mind, but since it's (AFAIU) >>> something specific to your installation, is it important to fix on >>> the release branch? Phil> While unexpected, it doesn't seem *invalid* to have no dictionari= es Phil> installed, so I think it's weird that `ispell-valid-dictionary-li= st' Phil> triggers (indirectly) an error in this scenario to essentially say Phil> "there were no valid dictionaries", when that's also what a nil r= eturn Phil> value would have meant. Phil> `ispell-valid-dictionary-list' or `ispell-set-spellchecker-params' Phil> should perhaps use `with-demoted-errors' to avoid this? Robert> Perhaps Phil> Failing that, I think guarding against this in spelling-tests.el = with Phil> `ignore-errors' makes sense. It's an :unstable test, but it shou= ldn't Phil> be triggering actual errors. It=CA=BCs an unstable test, and when you actually run it, it fails 100% of the time, whether your ispell/aspell/hunspell installation is correct or not. Fixed on master. Robert> It=CA=BCs not the test that=CA=BCs triggering errors, it=CA=BCs= the check to see if Robert> the test should be defined at all. I=CA=BCll take a look at fix= ing that and Robert> ispell-valid-dictionary-list on master. Wrapping the test in `ignore-errors' is easy. Of the three dictionary listing functions, the one for hunspell is the only one that signals an error, so maybe it should just log a message instead? Robert --=20