* Re: master c3e064013e: (loadhist_initialize): Minor refactoring [not found] ` <20220219191223.AD5F7C00894@vcs2.savannah.gnu.org> @ 2022-02-20 16:25 ` Lars Ingebrigtsen 2022-02-20 18:17 ` Stefan Monnier 0 siblings, 1 reply; 3+ messages in thread From: Lars Ingebrigtsen @ 2022-02-20 16:25 UTC (permalink / raw To: emacs-devel; +Cc: Stefan Monnier Stefan Monnier via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes: > (loadhist_initialize): Minor refactoring > > Consolidate a bit of code. > > * src/lread.c (loadhist_initialize): New function. > (Fload, readevalloop): Use it. It seems like this makes a number of tests fail: bin/bash: line 3: 3621759 Aborted HOME=/nonexistent LANG=C EMACS_TEST_DIRECTORY=/home/larsi/src/emacs/trunk/test "../src/emacs" --module-assertions --no-init-file --no-site-file --no-site-lisp -L ":." -l ert -l lisp/emacs-lisp/gv-tests --batch --eval '(ert-run-tests-batch-and-exit (quote (not (or (tag :expensive-test) (tag :unstable)))))' > lisp/emacs-lisp/gv-tests.log 2>&1 Running 8 tests (2022-02-20 17:21:24+0100, selector ‘(not (or (tag :expensive-test) (tag :unstable)))’) lread.c:1175: Emacs fatal error: assertion failed: STRINGP (filename) make[3]: *** [Makefile:184: lisp/emacs-lisp/gv-tests.log] Error 134 make[3]: Leaving directory '/home/larsi/src/emacs/trunk/test' make[2]: [Makefile:341: check-doit] Error 2 (ignored) SUMMARY OF TEST RESULTS ----------------------- Files examined: 395 Ran 5965 tests, 158 failed to run, 5835 results as expected, 0 unexpected, 130 skipped 5 files did not finish: src/lread-tests.log lisp/simple-tests.log lisp/emacs-lisp/gv-tests.log lisp/emacs-lisp/edebug-tests.log lisp/emacs-lisp/cl-generic-tests.log This is with --with-native-compilation, if that makes a difference. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master c3e064013e: (loadhist_initialize): Minor refactoring 2022-02-20 16:25 ` master c3e064013e: (loadhist_initialize): Minor refactoring Lars Ingebrigtsen @ 2022-02-20 18:17 ` Stefan Monnier 2022-02-20 18:21 ` Lars Ingebrigtsen 0 siblings, 1 reply; 3+ messages in thread From: Stefan Monnier @ 2022-02-20 18:17 UTC (permalink / raw To: Lars Ingebrigtsen; +Cc: emacs-devel >> * src/lread.c (loadhist_initialize): New function. >> (Fload, readevalloop): Use it. > > It seems like this makes a number of tests fail: Seems to be fixed now, Stefan ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master c3e064013e: (loadhist_initialize): Minor refactoring 2022-02-20 18:17 ` Stefan Monnier @ 2022-02-20 18:21 ` Lars Ingebrigtsen 0 siblings, 0 replies; 3+ messages in thread From: Lars Ingebrigtsen @ 2022-02-20 18:21 UTC (permalink / raw To: Stefan Monnier; +Cc: emacs-devel Stefan Monnier <monnier@iro.umontreal.ca> writes: > Seems to be fixed now, Yup; "make check" now runs cleanly again. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-20 18:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <164529794270.21544.9359599065415833998@vcs2.savannah.gnu.org>
[not found] ` <20220219191223.AD5F7C00894@vcs2.savannah.gnu.org>
2022-02-20 16:25 ` master c3e064013e: (loadhist_initialize): Minor refactoring Lars Ingebrigtsen
2022-02-20 18:17 ` Stefan Monnier
2022-02-20 18:21 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).