From: Lars Ingebrigtsen <larsi@gnus.org>
To: emacs-devel@gnu.org
Cc: Stefan Monnier <monnier@iro.umontreal.ca>
Subject: Re: master c3e064013e: (loadhist_initialize): Minor refactoring
Date: Sun, 20 Feb 2022 17:25:45 +0100 [thread overview]
Message-ID: <87zgmlo67q.fsf@gnus.org> (raw)
In-Reply-To: <20220219191223.AD5F7C00894@vcs2.savannah.gnu.org> (Stefan Monnier via Mailing list for Emacs changes's message of "Sat, 19 Feb 2022 14:12:22 -0500 (EST)")
Stefan Monnier via Mailing list for Emacs changes <emacs-diffs@gnu.org>
writes:
> (loadhist_initialize): Minor refactoring
>
> Consolidate a bit of code.
>
> * src/lread.c (loadhist_initialize): New function.
> (Fload, readevalloop): Use it.
It seems like this makes a number of tests fail:
bin/bash: line 3: 3621759 Aborted HOME=/nonexistent LANG=C EMACS_TEST_DIRECTORY=/home/larsi/src/emacs/trunk/test "../src/emacs" --module-assertions --no-init-file --no-site-file --no-site-lisp -L ":." -l ert -l lisp/emacs-lisp/gv-tests --batch --eval '(ert-run-tests-batch-and-exit (quote (not (or (tag :expensive-test) (tag :unstable)))))' > lisp/emacs-lisp/gv-tests.log 2>&1
Running 8 tests (2022-02-20 17:21:24+0100, selector ‘(not (or (tag :expensive-test) (tag :unstable)))’)
lread.c:1175: Emacs fatal error: assertion failed: STRINGP (filename)
make[3]: *** [Makefile:184: lisp/emacs-lisp/gv-tests.log] Error 134
make[3]: Leaving directory '/home/larsi/src/emacs/trunk/test'
make[2]: [Makefile:341: check-doit] Error 2 (ignored)
SUMMARY OF TEST RESULTS
-----------------------
Files examined: 395
Ran 5965 tests, 158 failed to run, 5835 results as expected, 0 unexpected, 130 skipped
5 files did not finish:
src/lread-tests.log
lisp/simple-tests.log
lisp/emacs-lisp/gv-tests.log
lisp/emacs-lisp/edebug-tests.log
lisp/emacs-lisp/cl-generic-tests.log
This is with --with-native-compilation, if that makes a difference.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next parent reply other threads:[~2022-02-20 16:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <164529794270.21544.9359599065415833998@vcs2.savannah.gnu.org>
[not found] ` <20220219191223.AD5F7C00894@vcs2.savannah.gnu.org>
2022-02-20 16:25 ` Lars Ingebrigtsen [this message]
2022-02-20 18:17 ` master c3e064013e: (loadhist_initialize): Minor refactoring Stefan Monnier
2022-02-20 18:21 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgmlo67q.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).