From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tim Cross Newsgroups: gmane.emacs.devel Subject: Re: Stealing a default face from a non-ELPA package Date: Sat, 05 Mar 2022 18:43:03 +1100 Message-ID: <87zgm4lst1.fsf@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8318"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.7.9; emacs 28.0.91 Cc: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= , emacs-devel@gnu.org To: Brian Leung Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Mar 05 09:17:00 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nQPb1-0001xZ-W7 for ged-emacs-devel@m.gmane-mx.org; Sat, 05 Mar 2022 09:17:00 +0100 Original-Received: from localhost ([::1]:48974 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nQPb0-0006it-Dc for ged-emacs-devel@m.gmane-mx.org; Sat, 05 Mar 2022 03:16:58 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59800) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQPYs-0005dn-5u for emacs-devel@gnu.org; Sat, 05 Mar 2022 03:14:46 -0500 Original-Received: from [2607:f8b0:4864:20::52a] (port=39683 helo=mail-pg1-x52a.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nQPYq-00030w-G2 for emacs-devel@gnu.org; Sat, 05 Mar 2022 03:14:45 -0500 Original-Received: by mail-pg1-x52a.google.com with SMTP id 195so9413569pgc.6 for ; Sat, 05 Mar 2022 00:14:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version; bh=zg1u3hPczSnfsuLt8O1c/hZRmRj5CwTGpDMB+luGwE8=; b=TNcLk5bloEWojlLNiFJrnjIWZn8+2X2pRRrP3WFGI7bMs6wMX+Q6nZWgdCEZdBpetz WxzqqlvQYq66Evo+oxSDDcA8QELZbVAD5y3jg6WJSzLTuZhclFl6c56kyxs2snLjUY+P +klxPyS/YLFGvPkBwStNYGCXxaMEmM9X9XMAcMdKSA9Kklf4bWEllhGjUb/nSMiad3Xy TFkqQ5tgPSXdDt+z5llZyJEGUjlETw6RIomRQj7266QofjtUoPFH30xUUcoQpolBrr/p vK1a8HocL6OmsBgwP2idksdVQRA8EDzhsVUZw7z/Qc9sjT7qJn8vHFjaKQVEsPO2Ikr6 +I/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version; bh=zg1u3hPczSnfsuLt8O1c/hZRmRj5CwTGpDMB+luGwE8=; b=af3UBqN9M70XzSQxyMxKLeae477Fqo8RDPDI2hkazJJnDt/qAhL/jQ1n60kDw28lj0 x4Um7zel/mkzZe8biPyQ6rssQ9MgKWHbsk4sSHTVEBT12unw2UR3eFrBYStAL622teZC thkgftIdPHKhRQKnteOeY1P0t7Am6McrPYelZtnFWFljZbcQEmTzI0CpNhLJiZd1btaK 19JDqZj0YBApy8TVnkGMFNoRs2LEopRI2N1HtpQW9PvtcefuMMbUa2PZMR16yfiSbcr5 qtm1zpk4IGVx/rkv3gVytcdxyI/mGaQQGsdFfF15MCmoKte3eqnrS0B2JMVgZ2P4lp28 au8g== X-Gm-Message-State: AOAM533QtLjGK6wWV0cFs780AYJhD8pkrDzAjlq9crSiRbFVTfHh4dYy aDWB0eHShF3JEkT9vIkdX7s= X-Google-Smtp-Source: ABdhPJyfOcPJILMbBlm4Mrzbc03OB7EjBAJPWe5lvEk8g6czJvAlLtY4abodrWk+7peB25agYdKc3Q== X-Received: by 2002:a05:6a00:acf:b0:4e1:9222:1ef3 with SMTP id c15-20020a056a000acf00b004e192221ef3mr2856424pfl.18.1646468082549; Sat, 05 Mar 2022 00:14:42 -0800 (PST) Original-Received: from dingbat (106-69-94-169.dyn.iinet.net.au. [106.69.94.169]) by smtp.gmail.com with ESMTPSA id v14-20020a056a00148e00b004e1cee6f6b4sm8784825pfu.47.2022.03.05.00.14.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Mar 2022 00:14:42 -0800 (PST) In-reply-to: X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::52a (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::52a; envelope-from=theophilusx@gmail.com; helo=mail-pg1-x52a.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286833 Archived-At: Brian Leung writes: > I sent this question to the mailing list this morning but I can't see it on the > list archives, so I'm trying to send it again: > > In > https://github.com/joaotavora/eglot/discussions/858#discussioncomment-2288255, > a user noticed that lsp-mode used as a face default a much nicer setting > than what currently exists in eglot. Given that lsp-mode is not part of > ELPA, can we steal its setting and use it in eglot? "much nicer" is a very subjective metric. What you think is much nicer I might think is much uglier. Tweaking face properties is really best left to either individuals or theme authors. >From what I can tell in that thread, all that is being proposed is to change the foreground colour of an eglot face to use the same value as a lsp-mode face. If that is the case, I don't see any copyright violation here. All that is being done is changing the value of a face. As the code used to define faces is part of core Emacs, your not talking about code change, only default value change. I do think it is a pointless change. While the proposed new foreground colour might look better to one individual using specific hardware on a specific platform with a specific theme, it could look much worse to another user on a different platform, with different hardware and a different theme who will then log an issue requesting that the face be changed to something they think is a better default setting. Purpose of default face settings should be to set a face which is usable for the widest selection of users, regardless of hardware, platform or type of environment (GUI/Terminal/Console). Fiddling with face aesthetics is best left to theme authors.