From: Tim Cross <theophilusx@gmail.com>
To: Brian Leung <leungbk@posteo.net>
Cc: "João Távora" <joaotavora@gmail.com>, emacs-devel@gnu.org
Subject: Re: Stealing a default face from a non-ELPA package
Date: Sat, 05 Mar 2022 18:43:03 +1100 [thread overview]
Message-ID: <87zgm4lst1.fsf@gmail.com> (raw)
In-Reply-To: <m2k0d9dm60.fsf@posteo.net>
Brian Leung <leungbk@posteo.net> writes:
> I sent this question to the mailing list this morning but I can't see it on the
> list archives, so I'm trying to send it again:
>
> In
> https://github.com/joaotavora/eglot/discussions/858#discussioncomment-2288255,
> a user noticed that lsp-mode used as a face default a much nicer setting
> than what currently exists in eglot. Given that lsp-mode is not part of
> ELPA, can we steal its setting and use it in eglot?
"much nicer" is a very subjective metric. What you think is much nicer I
might think is much uglier. Tweaking face properties is really best left
to either individuals or theme authors.
From what I can tell in that thread, all that is being proposed is to
change the foreground colour of an eglot face to use the same value as a
lsp-mode face. If that is the case, I don't see any copyright violation
here. All that is being done is changing the value of a face. As the
code used to define faces is part of core Emacs, your not talking about
code change, only default value change.
I do think it is a pointless change. While the proposed new foreground
colour might look better to one individual using specific hardware on a
specific platform with a specific theme, it could look much worse to
another user on a different platform, with different hardware and a
different theme who will then log an issue requesting that the face be
changed to something they think is a better default setting.
Purpose of default face settings should be to set a face which is usable
for the widest selection of users, regardless of hardware, platform or
type of environment (GUI/Terminal/Console). Fiddling with face
aesthetics is best left to theme authors.
next prev parent reply other threads:[~2022-03-05 7:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-05 4:59 Stealing a default face from a non-ELPA package Brian Leung
2022-03-05 7:43 ` Tim Cross [this message]
2022-03-05 8:24 ` João Távora
2022-03-05 9:46 ` Tim Cross
2022-03-05 10:29 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgm4lst1.fsf@gmail.com \
--to=theophilusx@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=joaotavora@gmail.com \
--cc=leungbk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).