From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix bookmark-bmenu-list sorting. Date: Mon, 07 Mar 2022 10:21:23 +0100 Message-ID: <87zgm25d9o.fsf@elite.giraud> References: <875yovm1m6.fsf@elite.giraud> <87v8wvkk64.fsf@red-bean.com> <83v8wuj3v0.fsf@gnu.org> <87tucewgu7.fsf@red-bean.com> <83lexqi3z9.fsf@gnu.org> <87tuceuo4b.fsf@red-bean.com> <83czj2hrdv.fsf@gnu.org> <87a6e5lui6.fsf@elite.giraud> <837d99j10x.fsf@gnu.org> <874k4dlpeg.fsf@elite.giraud> <834k4divrt.fsf@gnu.org> <87wnh9k43g.fsf@elite.giraud> <83v8wth5lh.fsf@gnu.org> <87h78afndq.fsf@red-bean.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16233"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (berkeley-unix) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Karl Fogel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Mar 07 10:23:37 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nR9aP-0003bC-FC for ged-emacs-devel@m.gmane-mx.org; Mon, 07 Mar 2022 10:23:25 +0100 Original-Received: from localhost ([::1]:49270 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nR9aN-0005wU-Q2 for ged-emacs-devel@m.gmane-mx.org; Mon, 07 Mar 2022 04:23:23 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56508) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nR9YZ-0005EZ-S5 for emacs-devel@gnu.org; Mon, 07 Mar 2022 04:21:31 -0500 Original-Received: from ledu-giraud.fr ([51.159.28.247]:12895) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nR9YY-0004mX-0f; Mon, 07 Mar 2022 04:21:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=BYUQAxBmaaWqT78h TNe8oadkXPSGsqEsS6QTfLkU17E=; h=in-reply-to:date:references:subject: cc:to:from; d=ledu-giraud.fr; b=spVlA8JPOMMam112i8yUZqgt+G0rEyyO9VsrcZ WIwwgyELd970QH1WIkAk9fJzEHS7VjPM/aPJmbZy148clTqZBKKLjssxFDecyab950sEu7 UlgZu6ynjuhmw/U/P11XUjfxgZ0ryRdhgjzLzzA2QTGzQiMVillGg9JnQx2hiJkBjl672m 4dVwLsEmeyyIBQuje26FdQ+OJnmv4rVhq8MJnt60eHMBduazfmYztwKwQFWXGTI4ZLJbSm 3rtlRVYa7pBCAl8nWpPfPPhIlXweZcxWdwxVh1Mbaf9Rtvk3w41aDiUmy/ZTSWGCUsKPsT aS+JWihjtXfX6tlacqoH5m0A== Original-Received: from elite.giraud ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id c3c508b8 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Mon, 7 Mar 2022 10:21:24 +0100 (CET) In-Reply-To: <87h78afndq.fsf@red-bean.com> (Karl Fogel's message of "Sun, 06 Mar 2022 21:32:49 -0600") Received-SPF: pass client-ip=51.159.28.247; envelope-from=manuel@ledu-giraud.fr; helo=ledu-giraud.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286880 Archived-At: Karl Fogel writes: >>Thanks. >> >>Let's install this on master. We can consider backporting to the >>emacs-28 branch after Emacs 28.1 is released. > > Installed in commit a6abd06c73. Thanks. I've tested both of your patch and they are working as intended: the order is modified between two `bookmark-bmenu-list' call if I change `bookmark-sort-flag'. There is one minor thing left: the tabulated-list bar (I don't how it is called) keep the old information =C2=AB sorted by bookmark name =C2=BB when= I have revert to `bookmark-sort-flag' as nil. --=20 Manuel Giraud