From: Lars Ingebrigtsen <larsi@gnus.org>
To: Kjartan Oli Agustsson <kjartanoli@outlook.com>
Cc: Daniel Nicolai <dalanicolai@gmail.com>, emacs-devel@gnu.org
Subject: Re: [PATCH] Add user stylesheet support for doc-view EPUB support
Date: Mon, 07 Mar 2022 17:31:21 +0100 [thread overview]
Message-ID: <87zgm1912e.fsf@gnus.org> (raw)
In-Reply-To: <GV1P193MB2310407DD82447436468B193DF089@GV1P193MB2310.EURP193.PROD.OUTLOOK.COM> (Kjartan Oli Agustsson's message of "Mon, 07 Mar 2022 00:50:18 +0000")
Kjartan Oli Agustsson <kjartanoli@outlook.com> writes:
> This should take care of that.
Thanks; applied to Emacs 29.
This change was small enough to apply without assigning copyright to the
FSF, but for future patches you want to submit, it might make sense to
get the paperwork started now, so that subsequent patches can be applied
speedily. Would you be willing to sign such paperwork?
> But now there's something else I'm wondering about. If I'm
> understanding `doc-view-custom-set-epub-font-size' correctly, it is
> used as the setter for `doc-view-epub-font-size' to regenerate epub
> documents when it is changed. Am I understanding this correctly, and
> if so would it make sense to do the same for the user stylesheet?
When the contents of the user stylesheet changes? I guess that would
make sense, and you could use `file-has-changed-p' to implement that.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2022-03-07 16:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-06 17:12 [PATCH] Add user stylesheet support for doc-view EPUB support Kjartan Oli Agustsson
2022-03-06 22:07 ` Lars Ingebrigtsen
2022-03-07 0:17 ` Kjartan Oli Agustsson
2022-03-07 0:50 ` Kjartan Oli Agustsson
2022-03-07 16:31 ` Lars Ingebrigtsen [this message]
2022-03-08 23:06 ` Kjartan Oli Agustsson
2022-03-09 13:59 ` Lars Ingebrigtsen
2022-03-09 22:34 ` Kjartan Oli Agustsson
2022-03-12 16:40 ` Lars Ingebrigtsen
2022-03-14 10:25 ` Kjartan Oli Agustsson
2022-03-14 10:32 ` Lars Ingebrigtsen
2022-03-14 11:17 ` Kjartan Oli Agustsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgm1912e.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=dalanicolai@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=kjartanoli@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).