From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] mailcap-add-mailcap-entry: Superfluous setcdr, readability, entry overriding Date: Sat, 12 Mar 2022 18:26:22 +0100 Message-ID: <87zglvytdt.fsf@gnus.org> References: <87tuc9pvp0.fsf@sperrhaken.name> <87sfrr5ika.fsf@gnus.org> <87v8wmbbsb.fsf@sperrhaken.name> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4661"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel To: Felix Dietrich Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Mar 12 18:27:12 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nT5WJ-00014E-LB for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Mar 2022 18:27:11 +0100 Original-Received: from localhost ([::1]:49256 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nT5WI-0005pW-Js for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Mar 2022 12:27:10 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56542) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nT5Vd-0005Ac-F5 for emacs-devel@gnu.org; Sat, 12 Mar 2022 12:26:29 -0500 Original-Received: from [2a01:4f9:2b:f0f::2] (port=40850 helo=quimby.gnus.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nT5Vb-0000Ib-TT for emacs-devel@gnu.org; Sat, 12 Mar 2022 12:26:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=FHtyzdey63oVD3PodN6nbV3fmr0EqQOA6jpSfzmcUkM=; b=cXekc/JyGbZAax7heK6xNDCBEh sa7VviznY9t1y2i3chS3BLmh+0DJfx5gve2H0Vc+jXc1zSl6kSWeIwAiHU4Sk3JTIo7PZy8Jw3sEN v04LYxzE04cP377wZeGzDuJUeIGggoBBe6v0pj5yxLYwtXbheJTlwOjrkDQzuFt+Y7ck=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nT5VW-0001fq-PF; Sat, 12 Mar 2022 18:26:25 +0100 In-Reply-To: <87v8wmbbsb.fsf@sperrhaken.name> (Felix Dietrich's message of "Thu, 10 Mar 2022 06:45:56 +0100") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a01:4f9:2b:f0f::2 (failed) Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287036 Archived-At: Felix Dietrich writes: > I agree that adding some automated tests is a good idea, but, since I am > not familiar with writing these in Emacs Lisp, I will first have to > spent a bit of time with the ERT manual and the existing tests, before I > cans start writing the tests. I don't think you need to read the ERT manual, really -- just have a look at any file in test/lisp/*-tests.el and it should be pretty much self-evident. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no