From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: James N. V. Cash Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Handle case where `beg` and `end` are strings instead of markers Date: Fri, 29 Apr 2022 10:07:33 -0400 Message-ID: <87zgk42day.fsf@occasionallycogent.com> References: <87k0b84tfr.fsf@occasionallycogent.com> <87h76c4ruf.fsf@occasionallycogent.com> <86sfpwwerz.fsf@mail.linkov.net> <87czh03xa9.fsf@occasionallycogent.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5604"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, Juri Linkov To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 29 16:09:14 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nkRJ4-0001Dr-90 for ged-emacs-devel@m.gmane-mx.org; Fri, 29 Apr 2022 16:09:14 +0200 Original-Received: from localhost ([::1]:44260 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nkRJ3-0000qI-6k for ged-emacs-devel@m.gmane-mx.org; Fri, 29 Apr 2022 10:09:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55562) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nkRHW-0006zD-Tf for emacs-devel@gnu.org; Fri, 29 Apr 2022 10:07:38 -0400 Original-Received: from mail-qk1-f172.google.com ([209.85.222.172]:43616) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nkRHU-0002yg-V9 for emacs-devel@gnu.org; Fri, 29 Apr 2022 10:07:38 -0400 Original-Received: by mail-qk1-f172.google.com with SMTP id y6so3832965qke.10 for ; Fri, 29 Apr 2022 07:07:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=vhqoe8Ib2yfXDp8oWkKz4MJ3A6u6i90zvsBpQqWX7J4=; b=4K0dk0QQt4q/Fx6DxllL0HT9U2swMmcDpKXarmBwrdL9qqoDqrjj3guSJBqN481D0W mmPM0nTbkDQb0EnDXTM7FI3+wagq/gO7ncsYgV1DnHsKh9+uIJPrPS/e/q+RIwIjsj15 6ZhBWGRKCPd5zOR5hUj9oIrgET7w9y7ieWSrO+cTCbh4y03pXL4esXNB0OnBlrK7DH9J OkZXYxWfmAXPsHNTIZAbzwHVYPHba+hQxeGPnz9tcNqRYLJlY6rTHx5RTqOAsOJ1XLrh KRgyGB+VZgsm596MBXp+YLC8HLtOJaEQ3HzyPwVynjp+OVXrrqF4+lHuPRZ1RNjH0qLv GItQ== X-Gm-Message-State: AOAM532SPBVfhQBIJthn0eMRBI0DGfbSxPcGK1kL6zPEXkDvgk9+c6e/ UIj4VetSEUaNZyuj3Pe6p/ix9sTS3Gg= X-Google-Smtp-Source: ABdhPJwGinoKmSqRkDNT1StwNIy2vmZq6SkjBBiZxA/xJ85OLLiglXXTZX1H35WutZiYNMuSiX7OtA== X-Received: by 2002:a37:6b07:0:b0:69f:6115:3c9e with SMTP id g7-20020a376b07000000b0069f61153c9emr14677377qkc.508.1651241255835; Fri, 29 Apr 2022 07:07:35 -0700 (PDT) Original-Received: from auth1-smtp.messagingengine.com (auth1-smtp.messagingengine.com. [66.111.4.227]) by smtp.gmail.com with ESMTPSA id d17-20020ac85d91000000b002f365edfd21sm1620670qtx.83.2022.04.29.07.07.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Apr 2022 07:07:35 -0700 (PDT) Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailauth.nyi.internal (Postfix) with ESMTP id ABD4827C0054; Fri, 29 Apr 2022 10:07:34 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 29 Apr 2022 10:07:34 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudelgdejudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufgjfhffkfggtgesthdtredttddttdenucfhrhhomheplfgrmhgvshcu pfdrucggrdcuvegrshhhuceojhgrmhgvshdrnhhvtgesghhmrghilhdrtghomheqnecugg ftrfgrthhtvghrnhepudehtdeukeekiedvfeekudefkeeileejgeehfffhieevuefhkeeu ffefgfeileeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepjhgrmhgvshgptggrshhhodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithih qdduvdefvddtvdejledvqddvjeekgedtudehvddqjhgrmhgvshdrnhhvtgeppehgmhgrih hlrdgtohhmsehotggtrghsihhonhgrlhhlhigtohhgvghnthdrtghomh X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 29 Apr 2022 10:07:34 -0400 (EDT) In-Reply-To: Received-SPF: pass client-ip=209.85.222.172; envelope-from=james.nvc@gmail.com; helo=mail-qk1-f172.google.com X-Spam_score_int: -9 X-Spam_score: -1.0 X-Spam_bar: - X-Spam_report: (-1.0 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, NML_ADSP_CUSTOM_MED=0.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288993 Archived-At: Stefan Monnier writes: >> + (let ((beg (if (number-or-marker-p beg) >> + beg >> + (save-excursion >> + (goto-char (minibuffer-prompt-end)) >> + (search-forward beg)))) >> + (end (if (number-or-marker-p end) >> + end >> + (save-excursion >> + (goto-char (point-max)) >> + (search-backward end))))) > > What if there are several matches for `beg` and/or for `end` in > the buffer? How do we know we got the intended one? A good question; as far as I can tell though, `beg` and `end` are only strings when called via `choose-completion` in `simple.el`, when it passes in `base-affixes`. `base-affixes` is in turn set to `completion-base-affixes`, which gets set in `minibuffer-completion-help`. There, the value that becomes `beg` is `(buffer-substring (minibuffer--completion-prompt-end) (+ start base-size))` and `end` is `(buffer-substring (point) (point-max))`, so I think that changing `minibuffer-prompt-end` in my patch to `minibuffer--completion-prompt-end` would suffice to ensure that it is always matching from the correct point to match the intended positions. James