From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 979308b4ca 5/9: org-export-data: Concatenate strings in temporary buffer for performance Date: Thu, 16 Jun 2022 14:45:26 +0200 Message-ID: <87zgicdbfd.fsf@gnus.org> References: <165536698076.5328.17316430648307086249@vcs2.savannah.gnu.org> <20220616080945.7DD14C01685@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38685"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org, Ihor Radchenko To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 16 15:14:20 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o1pKG-0009qt-FJ for ged-emacs-devel@m.gmane-mx.org; Thu, 16 Jun 2022 15:14:20 +0200 Original-Received: from localhost ([::1]:34294 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o1pKF-00011G-En for ged-emacs-devel@m.gmane-mx.org; Thu, 16 Jun 2022 09:14:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42890) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o1osT-00072M-5r for emacs-devel@gnu.org; Thu, 16 Jun 2022 08:45:39 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:33922) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o1osR-0006ob-9r for emacs-devel@gnu.org; Thu, 16 Jun 2022 08:45:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=19cAfJ/sCrsWuwbiDypTwlB25kG21R7RTuR261UYfyU=; b=o1BheOuV70LzewlrR8jggsDOfq NlrSEZy/pgO2bJ37AhoVZ98WdGSH1QC3EGcuu2yCTS1lVR7P8wmQWDgb74FnHEtCEK9Fn76yGPwSS 66eeGSI9yn6+6GPp0gQ5scgTppmPUL0dGqOHSiR4BJxUDFoER2py2Pw/MJ4YR9z71jvA=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o1osK-00074I-Cf; Thu, 16 Jun 2022 14:45:31 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEUYERNbTU2HZ2TC vr////8cf1h3AAAAAWJLR0QEj2jZUQAAAAd0SU1FB+YGEAwZNRc5ZF8AAAFwSURBVDjLnZPRccMw CIZBWQDwAhJeIBb771aQrBgnaR/KnS8Wn0HwQwAYoSISgz9I4L9QGdy4EAlWAX9KdVDwOcCfhr8C Fja39klU9q8AeHP/ES9NON/Nu2mPF2lNKIHN+jwK65YyFruASAIPB/ONILrPwGaoqq5LCOMKM1pf mD1HC+4YTbyDqFXiVOEYYO+jIddJOAL81FbEMTsSuU4p1dZwBES9xYtlNzojbIHTR2VUvmufBFk1 AJKMiKl4dLjArHXvCzBnxYt1PQG5Sjz1CvM5LOCro9cs9gRYHKzNMH2lEpeWhnihiGnTG4BXBJ8d VtGu8AU8xXqaam+s1nmk6noBtCbqsygHuQhac4O764c81OmUQeymxa23ouZkXKhYYE1FlTkLBYk7 UlE43K0FwAzA3b5jHGMFrimiNw0CD3diBo3YN8loP2DpB+ci+pZ4++/gmtj4i2dLn92A19v4G4g+ +J5zga4L1Fuqzyr+Zz9tRUWH+LRwVQAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMi0wNi0xNlQxMjoy NTo1MyswMDowMFE5NIcAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjItMDYtMTZUMTI6MjU6NTMrMDA6 MDAgZIw7AAAAAElFTkSuQmCC X-Now-Playing: Doubting Thomas's _Father Don't Cry_: "Excrement" In-Reply-To: (Stefan Monnier's message of "Thu, 16 Jun 2022 08:19:33 -0400") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:291244 Archived-At: Stefan Monnier writes: > AFAICT this just replaces `mapconcat` with a `with-temp-buffer + dolist > + insert`, so if this makes a significant performance difference, it > points to a performance problem in our `mapconcat`, right? It looks like it shouldn't be that difficult to improve the performance radically in the common case of FUNCTION being #'identity. If there's no SEPARATOR we can just pass the arguments more or less directly on to Fconcat, and if there is a SEPARATOR, we just have to adjust the arg list. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no