From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: feature/tree-sitter 88d54756d4 2/2: Check for outdated tree-sitter node when printing Date: Thu, 03 Nov 2022 16:09:26 +0800 Message-ID: <87zgd8e9xl.fsf@yahoo.com> References: <166743655413.25449.4460092570974006982@vcs2.savannah.gnu.org> <20221103004915.21875C009EC@vcs2.savannah.gnu.org> <878rksg1z1.fsf@yahoo.com> <405A7004-902F-49A4-9E79-D9F0FC955940@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17099"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 03 09:10:31 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oqVJ1-0004Gu-Gs for ged-emacs-devel@m.gmane-mx.org; Thu, 03 Nov 2022 09:10:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oqVIM-0006kg-B0; Thu, 03 Nov 2022 04:09:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqVIF-0006k3-S5 for emacs-devel@gnu.org; Thu, 03 Nov 2022 04:09:44 -0400 Original-Received: from sonic314-22.consmr.mail.ne1.yahoo.com ([66.163.189.148]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oqVIE-0006VK-1m for emacs-devel@gnu.org; Thu, 03 Nov 2022 04:09:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1667462978; bh=jU/XE4h8+2U9JMYdcFCRwJ2iyM3JJl0Ohk0qNqyiYwU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=jfpI1JDSU7O4GhHRPjg9sKidfHq5eB2yiyXIAwPjHDdCtrL4P/qbqaDYQoOXCxC+RKD7Vx3VdLWtXBC4q3DsRNK4REyMwVuImOvS/5fK0Kue/6xsPVQZE81ZV22/JI01w1BVgc2ZrsM4DaKgMQ2fLYSi5EO+MZThZQkRVSP86auQxEAgRbZb2dmt7eNHo9sKytfPndZTevA8MnzQ0bqrRqm9qkKz5qkIe1HJM7JLfvR47oRTMSxx6cVpBKCkguyho1jXlHHkKrnllfzyAyz5LYWg01xwQy+Ptrwa3YfclcPbN8mas6SNHRUKhA5Tg2ukgag4N089Nc/XVF+FA8S7Ig== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1667462978; bh=1oamuyL4aMhkoh5/f3W+uDhFu+JRY7Ek73zyz0But9R=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=WDNqhGsJ33dh45+XmU+S1IQWo0uVZU6n7DK9F3TdD/KNiJeEuj/1keC1tvPuOKB9uaUdiMjnuiSY5BvvpmWCb+fq6AOtCxtLoK+cf+i9vDzKNYHnQ4/c4F2FB8E7O5IHGy5e55F7XvKFG7Qk85BXAsg2i+w2Wo+HBSPYGmER86hySoBuL9psEIOfM4utdp9cbdUrgswBN33e5Zw4V5g57pRbTZbruhECe4bmZVTFzitCz3XYoMl0vmX3mdVM/oYOu2OXI1GgexxnVKqzQfZV2BhE/jbFQvqviWipHWYOjyVjcId7OGtpC84/NsAmd5PYttIGgen+oYKWhwK3DnZ0XQ== X-YMail-OSG: z_0mH_wVM1lsebQ.8mtr016szG3IWOgR3ud3Zk46Bnsic2v0qL_0QcDTBNlJel_ DQHp4daYH8d9MnCvR5ttLNlekKzXGNsD0IEDwiff27ol0hFmV8lhO9R8hwmltqkYCqSkkrJynJE4 G5cCNak2WU4FGhhk5UO4RyyBLzx_FrK_liBKTaD5EeCBYhLAlEybl7O_vpQyYUjRcDBASA3I69NA afRFKOgxPsJHGTTX6QFA1TRjBcb7I5ACClK3ahvNWNzNJIzhviJaKY9wgaAx.45PzjnnaMOtSOoo 4ulYX7KSi_SRFX8AdlcQelcAs51S8W1nHFohayjdCe1_KMSRmO5gxNELo41aJP_6g_0jcRZ1vuuD sHajeOhjNslNxrJl6xO7dDOIiQq0KKHl4TOi2g_GovrMLi3gKlrEGi81gdvKT6HjDiJMbLfQ8aWT ag8MbPrkOyTtl8iR39UShqW2_qN.GqdePPIAr.1TQ12AeLKloKxbE.4twbMoIxZq.xPlDoltZj8Q 4RDe4gEMiNqKGT7kncHh0zV9tTpk6Msgxu0IRxa_IM0D8mKCLHFFEgJ27nMX_OtlWxDkieJE9kS3 Jc3PHtkS20ngAJt9SgqX2V4UkaNuMUEVgWkY28Zq_I_rzjBWHDZSNVW2SUmX04amFov90YXcEB1Z 8qTQ5pks3f4Dj9jmCLRd3lWMPe7q2fdwHSdTsOk0krU_dZ7YgwK0XLKJT1CJr0C.yYbCF99n4ggK .AjKzNi5Zfr_krg6DO3CPQ_SbhG3WyA.v3NqZc40vw_vToBevwxeCEBxR9GHNBmqUUjdr2Cbh89I hn6snLAuXAZ3ULrBVdJGBybVC1x7c5FIkBniiEuTKp X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.ne1.yahoo.com with HTTP; Thu, 3 Nov 2022 08:09:38 +0000 Original-Received: by hermes--production-sg3-6c8895b545-qz6cd (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID b530d3a981ff39c6b0e336ea5e3b835f; Thu, 03 Nov 2022 08:09:31 +0000 (UTC) In-Reply-To: <405A7004-902F-49A4-9E79-D9F0FC955940@gmail.com> (Yuan Fu's message of "Wed, 2 Nov 2022 20:51:20 -0700") X-Mailer: WebService/1.1.20783 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.189.148; envelope-from=luangruo@yahoo.com; helo=sonic314-22.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299063 Archived-At: Yuan Fu writes: > Cool, thanks. I=E2=80=99ll fix them. Thanks. > Ah yes, sorry. I though you are going to change your patch and forgot > to follow up. Everything indeed works, except for the following > > - return Fmapconcat (intern_c_string ("treesit-pattern-expand"), > - query, build_pure_c_string (" ")); > + return Fmapconcat (Qtreesit_pattern_expand, > > Which breaks a test. Why remove the space? Tree-sitter probably can > parse it fine without the spaces, but the result is also viewed by > users in some cases, where spaces are much appreciated. That was a typo; I just tried to get rid of the extra call to intern_c_string. So if you're fine with the patch (once I fix the typos), I'll install it. Is that okay?