From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: feature/package-vc has been merged Date: Mon, 14 Nov 2022 11:41:16 +0000 Message-ID: <87zgct2277.fsf@posteo.net> References: <164484721900.31751.1453162457552427931@vcs2.savannah.gnu.org> <87sfiyk3a2.fsf_-_@posteo.net> <87mt948pmo.fsf@posteo.net> <87fsevyxnt.fsf@posteo.net> <87zgd1f70g.fsf@posteo.net> <878rkkbj90.fsf@posteo.net> <87edua7jw5.fsf@posteo.net> <878rki7jf3.fsf@posteo.net> <871qq81u3m.fsf@posteo.net> <87sfinwd6c.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21021"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , Richard Stallman , emacs-devel@gnu.org, 'Eli Zaretskii' To: Rudolf =?utf-8?Q?Adamkovi=C4=8D?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Nov 15 00:57:50 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oujKo-0005AI-2J for ged-emacs-devel@m.gmane-mx.org; Tue, 15 Nov 2022 00:57:50 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ouinV-0007pd-QD; Mon, 14 Nov 2022 18:23:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouifm-0006LU-BC for emacs-devel@gnu.org; Mon, 14 Nov 2022 18:15:29 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouXq5-0003Mx-SA for emacs-devel@gnu.org; Mon, 14 Nov 2022 06:41:25 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 64CAB240027 for ; Mon, 14 Nov 2022 12:41:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1668426080; bh=ITKBezn6z6FOvB9Y7CzajMMQaMfb5UJiJOvwqMZa7Xw=; h=From:To:Cc:Subject:Date:From; b=oXrfukFeuJLZ61z++vo42kitzYcGPV4PRShwdpNL3iJdF6eKmidQ1bcuUR2Ucntfj qHBp+ZEi8Lty9kPUyzvwUyFn49LZmwCyJQI3flvM/zJb0iNUS4dYO20bESb77FVAvD 4FG7Jt8Q9Rw72V2Y7fm2XK6W65XIF9ccyEOhd8IV/LSbyNI31C6ipzTd8nlEAVVdsC v1/9zwu6T7NQIT1bfWHEPgBv6/GJIAF7XPLJtgQfWaXx82GVypW4+cKQLuIeu+LgLm TP/hgNCeyr8vyo5MTjLovirMQ3P0EnHFjJ31tyRX243EG12b9pu5j5q9xbQ6vPp3GF 7ZB4Q6Bhbb1Tw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N9nSr73Mkz6tmH; Mon, 14 Nov 2022 12:41:16 +0100 (CET) In-Reply-To: ("Rudolf =?utf-8?Q?Adamkovi=C4=8D=22'?= =?utf-8?Q?s?= message of "Sun, 13 Nov 2022 23:11:02 +0100") Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299779 Archived-At: Rudolf Adamkovi=C4=8D writes: > Philip Kaludercic writes: > >>> That said, When I updated my config to install from VC, I noticed >>> that `elpa' in `.emacs.d' now contained two versions of the packages, >>> one from `package' and one from `package-vc'. >> >> This seems like an issue of what perspective one takes. I don't see >> package-vc as an "upgrade" over package, but as an alternative backend >> for fetching source code. Not even I plan to use it for everything, >> rather I'd install a source package when I am hacking on some package, >> and when I have sent out the patches and am done with it, I'd remove >> the source package and be left with the previous installation. > > I like the backend idea, but the two systems, non-VC and VC, define > separate lists of selected packages. But then, what happens when the > user selects the same package in both lists? Will that lead to any > problems? If so, then we should not allow the user to do that, or deal > with it in some way. No, I have "arrogantly" made sure that source packages are prioritised over regular (tarball, built-in, system) packages. >>> As a side note, you mentioned that `package-install' works for both >>> "normal" and VC packages? I guess `package-autoremove' does that too? >>> I looked at the documentation for both and they mention just >>> `package-selected-packages'. >> >> I don't think I said "package-install works for both normal and VC >> packages"? package-install fetches a tarball, package-vc-install >> fetches a repository? > > I apologize for confusion. > > Perhaps you said that for `package-update'? (I remain a bit confused > about which commands apply to both VC and non-VC packages.) Unless I have forgotten something, the only commands from package.el that apply to both package.el and package-vc.el are - package-delete - package-update - package-update-all >>> And speaking of `-autoremove', should we also add `-vc-autoremove'? >> >> I don't think so, because -autoremove is for removing non-selected >> packages, while all source packages are selected (you'll find that >> package-vc uses regular tarball packages if dependencies have to be >> installed). > > Really? I thought VC `-install' works like the non-VC kind, meaning it > does not select anything, just installs a package so that the user can > quickly try it. But you say "all source packages are selected". If you package-install a package, it is selected and won't be removed. Quote the docstring: Mark the installed package as selected by adding it to =E2=80=98package-selected-packages=E2=80=99. The only non-selected packages are all transitive dependencies. >>> For the only problem I have, I could not install `geiser'. I got >>> "user-error: Package has no VC data", and I kept wondering what the user >>> should do in this situation. I had no idea where to look. >> >> That sounds wrong, there seems to be a specification in >> elpa-packages.eld: >> >> ("geiser" :url "https://gitlab.com/emacs-geiser/geiser.git" :lisp-dir >> "elisp" :readme "readme.org" :doc "doc/geiser.texi") >> >> Maybe this is related to MELPA? They don't have package specification >> lists yet, and if their package is prioritised (due to their versioning >> scheme), maybe this could confused package-vc? > > I tried the following two experiments, starting from: > > (with-eval-after-load 'package > (add-to-list > 'package-archives > '("melpa" . "https://melpa.org/packages/")) > (add-to-list > 'package-archives > '("melpa-stable" . "https://stable.melpa.org/packages/"))) > > Experiment 1: Add MELPA to the end of the list. > > (with-eval-after-load 'package > (add-to-list > 'package-archives > '("melpa" . "https://melpa.org/packages/") > t) ; <------ `t' means the end of the list > (add-to-list > 'package-archives > '("melpa-stable" . "https://stable.melpa.org/packages/") > t)) ; <------ `t' means the end of the list > > This *did not* help. > > Experiment 2: Comment out MELPA. > > ;; (with-eval-after-load 'package > ;; (add-to-list > ;; 'package-archives > ;; '("melpa" . "https://melpa.org/packages/")) > ;; (add-to-list > ;; 'package-archives > ;; '("melpa-stable" . "https://stable.melpa.org/packages/"))) > > This *did* help. > > If the user has MELPA at the end of the list, it should just work. So, > that needs fixing. But the question becomes, what should happen if the > user has MELPA at the beginning of the list. VC could fail, but it > could also proceed, silently or with a message. You can see what is going on in `package-vc--desc->spec'. What we could do is replace the (if (package-desc-archive pkg-desc) (alist-get (intern (package-desc-archive pkg-desc)) package-vc--archive-spec-alist) (mapcan #'append (mapcar #'cdr package-vc--archive-spec-alist))) with just (mapcan #'append (mapcar #'cdr package-vc--archive-spec-alist)) but that might be confusing in other situations (the code here is preparing an alist of package names to specifications). >>> I will try more packages in the coming days or weeks! >> >> Very appreciative. But this is a good sign that after bug#59109 has >> been resolved, the changes can be applied back onto master. >> >>> P.S. The documentation for the `package-vc-selected-packages' variable >>> contains a typo "... you cal also use ...". >> >> Will fix, thanks! > > Super! > > Also, the documentation for the `package-vc-install' function needs some > blank lines between paragraphs. :) I don't know, is that conventional? I believe to have seen both, but never knew which was the "right" way. > Rudy