From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 350918e7be: Adjust x_display_set_last_user_time for Xlib sign-extension Date: Tue, 22 Nov 2022 21:16:02 +0800 Message-ID: <87zgcj2kq5.fsf@yahoo.com> References: <166912189923.20568.14093477497390803497@vcs2.savannah.gnu.org> <20221122125819.904D2C0E4B5@vcs2.savannah.gnu.org> <87cz9f9loe.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13642"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Nov 22 14:16:52 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxT8t-0003Pz-Rt for ged-emacs-devel@m.gmane-mx.org; Tue, 22 Nov 2022 14:16:51 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxT8O-0006O3-9U; Tue, 22 Nov 2022 08:16:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxT8K-0006Mu-A6 for emacs-devel@gnu.org; Tue, 22 Nov 2022 08:16:17 -0500 Original-Received: from sonic314-20.consmr.mail.ne1.yahoo.com ([66.163.189.146]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxT8H-0002Ki-HN for emacs-devel@gnu.org; Tue, 22 Nov 2022 08:16:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1669122971; bh=COca5u4zZJ0vXGhyxwwYyQPJxumBaUMY8DXr1in1L1M=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=C7WbhXW8LCK9j8fqoQfyfawRI5qQg67zkGcUDSK8+T7AU1N9NdjecHOSicZRYbfjkqySybBKp8PJrytkyyJ37rL4PpEIJhCoF/lLdnZL8tLCT0+p4WJAGIwfyQWweoRLU3KxROByxs8JGSVteRLu3/Lqww8wRNIxLjpS8RgVeSUUPE40yA1gCLGhb2TV6Ulwmon8o+fjea5DjmlesB2BCVuSBJ9tW7Ibyl8XIT8oQdpOYraQy/AVSjh7G/tkmB78NFAI9P2GvkdbQHOKKIbsJjfww2RSK9wIue1XEhu5Yfj9cbW3XtMCXux94YsAs3Nuj5wep13qDdiMa9+YnLv6kw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1669122971; bh=1D4CH6OMQ5/UoJWnnfAiInlBS3uDX23pDyVehe3AemU=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=D9R4nw9W5MyYKvhZSp0j29t+o2n9mwV07wPTv6FlT+x5R+hGuHZuzIx9P2KL0AloD5ZTWpu5ncuBZPGzDf6HZvqvQWx1R3KfDU6lgyB64EIiBupKpTBzT9+fufcXkxYnOKL+QlQaq1AxxzBshGoutOiYDykDcXRR8ESniIxZNt/to9+TXxH0wf8KimOb3RJFBTFCC+R826B5X/tP2w3Rho/FIYAVx2IMuBk6W3m2uiSP5C2eDb9nZMmVzH+NNphouOxFup/Gt1PVRHlYyYiMAgoKLMkt0GBb7Lf1yavZe8eU3HYMah2tz01vznvM72moc7FtDgymO2CPb2GlQGE5BA== X-YMail-OSG: 8b6ATWAVM1lZ1IzV39h5dUTWGd7JtQi2Bp5xEkvidpk7pS1wAibzfUFmKtotq65 VljJHg8aFJZ_BHGFdnHMwAzvEw79vAtAI7GszogEwBtBbdmJCdCT7j1zTsHN3gly5cxYzDX1i3Ei rEytozYTqurbT9Lch7wR7G9usAhP7Ogr0z3DqZWGDZRiIETadJpXyATu.LgTpmnW6Ebo3EbSURSV 8CK5brhQ5N_44YZ8u5ToWg7JQg.uV8SLAsFeuzlJmHsRwJ5opl.LakQuklZY62Eh_KxdwQY6XBLl .zGuEMnjKJFmQUofyvtdV3WJGy0bZnJ83WWnwponSTBhiOfLTH.B0Rk0PM2nY6hCxRprrzeq4Bs_ 9JLRziJsJUkY0bHSMgb1l6YOjvTfKgkMQ2kNj1ghptwYjacEXVlQk25HIGqYGLx2WaoaYdlho3VH PGTxiFIsnS6YT8x8jndkBqIAoVpIKt0j9JwMHkCEDF6qBCJc5CmBy4xi9hLi3V4jWMH2wUfPzJ_I Nxqj.FP5OkKvKpstviBZS.j2l6rAy2NphRW_WIWlFlGa6ZYi4K8OoTI2AhrSSy4RcmOP2KDCuBVD bhjbjJsmUms0Bg.z4j3xF8MLTwrMhUk4AaD6JPnzqA7txYfndy4iXMV8JqnNBesYtqxYuwRgd8Th .dbmKmNoCFMuxMXvmtEK672w4pKU5qEbJlDX.fNuR97oru4mICXxBs.Q1Ve8ewTcS3yVsoEf6O_Q HeqkyYITQrb0WzDF2CcAgr2rdfvjLAUPQMBGyoZNNB2aeX_DhR0JQwrnwmFpaT4r3w6.CcGxJDyQ Qd8str6G.OC7VadNobOeU6IBV7Io5zPhXUM_P8QIE5 X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.ne1.yahoo.com with HTTP; Tue, 22 Nov 2022 13:16:11 +0000 Original-Received: by hermes--production-sg3-6c8895b545-qz6cd (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 9e255529200f00ee3d68d975320d9cfd; Tue, 22 Nov 2022 13:16:08 +0000 (UTC) In-Reply-To: <87cz9f9loe.fsf@gmail.com> (Robert Pluim's message of "Tue, 22 Nov 2022 14:13:37 +0100") X-Mailer: WebService/1.1.20863 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.189.146; envelope-from=luangruo@yahoo.com; helo=sonic314-20.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300333 Archived-At: Robert Pluim writes: >>>>>> On Tue, 22 Nov 2022 07:58:19 -0500 (EST), Po Lu via Mailing list for= Emacs changes said: > Po Lu> + /* Time can be sign extended if retrieved from a client mes= sage. > Po Lu> + Make sure it is always 32 bits, or systems with 64-bit l= ongs > Po Lu> + will crash after 24 days of X server uptime. (bug#59480= ) */ > Po Lu> + time &=3D X_ULONG_MAX; > Po Lu> + > Po Lu> #ifdef ENABLE_CHECKING > Po Lu> eassert (time <=3D X_ULONG_MAX); > Po Lu> #endif > > You could even remove the `eassert' now, but it=CA=BCs a minor thing. > > Robert Right, I missed that.